Skip to content

Commit dca9389

Browse files
authored
Handle empty fields in SolarEdge config flow (home-assistant#155978)
1 parent d3bebd9 commit dca9389

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

homeassistant/components/solaredge/config_flow.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -133,8 +133,11 @@ async def async_step_user(
133133

134134
if api_key_ok and web_login_ok:
135135
data = {CONF_SITE_ID: site_id}
136-
data.update(api_auth)
137-
data.update(web_auth)
136+
if api_key:
137+
data[CONF_API_KEY] = api_key
138+
if username:
139+
data[CONF_USERNAME] = username
140+
data[CONF_PASSWORD] = web_auth[CONF_PASSWORD]
138141

139142
if self.source == SOURCE_RECONFIGURE:
140143
if TYPE_CHECKING:

tests/components/solaredge/test_config_flow.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,10 @@ async def test_user_api_key(
5454
CONF_NAME: NAME,
5555
CONF_SITE_ID: SITE_ID,
5656
CONF_SECTION_API_AUTH: {CONF_API_KEY: API_KEY},
57+
CONF_SECTION_WEB_AUTH: {
58+
CONF_USERNAME: "",
59+
CONF_PASSWORD: "",
60+
},
5761
},
5862
)
5963
assert result.get("type") is FlowResultType.CREATE_ENTRY
@@ -85,6 +89,7 @@ async def test_user_web_login(
8589
{
8690
CONF_NAME: NAME,
8791
CONF_SITE_ID: SITE_ID,
92+
CONF_SECTION_API_AUTH: {CONF_API_KEY: ""},
8893
CONF_SECTION_WEB_AUTH: {
8994
CONF_USERNAME: USERNAME,
9095
CONF_PASSWORD: PASSWORD,

0 commit comments

Comments
 (0)