Skip to content

Commit e65c47b

Browse files
Add quality scale definition to Awair (home-assistant#150234)
Co-authored-by: Joost Lekkerkerker <[email protected]>
1 parent 24dba24 commit e65c47b

File tree

4 files changed

+101
-4
lines changed

4 files changed

+101
-4
lines changed

CODEOWNERS

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

homeassistant/components/awair/manifest.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"domain": "awair",
33
"name": "Awair",
4-
"codeowners": ["@ahayworth", "@danielsjf"],
4+
"codeowners": ["@ahayworth", "@ricohageman"],
55
"config_flow": true,
66
"documentation": "https://www.home-assistant.io/integrations/awair",
77
"iot_class": "local_polling",
Lines changed: 98 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,98 @@
1+
rules:
2+
# Bronze
3+
action-setup:
4+
status: exempt
5+
comment: No actions defined
6+
appropriate-polling:
7+
status: done
8+
comment: |
9+
We fetch both user and devices, could probably slow one down
10+
brands: done
11+
common-modules: done
12+
config-flow:
13+
status: todo
14+
comment: |
15+
data_description fields are missing
16+
Should not abort in cloud step when anything else than invalid access token
17+
Find out why access token is optional
18+
Discovered devices step is redundant
19+
config-flow-test-coverage:
20+
status: todo
21+
comment: |
22+
Move happy flow to the top and merge with `test_show_form`
23+
Reuse `result`
24+
Cloud tests should initialize with data directly
25+
Tests should finish in CREATE_ENTRY
26+
dependency-transparency:
27+
status: todo
28+
comment: |
29+
Dependency is not built in the CI
30+
docs-actions: todo
31+
docs-high-level-description: done
32+
docs-installation-instructions: done
33+
docs-removal-instructions: done
34+
entity-event-setup:
35+
status: exempt
36+
comment: No explicit event subscription
37+
entity-unique-id: done
38+
has-entity-name: done
39+
runtime-data: done
40+
test-before-configure: done
41+
test-before-setup: done
42+
unique-config-entry: done
43+
44+
# Silver
45+
action-exceptions:
46+
status: exempt
47+
comment: No actions defined
48+
config-entry-unloading: done
49+
docs-configuration-parameters: todo
50+
docs-installation-parameters: todo
51+
entity-unavailable: todo
52+
integration-owner: done
53+
log-when-unavailable: done
54+
parallel-updates: todo
55+
reauthentication-flow: done
56+
test-coverage:
57+
status: todo
58+
comment: |
59+
Patch objects where we use them
60+
Use test helpers to load JSON
61+
typo `no_devicess_fixture`
62+
Make common config entries for cloud and local
63+
Test setup of the integration
64+
65+
# Gold
66+
devices:
67+
status: done
68+
comment: |
69+
Can move to shorthand attribute
70+
Can remove typecast
71+
diagnostics: todo
72+
discovery: done
73+
discovery-update-info: done
74+
docs-data-update: done
75+
docs-examples: todo
76+
docs-known-limitations: todo
77+
docs-supported-devices: todo
78+
docs-supported-functions: todo
79+
docs-troubleshooting: todo
80+
docs-use-cases: todo
81+
dynamic-devices: todo
82+
entity-category: todo
83+
entity-device-class:
84+
status: done
85+
comment: |
86+
Can remove rounding
87+
entity-disabled-by-default: done
88+
entity-translations: done
89+
exception-translations: todo
90+
icon-translations: done
91+
reconfiguration-flow: todo
92+
repair-issues: todo
93+
stale-devices: todo
94+
95+
# Platinum
96+
async-dependency: todo
97+
inject-websession: done
98+
strict-typing: todo

script/hassfest/quality_scale.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,6 @@ class Rule:
186186
"aussie_broadband",
187187
"avea",
188188
"avion",
189-
"awair",
190189
"aws",
191190
"axis",
192191
"azure_data_explorer",

0 commit comments

Comments
 (0)