Skip to content

Commit e8a534b

Browse files
authored
Add missing method mock to Reolink chime test (home-assistant#147447)
1 parent 3148719 commit e8a534b

File tree

2 files changed

+9
-4
lines changed

2 files changed

+9
-4
lines changed

tests/components/reolink/conftest.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -274,6 +274,7 @@ def reolink_chime(reolink_host: MagicMock) -> None:
274274
"people": {"switch": 0, "musicId": 1},
275275
"visitor": {"switch": 1, "musicId": 2},
276276
}
277+
TEST_CHIME.remove = AsyncMock()
277278

278279
reolink_host.chime_list = [TEST_CHIME]
279280
reolink_host.chime.return_value = TEST_CHIME

tests/components/reolink/test_init.py

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77

88
from freezegun.api import FrozenDateTimeFactory
99
import pytest
10-
from reolink_aio.api import Chime
1110
from reolink_aio.exceptions import (
1211
CredentialsInvalidError,
1312
LoginPrivacyModeError,
@@ -270,22 +269,25 @@ async def test_removing_disconnected_cams(
270269

271270

272271
@pytest.mark.parametrize(
273-
("attr", "value", "expected_models"),
272+
("attr", "value", "expected_models", "expected_remove_call_count"),
274273
[
275274
(
276275
None,
277276
None,
278277
[TEST_HOST_MODEL, TEST_CAM_MODEL, CHIME_MODEL],
278+
1,
279279
),
280280
(
281281
"connect_state",
282282
-1,
283283
[TEST_HOST_MODEL, TEST_CAM_MODEL],
284+
0,
284285
),
285286
(
286287
"remove",
287288
-1,
288289
[TEST_HOST_MODEL, TEST_CAM_MODEL],
290+
1,
289291
),
290292
],
291293
)
@@ -294,12 +296,13 @@ async def test_removing_chime(
294296
hass_ws_client: WebSocketGenerator,
295297
config_entry: MockConfigEntry,
296298
reolink_host: MagicMock,
297-
reolink_chime: Chime,
299+
reolink_chime: MagicMock,
298300
device_registry: dr.DeviceRegistry,
299301
entity_registry: er.EntityRegistry,
300302
attr: str | None,
301303
value: Any,
302304
expected_models: list[str],
305+
expected_remove_call_count: int,
303306
) -> None:
304307
"""Test removing a chime."""
305308
reolink_host.channels = [0]
@@ -324,7 +327,7 @@ async def test_remove_chime(*args, **key_args):
324327
"""Remove chime."""
325328
reolink_chime.connect_state = -1
326329

327-
reolink_chime.remove = test_remove_chime
330+
reolink_chime.remove = AsyncMock(side_effect=test_remove_chime)
328331
elif attr is not None:
329332
setattr(reolink_chime, attr, value)
330333

@@ -334,6 +337,7 @@ async def test_remove_chime(*args, **key_args):
334337
if device.model == CHIME_MODEL:
335338
response = await client.remove_device(device.id, config_entry.entry_id)
336339
assert response["success"] == expected_success
340+
assert reolink_chime.remove.call_count == expected_remove_call_count
337341

338342
device_entries = dr.async_entries_for_config_entry(
339343
device_registry, config_entry.entry_id

0 commit comments

Comments
 (0)