Skip to content

Commit fb30535

Browse files
authored
Make huawei_lte button and select names translatable (home-assistant#155058)
1 parent 7249a3c commit fb30535

File tree

4 files changed

+7
-12
lines changed

4 files changed

+7
-12
lines changed

homeassistant/components/huawei_lte/button.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ class ClearTrafficStatisticsButton(BaseButton):
7070

7171
entity_description = ButtonEntityDescription(
7272
key=BUTTON_KEY_CLEAR_TRAFFIC_STATISTICS,
73-
name="Clear traffic statistics",
73+
translation_key="clear_traffic_statistics",
7474
entity_category=EntityCategory.CONFIG,
7575
)
7676

@@ -87,7 +87,6 @@ class RestartButton(BaseButton):
8787

8888
entity_description = ButtonEntityDescription(
8989
key=BUTTON_KEY_RESTART,
90-
name="Restart",
9190
device_class=ButtonDeviceClass.RESTART,
9291
entity_category=EntityCategory.CONFIG,
9392
)

homeassistant/components/huawei_lte/quality_scale.yaml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -61,9 +61,7 @@ rules:
6161
entity-category: done
6262
entity-device-class: done
6363
entity-disabled-by-default: done
64-
entity-translations:
65-
status: todo
66-
comment: Buttons and selects are lacking translations.
64+
entity-translations: done
6765
exception-translations: todo
6866
icon-translations:
6967
status: done

homeassistant/components/huawei_lte/select.py

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
from homeassistant.core import HomeAssistant
2020
from homeassistant.helpers.entity import Entity
2121
from homeassistant.helpers.entity_platform import AddConfigEntryEntitiesCallback
22-
from homeassistant.helpers.typing import UNDEFINED
2322

2423
from . import Router
2524
from .const import DOMAIN, KEY_NET_NET_MODE
@@ -47,7 +46,6 @@ async def async_setup_entry(
4746
desc = HuaweiSelectEntityDescription(
4847
key=KEY_NET_NET_MODE,
4948
entity_category=EntityCategory.CONFIG,
50-
name="Preferred network mode",
5149
translation_key="preferred_network_mode",
5250
options=[
5351
NetworkModeEnum.MODE_AUTO.value,
@@ -95,11 +93,6 @@ def __init__(
9593
self.key = key
9694
self.item = item
9795

98-
name = None
99-
if self.entity_description.name != UNDEFINED:
100-
name = self.entity_description.name
101-
self._attr_name = name or self.item
102-
10396
def select_option(self, option: str) -> None:
10497
"""Change the selected option."""
10598
self.entity_description.setter_fn(option)

homeassistant/components/huawei_lte/strings.json

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,11 @@
6868
"name": "Wi-Fi status"
6969
}
7070
},
71+
"button": {
72+
"clear_traffic_statistics": {
73+
"name": "Clear traffic statistics"
74+
}
75+
},
7176
"select": {
7277
"preferred_network_mode": {
7378
"name": "Preferred network mode",

0 commit comments

Comments
 (0)