diff --git a/homeassistant/components/nest/quality_scale.yaml b/homeassistant/components/nest/quality_scale.yaml index 969ee66059d95..1f1714362fcd4 100644 --- a/homeassistant/components/nest/quality_scale.yaml +++ b/homeassistant/components/nest/quality_scale.yaml @@ -1,8 +1,6 @@ rules: # Bronze - config-flow: - status: todo - comment: Some fields are missing a data_description + config-flow: done brands: done dependency-transparency: done common-modules: diff --git a/homeassistant/components/nest/strings.json b/homeassistant/components/nest/strings.json index 8c50664e70cfb..3f60f8126a807 100644 --- a/homeassistant/components/nest/strings.json +++ b/homeassistant/components/nest/strings.json @@ -34,6 +34,9 @@ "data": { "cloud_project_id": "Google Cloud Project ID" }, + "data_description": { + "cloud_project_id": "The Google Cloud Project ID which can be obtained from the Cloud Console" + }, "description": "Enter the Cloud Project ID below e.g. *example-project-12345*. See the [Google Cloud Console]({cloud_console_url}) or the documentation for [more info]({more_info_url}).", "title": "Nest: Enter Cloud Project ID" }, @@ -45,6 +48,9 @@ "data": { "project_id": "Device Access Project ID" }, + "data_description": { + "project_id": "The Device Access Project ID which can be obtained from the Device Access Console" + }, "description": "Create a Nest Device Access project which **requires paying Google a US $5 fee** to set up.\n1. Go to the [Device Access Console]({device_access_console_url}), and through the payment flow.\n1. Select on **Create project**\n1. Give your Device Access project a name and select **Next**.\n1. Enter your OAuth Client ID\n1. Skip enabling events for now and select **Create project**.\n\nEnter your Device Access Project ID below ([more info]({more_info_url})).", "title": "Nest: Create a Device Access Project" }, @@ -64,6 +70,9 @@ "data": { "subscription_name": "Pub/Sub subscription name" }, + "data_description": { + "subscription_name": "The Pub/Sub subscription name to receive Nest device updates" + }, "description": "Home Assistant receives realtime Nest device updates with a Cloud Pub/Sub subscription for topic `{topic}`.\n\nSelect an existing subscription below if one already exists, or the next step will create a new one for you. See the integration documentation for [more info]({more_info_url}).", "title": "Configure Cloud Pub/Sub subscription" }, @@ -71,6 +80,9 @@ "data": { "topic_name": "Pub/Sub topic name" }, + "data_description": { + "topic_name": "The Pub/Sub topic name configured in the Device Access Console" + }, "description": "Nest devices publish updates on a Cloud Pub/Sub topic. You can select an existing topic if one exists, or choose to create a new topic and the next step will create it for you with the necessary permissions. See the integration documentation for [more info]({more_info_url}).", "title": "Configure Cloud Pub/Sub topic" }, diff --git a/homeassistant/components/sonos/manifest.json b/homeassistant/components/sonos/manifest.json index bf1dea7154410..18f406b5f63e7 100644 --- a/homeassistant/components/sonos/manifest.json +++ b/homeassistant/components/sonos/manifest.json @@ -9,7 +9,11 @@ "iot_class": "local_push", "loggers": ["soco", "sonos_websocket"], "quality_scale": "bronze", - "requirements": ["soco==0.30.12", "sonos-websocket==0.1.3"], + "requirements": [ + "defusedxml==0.7.1", + "soco==0.30.12", + "sonos-websocket==0.1.3" + ], "ssdp": [ { "st": "urn:schemas-upnp-org:device:ZonePlayer:1" diff --git a/requirements_all.txt b/requirements_all.txt index 2b791dd85c982..107cdbac3f352 100644 --- a/requirements_all.txt +++ b/requirements_all.txt @@ -786,6 +786,7 @@ deebot-client==16.3.0 # homeassistant.components.ihc # homeassistant.components.namecheapdns # homeassistant.components.ohmconnect +# homeassistant.components.sonos defusedxml==0.7.1 # homeassistant.components.deluge diff --git a/requirements_test_all.txt b/requirements_test_all.txt index cb4f8e97b337b..4f64c9f8fb177 100644 --- a/requirements_test_all.txt +++ b/requirements_test_all.txt @@ -686,6 +686,7 @@ deebot-client==16.3.0 # homeassistant.components.ihc # homeassistant.components.namecheapdns # homeassistant.components.ohmconnect +# homeassistant.components.sonos defusedxml==0.7.1 # homeassistant.components.deluge