Commit 2db9995
committed
[Flight] Allow cyclic references to be serialized when unwrapping lazy elements (facebook#35471)
When `renderModelDestructive` unwraps a lazy element and subsequently
calls `renderModelDestructive` again with the resolved model, we should
preserve the parent connection so that cyclic references can be
serialized properly. This can occur in an advanced scenario where the
result from the Flight Client is serialized again with the Flight
Server, e.g. for slicing a precomputed payload into multiple parts.
Note: The added test only fails when run with `--prod`. In dev mode, the
component info outlining prevents the issue from occurring.
DiffTrain build for [6baff7a](facebook@6baff7a)1 parent 04cc857 commit 2db9995
File tree
34 files changed
+86
-86
lines changed- compiled/facebook-www
34 files changed
+86
-86
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1497 | 1497 | | |
1498 | 1498 | | |
1499 | 1499 | | |
1500 | | - | |
| 1500 | + | |
1501 | 1501 | | |
1502 | 1502 | | |
1503 | 1503 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1497 | 1497 | | |
1498 | 1498 | | |
1499 | 1499 | | |
1500 | | - | |
| 1500 | + | |
1501 | 1501 | | |
1502 | 1502 | | |
1503 | 1503 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
614 | 614 | | |
615 | 615 | | |
616 | 616 | | |
617 | | - | |
| 617 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
614 | 614 | | |
615 | 615 | | |
616 | 616 | | |
617 | | - | |
| 617 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
618 | 618 | | |
619 | 619 | | |
620 | 620 | | |
621 | | - | |
| 621 | + | |
622 | 622 | | |
623 | 623 | | |
624 | 624 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
618 | 618 | | |
619 | 619 | | |
620 | 620 | | |
621 | | - | |
| 621 | + | |
622 | 622 | | |
623 | 623 | | |
624 | 624 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20482 | 20482 | | |
20483 | 20483 | | |
20484 | 20484 | | |
20485 | | - | |
| 20485 | + | |
20486 | 20486 | | |
20487 | 20487 | | |
20488 | | - | |
| 20488 | + | |
20489 | 20489 | | |
20490 | 20490 | | |
20491 | 20491 | | |
| |||
20520 | 20520 | | |
20521 | 20521 | | |
20522 | 20522 | | |
20523 | | - | |
| 20523 | + | |
20524 | 20524 | | |
20525 | 20525 | | |
20526 | 20526 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20253 | 20253 | | |
20254 | 20254 | | |
20255 | 20255 | | |
20256 | | - | |
| 20256 | + | |
20257 | 20257 | | |
20258 | 20258 | | |
20259 | | - | |
| 20259 | + | |
20260 | 20260 | | |
20261 | 20261 | | |
20262 | 20262 | | |
| |||
20291 | 20291 | | |
20292 | 20292 | | |
20293 | 20293 | | |
20294 | | - | |
| 20294 | + | |
20295 | 20295 | | |
20296 | 20296 | | |
20297 | 20297 | | |
| |||
0 commit comments