Skip to content

Commit 2db9995

Browse files
committed
[Flight] Allow cyclic references to be serialized when unwrapping lazy elements (facebook#35471)
When `renderModelDestructive` unwraps a lazy element and subsequently calls `renderModelDestructive` again with the resolved model, we should preserve the parent connection so that cyclic references can be serialized properly. This can occur in an advanced scenario where the result from the Flight Client is serialized again with the Flight Server, e.g. for slicing a precomputed payload into multiple parts. Note: The added test only fails when run with `--prod`. In dev mode, the component info outlining prevents the issue from occurring. DiffTrain build for [6baff7a](facebook@6baff7a)
1 parent 04cc857 commit 2db9995

34 files changed

+86
-86
lines changed

compiled/facebook-www/REVISION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
01c4d03d841b2695bf889ddeddc722b65f82031a
1+
6baff7ac763c475087ab5ebf7eef5d0b9f4436df
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
01c4d03d841b2695bf889ddeddc722b65f82031a
1+
6baff7ac763c475087ab5ebf7eef5d0b9f4436df

compiled/facebook-www/React-dev.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1497,7 +1497,7 @@ __DEV__ &&
14971497
exports.useTransition = function () {
14981498
return resolveDispatcher().useTransition();
14991499
};
1500-
exports.version = "19.3.0-www-classic-01c4d03d-20260116";
1500+
exports.version = "19.3.0-www-classic-6baff7ac-20260116";
15011501
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
15021502
"function" ===
15031503
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-dev.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1497,7 +1497,7 @@ __DEV__ &&
14971497
exports.useTransition = function () {
14981498
return resolveDispatcher().useTransition();
14991499
};
1500-
exports.version = "19.3.0-www-modern-01c4d03d-20260116";
1500+
exports.version = "19.3.0-www-modern-6baff7ac-20260116";
15011501
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
15021502
"function" ===
15031503
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-prod.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -614,4 +614,4 @@ exports.useSyncExternalStore = function (
614614
exports.useTransition = function () {
615615
return ReactSharedInternals.H.useTransition();
616616
};
617-
exports.version = "19.3.0-www-classic-01c4d03d-20260116";
617+
exports.version = "19.3.0-www-classic-6baff7ac-20260116";

compiled/facebook-www/React-prod.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -614,4 +614,4 @@ exports.useSyncExternalStore = function (
614614
exports.useTransition = function () {
615615
return ReactSharedInternals.H.useTransition();
616616
};
617-
exports.version = "19.3.0-www-modern-01c4d03d-20260116";
617+
exports.version = "19.3.0-www-modern-6baff7ac-20260116";

compiled/facebook-www/React-profiling.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -618,7 +618,7 @@ exports.useSyncExternalStore = function (
618618
exports.useTransition = function () {
619619
return ReactSharedInternals.H.useTransition();
620620
};
621-
exports.version = "19.3.0-www-classic-01c4d03d-20260116";
621+
exports.version = "19.3.0-www-classic-6baff7ac-20260116";
622622
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
623623
"function" ===
624624
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-profiling.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -618,7 +618,7 @@ exports.useSyncExternalStore = function (
618618
exports.useTransition = function () {
619619
return ReactSharedInternals.H.useTransition();
620620
};
621-
exports.version = "19.3.0-www-modern-01c4d03d-20260116";
621+
exports.version = "19.3.0-www-modern-6baff7ac-20260116";
622622
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
623623
"function" ===
624624
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/ReactART-dev.classic.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20482,10 +20482,10 @@ __DEV__ &&
2048220482
(function () {
2048320483
var internals = {
2048420484
bundleType: 1,
20485-
version: "19.3.0-www-classic-01c4d03d-20260116",
20485+
version: "19.3.0-www-classic-6baff7ac-20260116",
2048620486
rendererPackageName: "react-art",
2048720487
currentDispatcherRef: ReactSharedInternals,
20488-
reconcilerVersion: "19.3.0-www-classic-01c4d03d-20260116"
20488+
reconcilerVersion: "19.3.0-www-classic-6baff7ac-20260116"
2048920489
};
2049020490
internals.overrideHookState = overrideHookState;
2049120491
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -20520,7 +20520,7 @@ __DEV__ &&
2052020520
exports.Shape = Shape;
2052120521
exports.Surface = Surface;
2052220522
exports.Text = Text;
20523-
exports.version = "19.3.0-www-classic-01c4d03d-20260116";
20523+
exports.version = "19.3.0-www-classic-6baff7ac-20260116";
2052420524
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
2052520525
"function" ===
2052620526
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/ReactART-dev.modern.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20253,10 +20253,10 @@ __DEV__ &&
2025320253
(function () {
2025420254
var internals = {
2025520255
bundleType: 1,
20256-
version: "19.3.0-www-modern-01c4d03d-20260116",
20256+
version: "19.3.0-www-modern-6baff7ac-20260116",
2025720257
rendererPackageName: "react-art",
2025820258
currentDispatcherRef: ReactSharedInternals,
20259-
reconcilerVersion: "19.3.0-www-modern-01c4d03d-20260116"
20259+
reconcilerVersion: "19.3.0-www-modern-6baff7ac-20260116"
2026020260
};
2026120261
internals.overrideHookState = overrideHookState;
2026220262
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -20291,7 +20291,7 @@ __DEV__ &&
2029120291
exports.Shape = Shape;
2029220292
exports.Surface = Surface;
2029320293
exports.Text = Text;
20294-
exports.version = "19.3.0-www-modern-01c4d03d-20260116";
20294+
exports.version = "19.3.0-www-modern-6baff7ac-20260116";
2029520295
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
2029620296
"function" ===
2029720297
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

0 commit comments

Comments
 (0)