Skip to content

Commit 76e44c2

Browse files
authored
[compiler] Improve error messages for unhandled terminal and instruction kinds (facebook#32324)
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory. Before submitting a pull request, please make sure the following is done: 1. Fork [the repository](https://github.com/facebook/react) and create your branch from `main`. 2. Run `yarn` in the repository root. 3. If you've fixed a bug or added code that should be tested, add tests! 4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development. 5. Run `yarn test --prod` to test in the production environment. It supports the same options as `yarn test`. 6. If you need a debugger, run `yarn test --debug --watch TestName`, open `chrome://inspect`, and press "Inspect". 7. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`). 8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files. 9. Run the [Flow](https://flowtype.org/) type checks (`yarn flow`). 10. If you haven't already, complete the CLA. Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html --> ## Summary <!-- Explain the **motivation** for making this change. What existing problem does the pull request solve? --> Improve the error message, as the value is currently an object instead of a string, which results in it being converted to '[object Object]'. ## How did you test this change? Already tested locally. <!-- Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface. How exactly did you verify that your PR solves the issue you wanted to solve? If you leave this empty, your PR will very likely be closed. -->
1 parent 8759c5c commit 76e44c2

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

compiler/packages/babel-plugin-react-compiler/src/ReactiveScopes/PrintReactiveFunction.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -394,7 +394,10 @@ function writeTerminal(writer: Writer, terminal: ReactiveTerminal): void {
394394
break;
395395
}
396396
default:
397-
assertExhaustive(terminal, `Unhandled terminal ${terminal}`);
397+
assertExhaustive(
398+
terminal,
399+
`Unhandled terminal kind \`${(terminal as any).kind}\``,
400+
);
398401
}
399402
}
400403

compiler/packages/babel-plugin-react-compiler/src/TypeInference/InferTypes.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -420,7 +420,10 @@ function* generateInstructionTypes(
420420
break;
421421
}
422422
default:
423-
assertExhaustive(value, `Unhandled instruction value kind: ${value}`);
423+
assertExhaustive(
424+
value,
425+
`Unhandled instruction value kind: ${(value as any).kind}`,
426+
);
424427
}
425428
}
426429

0 commit comments

Comments
 (0)