Skip to content

Commit 89c354a

Browse files
committed
[ci] Cache playwright in run_devtools_e2e_tests (facebook#34320)
I happened to notice that I forgot to cache playwright in run_devtools_e2e_tests, so it would try to install it every time which can randomly take a while to complete (I'm not sure why it's not deterministic, but the dependencies appear to be installed inconsistently across multiple workflows). This PR adds the same cache we use for other steps that use playwright, which should shave off some time from this workflow when the cache is warm. Additionally I omitted the standalone install-deps command as it appears to be redundant and adds a lot of extra time to CI, due to the fact that it installs many unrelated dependencies. --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34320). * facebook#34321 * __->__ facebook#34320 DiffTrain build for [0a1f1fc](facebook@0a1f1fc)
1 parent a05ee5d commit 89c354a

26 files changed

+615
-1057
lines changed

compiled-rn/VERSION_NATIVE_FB

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
19.2.0-native-fb-8d7b5e49-20250827
1+
19.2.0-native-fb-0a1f1fcd-20250827

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-dev.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<2c0185bc29af53faf0204cc229b5c802>>
10+
* @generated SignedSource<<d0b6736b5e5836c0574a43883aeec412>>
1111
*/
1212

1313
"use strict";
@@ -404,5 +404,5 @@ __DEV__ &&
404404
exports.useFormStatus = function () {
405405
return resolveDispatcher().useHostTransitionStatus();
406406
};
407-
exports.version = "19.2.0-native-fb-8d7b5e49-20250827";
407+
exports.version = "19.2.0-native-fb-0a1f1fcd-20250827";
408408
})();

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-prod.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<d0661610b79f5a25001829bf91e740b7>>
10+
* @generated SignedSource<<26d6662ed76dc41db7b08592bef52131>>
1111
*/
1212

1313
"use strict";
@@ -203,4 +203,4 @@ exports.useFormState = function (action, initialState, permalink) {
203203
exports.useFormStatus = function () {
204204
return ReactSharedInternals.H.useHostTransitionStatus();
205205
};
206-
exports.version = "19.2.0-native-fb-8d7b5e49-20250827";
206+
exports.version = "19.2.0-native-fb-0a1f1fcd-20250827";

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-profiling.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<d0661610b79f5a25001829bf91e740b7>>
10+
* @generated SignedSource<<26d6662ed76dc41db7b08592bef52131>>
1111
*/
1212

1313
"use strict";
@@ -203,4 +203,4 @@ exports.useFormState = function (action, initialState, permalink) {
203203
exports.useFormStatus = function () {
204204
return ReactSharedInternals.H.useHostTransitionStatus();
205205
};
206-
exports.version = "19.2.0-native-fb-8d7b5e49-20250827";
206+
exports.version = "19.2.0-native-fb-0a1f1fcd-20250827";

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-dev.js

Lines changed: 153 additions & 228 deletions
Large diffs are not rendered by default.

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-prod.js

Lines changed: 59 additions & 121 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<690532ae42ed1cc2c8dfd1d238650f6e>>
10+
* @generated SignedSource<<aec1f2eccad4f45fc4bc81a0bd604032>>
1111
*/
1212

1313
/*
@@ -40,9 +40,7 @@ var alwaysThrottleRetries = dynamicFlagsUntyped.alwaysThrottleRetries,
4040
enablePersistedModeClonedFlag =
4141
dynamicFlagsUntyped.enablePersistedModeClonedFlag,
4242
renameElementSymbol = dynamicFlagsUntyped.renameElementSymbol,
43-
enableFragmentRefs = dynamicFlagsUntyped.enableFragmentRefs,
44-
enableFragmentRefsScrollIntoView =
45-
dynamicFlagsUntyped.enableFragmentRefsScrollIntoView;
43+
enableFragmentRefs = dynamicFlagsUntyped.enableFragmentRefs;
4644
function isValidContainer(node) {
4745
return !(
4846
!node ||
@@ -192,28 +190,6 @@ function getFragmentParentHostFiber(fiber) {
192190
}
193191
return null;
194192
}
195-
function findFragmentInstanceSiblings(result, self, child) {
196-
for (
197-
var foundSelf =
198-
3 < arguments.length && void 0 !== arguments[3] ? arguments[3] : !1;
199-
null !== child;
200-
201-
) {
202-
if (child === self)
203-
if (((foundSelf = !0), child.sibling)) child = child.sibling;
204-
else return !0;
205-
if (5 === child.tag) {
206-
if (foundSelf) return (result[1] = child), !0;
207-
result[0] = child;
208-
} else if (
209-
(22 !== child.tag || null === child.memoizedState) &&
210-
findFragmentInstanceSiblings(result, self, child.child, foundSelf)
211-
)
212-
return !0;
213-
child = child.sibling;
214-
}
215-
return !1;
216-
}
217193
function getInstanceFromHostFiber(fiber) {
218194
switch (fiber.tag) {
219195
case 5:
@@ -13016,20 +12992,20 @@ function debounceScrollEnd(targetInst, nativeEvent, nativeEventTarget) {
1301612992
(nativeEventTarget[internalScrollTimer] = targetInst));
1301712993
}
1301812994
for (
13019-
var i$jscomp$inline_1628 = 0;
13020-
i$jscomp$inline_1628 < simpleEventPluginEvents.length;
13021-
i$jscomp$inline_1628++
12995+
var i$jscomp$inline_1627 = 0;
12996+
i$jscomp$inline_1627 < simpleEventPluginEvents.length;
12997+
i$jscomp$inline_1627++
1302212998
) {
13023-
var eventName$jscomp$inline_1629 =
13024-
simpleEventPluginEvents[i$jscomp$inline_1628],
13025-
domEventName$jscomp$inline_1630 =
13026-
eventName$jscomp$inline_1629.toLowerCase(),
13027-
capitalizedEvent$jscomp$inline_1631 =
13028-
eventName$jscomp$inline_1629[0].toUpperCase() +
13029-
eventName$jscomp$inline_1629.slice(1);
12999+
var eventName$jscomp$inline_1628 =
13000+
simpleEventPluginEvents[i$jscomp$inline_1627],
13001+
domEventName$jscomp$inline_1629 =
13002+
eventName$jscomp$inline_1628.toLowerCase(),
13003+
capitalizedEvent$jscomp$inline_1630 =
13004+
eventName$jscomp$inline_1628[0].toUpperCase() +
13005+
eventName$jscomp$inline_1628.slice(1);
1303013006
registerSimpleEvent(
13031-
domEventName$jscomp$inline_1630,
13032-
"on" + capitalizedEvent$jscomp$inline_1631
13007+
domEventName$jscomp$inline_1629,
13008+
"on" + capitalizedEvent$jscomp$inline_1630
1303313009
);
1303413010
}
1303513011
registerSimpleEvent(ANIMATION_END, "onAnimationEnd");
@@ -15030,36 +15006,6 @@ function removeEventListenerFromChild(
1503015006
);
1503115007
return !1;
1503215008
}
15033-
function normalizeListenerOptions(opts) {
15034-
return null == opts
15035-
? "0"
15036-
: "boolean" === typeof opts
15037-
? "c=" + (opts ? "1" : "0")
15038-
: "c=" +
15039-
(opts.capture ? "1" : "0") +
15040-
"&o=" +
15041-
(opts.once ? "1" : "0") +
15042-
"&p=" +
15043-
(opts.passive ? "1" : "0");
15044-
}
15045-
function indexOfEventListener(
15046-
eventListeners,
15047-
type,
15048-
listener,
15049-
optionsOrUseCapture
15050-
) {
15051-
for (var i = 0; i < eventListeners.length; i++) {
15052-
var item = eventListeners[i];
15053-
if (
15054-
item.type === type &&
15055-
item.listener === listener &&
15056-
normalizeListenerOptions(item.optionsOrUseCapture) ===
15057-
normalizeListenerOptions(optionsOrUseCapture)
15058-
)
15059-
return i;
15060-
}
15061-
return -1;
15062-
}
1506315009
FragmentInstance.prototype.dispatchEvent = function (event) {
1506415010
var parentHostFiber = getFragmentParentHostFiber(this._fragmentFiber);
1506515011
if (null === parentHostFiber) return !0;
@@ -15390,44 +15336,36 @@ function validateDocumentPositionWithFiberTree(
1539015336
fragmentFiber)
1539115337
: !1;
1539215338
}
15393-
enableFragmentRefsScrollIntoView &&
15394-
(FragmentInstance.prototype.experimental_scrollIntoView = function (
15395-
alignToTop
15396-
) {
15397-
if ("object" === typeof alignToTop)
15398-
throw Error(formatProdErrorMessage(566));
15399-
var children = [];
15400-
traverseVisibleHostChildren(
15401-
this._fragmentFiber.child,
15402-
!1,
15403-
collectChildren,
15404-
children,
15405-
void 0,
15406-
void 0
15407-
);
15408-
var resolvedAlignToTop = !1 !== alignToTop;
15409-
if (0 === children.length) {
15410-
children = this._fragmentFiber;
15411-
var result = [null, null],
15412-
parentHostFiber = getFragmentParentHostFiber(children);
15413-
null !== parentHostFiber &&
15414-
findFragmentInstanceSiblings(result, children, parentHostFiber.child);
15415-
resolvedAlignToTop = resolvedAlignToTop
15416-
? result[1] ||
15417-
result[0] ||
15418-
getFragmentParentHostFiber(this._fragmentFiber)
15419-
: result[0] || result[1];
15420-
null !== resolvedAlignToTop &&
15421-
getInstanceFromHostFiber(resolvedAlignToTop).scrollIntoView(alignToTop);
15422-
} else
15423-
for (
15424-
result = resolvedAlignToTop ? children.length - 1 : 0;
15425-
result !== (resolvedAlignToTop ? -1 : children.length);
15426-
15427-
)
15428-
getInstanceFromHostFiber(children[result]).scrollIntoView(alignToTop),
15429-
(result += resolvedAlignToTop ? -1 : 1);
15430-
});
15339+
function normalizeListenerOptions(opts) {
15340+
return null == opts
15341+
? "0"
15342+
: "boolean" === typeof opts
15343+
? "c=" + (opts ? "1" : "0")
15344+
: "c=" +
15345+
(opts.capture ? "1" : "0") +
15346+
"&o=" +
15347+
(opts.once ? "1" : "0") +
15348+
"&p=" +
15349+
(opts.passive ? "1" : "0");
15350+
}
15351+
function indexOfEventListener(
15352+
eventListeners,
15353+
type,
15354+
listener,
15355+
optionsOrUseCapture
15356+
) {
15357+
for (var i = 0; i < eventListeners.length; i++) {
15358+
var item = eventListeners[i];
15359+
if (
15360+
item.type === type &&
15361+
item.listener === listener &&
15362+
normalizeListenerOptions(item.optionsOrUseCapture) ===
15363+
normalizeListenerOptions(optionsOrUseCapture)
15364+
)
15365+
return i;
15366+
}
15367+
return -1;
15368+
}
1543115369
function commitNewChildToFragmentInstance(childInstance, fragmentInstance) {
1543215370
var eventListeners = fragmentInstance._eventListeners;
1543315371
if (null !== eventListeners)
@@ -17256,16 +17194,16 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1725617194
0 === i && attemptExplicitHydrationTarget(target);
1725717195
}
1725817196
};
17259-
var isomorphicReactPackageVersion$jscomp$inline_2034 = React.version;
17197+
var isomorphicReactPackageVersion$jscomp$inline_2023 = React.version;
1726017198
if (
17261-
"19.2.0-native-fb-8d7b5e49-20250827" !==
17262-
isomorphicReactPackageVersion$jscomp$inline_2034
17199+
"19.2.0-native-fb-0a1f1fcd-20250827" !==
17200+
isomorphicReactPackageVersion$jscomp$inline_2023
1726317201
)
1726417202
throw Error(
1726517203
formatProdErrorMessage(
1726617204
527,
17267-
isomorphicReactPackageVersion$jscomp$inline_2034,
17268-
"19.2.0-native-fb-8d7b5e49-20250827"
17205+
isomorphicReactPackageVersion$jscomp$inline_2023,
17206+
"19.2.0-native-fb-0a1f1fcd-20250827"
1726917207
)
1727017208
);
1727117209
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -17285,24 +17223,24 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1728517223
null === componentOrElement ? null : componentOrElement.stateNode;
1728617224
return componentOrElement;
1728717225
};
17288-
var internals$jscomp$inline_2565 = {
17226+
var internals$jscomp$inline_2554 = {
1728917227
bundleType: 0,
17290-
version: "19.2.0-native-fb-8d7b5e49-20250827",
17228+
version: "19.2.0-native-fb-0a1f1fcd-20250827",
1729117229
rendererPackageName: "react-dom",
1729217230
currentDispatcherRef: ReactSharedInternals,
17293-
reconcilerVersion: "19.2.0-native-fb-8d7b5e49-20250827"
17231+
reconcilerVersion: "19.2.0-native-fb-0a1f1fcd-20250827"
1729417232
};
1729517233
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
17296-
var hook$jscomp$inline_2566 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
17234+
var hook$jscomp$inline_2555 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
1729717235
if (
17298-
!hook$jscomp$inline_2566.isDisabled &&
17299-
hook$jscomp$inline_2566.supportsFiber
17236+
!hook$jscomp$inline_2555.isDisabled &&
17237+
hook$jscomp$inline_2555.supportsFiber
1730017238
)
1730117239
try {
17302-
(rendererID = hook$jscomp$inline_2566.inject(
17303-
internals$jscomp$inline_2565
17240+
(rendererID = hook$jscomp$inline_2555.inject(
17241+
internals$jscomp$inline_2554
1730417242
)),
17305-
(injectedHook = hook$jscomp$inline_2566);
17243+
(injectedHook = hook$jscomp$inline_2555);
1730617244
} catch (err) {}
1730717245
}
1730817246
exports.createRoot = function (container, options) {
@@ -17388,4 +17326,4 @@ exports.hydrateRoot = function (container, initialChildren, options) {
1738817326
listenToAllSupportedEvents(container);
1738917327
return new ReactDOMHydrationRoot(initialChildren);
1739017328
};
17391-
exports.version = "19.2.0-native-fb-8d7b5e49-20250827";
17329+
exports.version = "19.2.0-native-fb-0a1f1fcd-20250827";

0 commit comments

Comments
 (0)