Skip to content

Commit 8a7b487

Browse files
authored
[flags] enable owner stacks everywhere (facebook#32376)
this is now canary and on everywhere
1 parent 4632e36 commit 8a7b487

9 files changed

+17
-14
lines changed

packages/shared/forks/ReactFeatureFlags.native-fb-dynamic.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,5 @@ export const enableShallowPropDiffing = __VARIANT__;
2525
export const passChildrenWhenCloningPersistedNodes = __VARIANT__;
2626
export const enableSiblingPrerendering = __VARIANT__;
2727
export const enableUseEffectCRUDOverload = __VARIANT__;
28-
export const enableOwnerStacks = __VARIANT__;
29-
export const enableRemoveConsolePatches = __VARIANT__;
3028
export const enableFastAddPropertiesInDiffing = __VARIANT__;
3129
export const enableLazyPublicInstanceInFabric = __VARIANT__;

packages/shared/forks/ReactFeatureFlags.native-fb.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,12 +27,14 @@ export const {
2727
enableUseEffectCRUDOverload,
2828
passChildrenWhenCloningPersistedNodes,
2929
enableSiblingPrerendering,
30-
enableOwnerStacks,
31-
enableRemoveConsolePatches,
3230
enableFastAddPropertiesInDiffing,
3331
enableLazyPublicInstanceInFabric,
3432
} = dynamicFlags;
3533

34+
// These two can be removed
35+
export const enableOwnerStacks = true;
36+
export const enableRemoveConsolePatches = true;
37+
3638
// The rest of the flags are static for better dead code elimination.
3739
export const disableClientCache = true;
3840
export const disableCommentsAsDOMContainers = true;

packages/shared/forks/ReactFeatureFlags.native-oss.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ export const enableLegacyFBSupport = false;
4040
export const enableLegacyHidden = false;
4141
export const enableNoCloningMemoCache = false;
4242
export const enableObjectFiber = false;
43-
export const enableOwnerStacks = false;
43+
export const enableOwnerStacks = true;
4444
export const enablePersistedModeClonedFlag = false;
4545
export const enablePostpone = false;
4646
export const enableReactTestRendererWarning = false;
@@ -80,7 +80,7 @@ export const enableProfilerTimer = __PROFILE__;
8080
export const enableProfilerCommitHooks = __PROFILE__;
8181
export const enableProfilerNestedUpdatePhase = __PROFILE__;
8282
export const enableUpdaterTracking = __PROFILE__;
83-
export const enableRemoveConsolePatches = false;
83+
export const enableRemoveConsolePatches = true;
8484

8585
// Flow magic to verify the exports of this file match the original version.
8686
((((null: any): ExportsType): FeatureFlagsType): ExportsType);

packages/shared/forks/ReactFeatureFlags.test-renderer.native-fb.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ export const enableLegacyFBSupport = false;
3535
export const enableLegacyHidden = false;
3636
export const enableNoCloningMemoCache = false;
3737
export const enableObjectFiber = false;
38-
export const enableOwnerStacks = false;
38+
export const enableOwnerStacks = true;
3939
export const enablePersistedModeClonedFlag = false;
4040
export const enablePostpone = false;
4141
export const enableProfilerCommitHooks = __PROFILE__;
@@ -67,8 +67,8 @@ export const enableHydrationLaneScheduling = true;
6767
export const enableYieldingBeforePassive = false;
6868
export const enableThrottledScheduling = false;
6969
export const enableViewTransition = false;
70+
export const enableRemoveConsolePatches = true;
7071
export const enableSwipeTransition = false;
71-
export const enableRemoveConsolePatches = false;
7272
export const enableFastAddPropertiesInDiffing = false;
7373
export const enableLazyPublicInstanceInFabric = false;
7474

packages/shared/forks/ReactFeatureFlags.test-renderer.www.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ export const disableDefaultPropsExceptForClasses = true;
7070
export const renameElementSymbol = false;
7171

7272
export const enableObjectFiber = false;
73-
export const enableOwnerStacks = false;
73+
export const enableOwnerStacks = true;
7474
export const enableShallowPropDiffing = false;
7575
export const enableSiblingPrerendering = true;
7676

@@ -82,8 +82,8 @@ export const enableYieldingBeforePassive = false;
8282

8383
export const enableThrottledScheduling = false;
8484
export const enableViewTransition = false;
85+
export const enableRemoveConsolePatches = true;
8586
export const enableSwipeTransition = false;
86-
export const enableRemoveConsolePatches = false;
8787
export const enableFastAddPropertiesInDiffing = false;
8888
export const enableLazyPublicInstanceInFabric = false;
8989

packages/shared/forks/ReactFeatureFlags.www-dynamic.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ export const enableRetryLaneExpiration = __VARIANT__;
2626
export const enableTransitionTracing = __VARIANT__;
2727
export const favorSafetyOverHydrationPerf = __VARIANT__;
2828
export const renameElementSymbol = __VARIANT__;
29-
export const enableOwnerStacks = __VARIANT__;
3029
export const retryLaneExpirationMs = 5000;
3130
export const syncLaneExpirationMs = 250;
3231
export const transitionLaneExpirationMs = 5000;
@@ -37,7 +36,6 @@ export const enableInfiniteRenderLoopDetection = __VARIANT__;
3736
export const enableSiblingPrerendering = __VARIANT__;
3837

3938
export const enableUseEffectCRUDOverload = __VARIANT__;
40-
export const enableRemoveConsolePatches = __VARIANT__;
4139
export const enableFastAddPropertiesInDiffing = __VARIANT__;
4240
export const enableLazyPublicInstanceInFabric = false;
4341
export const enableViewTransition = __VARIANT__;

packages/shared/forks/ReactFeatureFlags.www.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,15 +35,17 @@ export const {
3535
retryLaneExpirationMs,
3636
syncLaneExpirationMs,
3737
transitionLaneExpirationMs,
38-
enableOwnerStacks,
39-
enableRemoveConsolePatches,
4038
enableFastAddPropertiesInDiffing,
4139
enableViewTransition,
4240
} = dynamicFeatureFlags;
4341

4442
// On WWW, __EXPERIMENTAL__ is used for a new modern build.
4543
// It's not used anywhere in production yet.
4644

45+
// Can remove these two
46+
export const enableOwnerStacks = true;
47+
export const enableRemoveConsolePatches = true;
48+
4749
export const enableProfilerTimer = __PROFILE__;
4850
export const enableProfilerCommitHooks = __PROFILE__;
4951
export const enableProfilerNestedUpdatePhase = __PROFILE__;

scripts/jest/setupTests.www.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ jest.mock('shared/ReactFeatureFlags', () => {
1111
// Flags that aren't currently used, but we still want to force variants to keep the
1212
// code live.
1313
actual.disableInputAttributeSyncing = __VARIANT__;
14+
actual.enableOwnerStacks = __VARIANT__;
1415

1516
// These are hardcoded to true for the next release,
1617
// but still run the tests against both variants until

scripts/jest/setupTests.xplat.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@ jest.mock('shared/ReactFeatureFlags', () => {
1111
'shared/forks/ReactFeatureFlags.native-fb.js'
1212
);
1313

14+
actual.enableOwnerStacks = __VARIANT__;
15+
1416
// Lots of tests use these, but we don't want to expose it to RN.
1517
// Ideally, tests for xplat wouldn't use react-dom, but many of our tests do.
1618
// Since the xplat tests run with the www entry points, some of these flags

0 commit comments

Comments
 (0)