Skip to content

Commit 90817f8

Browse files
authored
[rn] delete the legacy renderers from the sync (facebook#34946)
Now that RN is only on the New Architecture, we can stop stop syncing the legacy React Native renderers. In this diff, I just stop syncing them. In a follow up I'll delete the code for them so only Fabric is left. This will also allow us to remove the `enableLegacyMode` feature flag.
1 parent 0d721b6 commit 90817f8

File tree

5 files changed

+8
-39
lines changed

5 files changed

+8
-39
lines changed

.github/workflows/runtime_commit_artifacts.yml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -162,10 +162,13 @@ jobs:
162162
mv build/facebook-react-native/react-is/cjs/ $BASE_FOLDER/RKJSModules/vendor/react/react-is/
163163
mv build/facebook-react-native/react-test-renderer/cjs/ $BASE_FOLDER/RKJSModules/vendor/react/react-test-renderer/
164164
165-
# Delete OSS renderer. OSS renderer is synced through internal script.
165+
# Delete the OSS renderers, these are sync'd to RN separately.
166166
RENDERER_FOLDER=$BASE_FOLDER/react-native-github/Libraries/Renderer/implementations/
167+
SHIM_FOLDER=$BASE_FOLDER/react-native-github/Libraries/Renderer/shims/
167168
rm $RENDERER_FOLDER/ReactFabric-{dev,prod,profiling}.js
168-
rm $RENDERER_FOLDER/ReactNativeRenderer-{dev,prod,profiling}.js
169+
170+
# Delete the legacy renderer shim, this is not sync'd and will get deleted in the future.
171+
rm $SHIM_FOLDER/ReactNative.js
169172
170173
# Copy eslint-plugin-react-hooks
171174
# NOTE: This is different from www, here we include the full package

packages/react-native-renderer/index.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,5 @@ import * as ReactNative from './src/ReactNativeRenderer';
1212
// Assert that the exports line up with the type we're going to expose.
1313
(ReactNative: ReactNativeType);
1414

15+
// TODO: Delete the legacy renderer, only Fabric is used now.
1516
export * from './src/ReactNativeRenderer';

packages/react-reconciler/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ The examples in the React repository are declared a bit differently than a third
5959

6060
* [React ART](https://github.com/facebook/react/blob/main/packages/react-art/src/ReactART.js) and its [host config](https://github.com/facebook/react/blob/main/packages/react-art/src/ReactFiberConfigART.js)
6161
* [React DOM](https://github.com/facebook/react/blob/main/packages/react-dom/src/client/ReactDOM.js) and its [host config](https://github.com/facebook/react/blob/main/packages/react-dom-bindings/src/client/ReactFiberConfigDOM.js)
62-
* [React Native](https://github.com/facebook/react/blob/main/packages/react-native-renderer/src/ReactNativeRenderer.js) and its [host config](https://github.com/facebook/react/blob/main/packages/react-native-renderer/src/ReactFiberConfigNative.js)
62+
* [React Native](https://github.com/facebook/react/blob/main/packages/react-native-renderer/src/ReactFabric.js) and its [host config](https://github.com/facebook/react/blob/main/packages/react-native-renderer/src/ReactFiberConfigFabric.js)
6363

6464
If these links break please file an issue and we’ll fix them. They intentionally link to the latest versions since the API is still evolving. If you have more questions please file an issue and we’ll try to help!
6565

scripts/rollup/bundles.js

Lines changed: 0 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -819,42 +819,6 @@ const bundles = [
819819
}),
820820
},
821821

822-
/******* React Native *******/
823-
{
824-
bundleTypes: __EXPERIMENTAL__
825-
? []
826-
: [RN_FB_DEV, RN_FB_PROD, RN_FB_PROFILING],
827-
moduleType: RENDERER,
828-
entry: 'react-native-renderer',
829-
global: 'ReactNativeRenderer',
830-
externals: ['react-native', 'ReactNativeInternalFeatureFlags'],
831-
minifyWithProdErrorCodes: false,
832-
wrapWithModuleBoundaries: true,
833-
babel: opts =>
834-
Object.assign({}, opts, {
835-
plugins: opts.plugins.concat([
836-
[require.resolve('@babel/plugin-transform-classes'), {loose: true}],
837-
]),
838-
}),
839-
},
840-
{
841-
bundleTypes: [RN_OSS_DEV, RN_OSS_PROD, RN_OSS_PROFILING],
842-
moduleType: RENDERER,
843-
entry: 'react-native-renderer',
844-
global: 'ReactNativeRenderer',
845-
// ReactNativeInternalFeatureFlags temporary until we land enableRemoveConsolePatches.
846-
// Needs to be done before the next RN OSS release.
847-
externals: ['react-native', 'ReactNativeInternalFeatureFlags'],
848-
minifyWithProdErrorCodes: false,
849-
wrapWithModuleBoundaries: true,
850-
babel: opts =>
851-
Object.assign({}, opts, {
852-
plugins: opts.plugins.concat([
853-
[require.resolve('@babel/plugin-transform-classes'), {loose: true}],
854-
]),
855-
}),
856-
},
857-
858822
/******* React Native Fabric *******/
859823
{
860824
bundleTypes: __EXPERIMENTAL__

scripts/rollup/shims/react-native/ReactNative.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import type {ReactNativeType} from './ReactNativeTypes';
1414

1515
let ReactNative: ReactNativeType;
1616

17+
// TODO: Delete the legacy renderer. Only ReactFabric is used now.
1718
if (__DEV__) {
1819
ReactNative = require('../implementations/ReactNativeRenderer-dev');
1920
} else {

0 commit comments

Comments
 (0)