Commit b742ad4
committed
[Flight] Don't drop debug info if there's only a readable debug channel (facebook#34304)
When the Flight Client is waiting for pending debug chunks, it drops the
debug info if there is no writable side of the debug channel defined.
However, it should instead check if there's no readable side defined.
Fixing this is not only important for browser clients that don't want or
need a return channel, but it's also crucial for server-side rendering,
because the Node and Edge clients only accept a readable side of the
debug channel. So they can't even define a noop writable side as a
workaround.
DiffTrain build for [9c2e2b8](facebook@9c2e2b8)1 parent f5e7a5f commit b742ad4
File tree
34 files changed
+156
-96
lines changed- compiled/facebook-www
34 files changed
+156
-96
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1409 | 1409 | | |
1410 | 1410 | | |
1411 | 1411 | | |
1412 | | - | |
| 1412 | + | |
1413 | 1413 | | |
1414 | 1414 | | |
1415 | 1415 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1409 | 1409 | | |
1410 | 1410 | | |
1411 | 1411 | | |
1412 | | - | |
| 1412 | + | |
1413 | 1413 | | |
1414 | 1414 | | |
1415 | 1415 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
600 | 600 | | |
601 | 601 | | |
602 | 602 | | |
603 | | - | |
| 603 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
600 | 600 | | |
601 | 601 | | |
602 | 602 | | |
603 | | - | |
| 603 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
604 | 604 | | |
605 | 605 | | |
606 | 606 | | |
607 | | - | |
| 607 | + | |
608 | 608 | | |
609 | 609 | | |
610 | 610 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
604 | 604 | | |
605 | 605 | | |
606 | 606 | | |
607 | | - | |
| 607 | + | |
608 | 608 | | |
609 | 609 | | |
610 | 610 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19588 | 19588 | | |
19589 | 19589 | | |
19590 | 19590 | | |
19591 | | - | |
| 19591 | + | |
19592 | 19592 | | |
19593 | 19593 | | |
19594 | | - | |
| 19594 | + | |
19595 | 19595 | | |
19596 | 19596 | | |
19597 | 19597 | | |
| |||
19625 | 19625 | | |
19626 | 19626 | | |
19627 | 19627 | | |
19628 | | - | |
| 19628 | + | |
19629 | 19629 | | |
19630 | 19630 | | |
19631 | 19631 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19359 | 19359 | | |
19360 | 19360 | | |
19361 | 19361 | | |
19362 | | - | |
| 19362 | + | |
19363 | 19363 | | |
19364 | 19364 | | |
19365 | | - | |
| 19365 | + | |
19366 | 19366 | | |
19367 | 19367 | | |
19368 | 19368 | | |
| |||
19396 | 19396 | | |
19397 | 19397 | | |
19398 | 19398 | | |
19399 | | - | |
| 19399 | + | |
19400 | 19400 | | |
19401 | 19401 | | |
19402 | 19402 | | |
| |||
0 commit comments