Skip to content

Commit d16c26d

Browse files
authored
[ci] Specify if-no-files-found on actions/upload-artifact@v4 (facebook#32679)
Defaults to warn, but since some steps require these artifacts to be uploaded we specify an error if its not found. Some other steps like playwright test-results are only uploaded on failure so it's okay to ignore. --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32679). * facebook#32680 * __->__ facebook#32679 * facebook#32678
1 parent a8c155c commit d16c26d

File tree

4 files changed

+14
-0
lines changed

4 files changed

+14
-0
lines changed

.github/workflows/compiler_playground.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,3 +50,4 @@ jobs:
5050
with:
5151
name: test-results
5252
path: compiler/apps/playground/test-results
53+
if-no-files-found: ignore

.github/workflows/devtools_regression_tests.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ jobs:
4747
with:
4848
name: build
4949
path: build
50+
if-no-files-found: error
5051

5152
build_devtools_and_process_artifacts:
5253
name: Build DevTools and process artifacts
@@ -84,17 +85,20 @@ jobs:
8485
with:
8586
name: react-devtools
8687
path: build/devtools.tgz
88+
if-no-files-found: error
8789
# Simplifies getting the extension for local testing
8890
- name: Archive chrome extension
8991
uses: actions/upload-artifact@v4
9092
with:
9193
name: react-devtools-chrome-extension
9294
path: build/devtools/chrome-extension.zip
95+
if-no-files-found: error
9396
- name: Archive firefox extension
9497
uses: actions/upload-artifact@v4
9598
with:
9699
name: react-devtools-firefox-extension
97100
path: build/devtools/firefox-extension.zip
101+
if-no-files-found: error
98102

99103
run_devtools_tests_for_versions:
100104
name: Run DevTools tests for versions
@@ -179,3 +183,4 @@ jobs:
179183
with:
180184
name: screenshots
181185
path: ./tmp/screenshots
186+
if-no-files-found: warn

.github/workflows/runtime_build_and_test.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -302,6 +302,7 @@ jobs:
302302
with:
303303
name: _build_${{ matrix.worker_id }}_${{ matrix.release_channel }}
304304
path: build
305+
if-no-files-found: error
305306

306307
test_build:
307308
name: yarn test-build
@@ -426,6 +427,7 @@ jobs:
426427
path: |
427428
./build.tgz
428429
./build2.tgz
430+
if-no-files-found: error
429431

430432
check_error_codes:
431433
name: Search build artifacts for unminified errors
@@ -603,11 +605,13 @@ jobs:
603605
with:
604606
name: flight-playwright-report
605607
path: fixtures/flight/playwright-report
608+
if-no-files-found: warn
606609
- name: Archive Flight fixture artifacts
607610
uses: actions/upload-artifact@v4
608611
with:
609612
name: flight-test-results
610613
path: fixtures/flight/test-results
614+
if-no-files-found: ignore
611615

612616
# ----- DEVTOOLS -----
613617
build_devtools_and_process_artifacts:
@@ -655,6 +659,7 @@ jobs:
655659
with:
656660
name: react-devtools-${{ matrix.browser }}-extension
657661
path: build/devtools/${{ matrix.browser }}-extension.zip
662+
if-no-files-found: error
658663

659664
merge_devtools_artifacts:
660665
name: Merge DevTools artifacts
@@ -767,3 +772,4 @@ jobs:
767772
with:
768773
name: sizebot-message
769774
path: sizebot-message.md
775+
if-no-files-found: ignore

.github/workflows/runtime_commit_artifacts.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -170,10 +170,12 @@ jobs:
170170
with:
171171
name: compiled
172172
path: compiled/
173+
if-no-files-found: error
173174
- uses: actions/upload-artifact@v4
174175
with:
175176
name: compiled-rn
176177
path: compiled-rn/
178+
if-no-files-found: error
177179

178180
commit_www_artifacts:
179181
needs: download_artifacts

0 commit comments

Comments
 (0)