Skip to content

Commit e0131f1

Browse files
authored
fix(devtools): Handle nullish values passed to formatConsoleArguments (facebook#32372)
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory. Before submitting a pull request, please make sure the following is done: 1. Fork [the repository](https://github.com/facebook/react) and create your branch from `main`. 2. Run `yarn` in the repository root. 3. If you've fixed a bug or added code that should be tested, add tests! 4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development. 5. Run `yarn test --prod` to test in the production environment. It supports the same options as `yarn test`. 6. If you need a debugger, run `yarn test --debug --watch TestName`, open `chrome://inspect`, and press "Inspect". 7. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`). 8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files. 9. Run the [Flow](https://flowtype.org/) type checks (`yarn flow`). 10. If you haven't already, complete the CLA. Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html --> ## Summary <!-- Explain the **motivation** for making this change. What existing problem does the pull request solve? --> When using React Devtools, calling `console.log('%s', null)` in userland can cause it to throw an error: ``` TypeError: Cannot read properties of null (reading 'toString') ``` ## How did you test this change? Added a unit test. <!-- Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface. How exactly did you verify that your PR solves the issue you wanted to solve? If you leave this empty, your PR will very likely be closed. --> See 47ng/nuqs#808.
1 parent 5a78dd7 commit e0131f1

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

packages/react-devtools-shared/src/__tests__/utils-test.js

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -470,5 +470,14 @@ function f() { }
470470
{},
471471
]);
472472
});
473+
474+
it('formats nullish values', () => {
475+
expect(formatConsoleArguments('This is the %s template', null)).toEqual([
476+
'This is the null template',
477+
]);
478+
expect(
479+
formatConsoleArguments('This is the %s template', undefined),
480+
).toEqual(['This is the undefined template']);
481+
});
473482
});
474483
});

packages/react-devtools-shared/src/backend/utils/formatConsoleArguments.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ export default function formatConsoleArguments(
5858
}
5959
case 's': {
6060
const [arg] = args.splice(argumentsPointer, 1);
61-
template += arg.toString();
61+
template += String(arg);
6262

6363
break;
6464
}

0 commit comments

Comments
 (0)