diff --git a/packages/react-devtools-shared/src/devtools/views/Components/InspectedElement.js b/packages/react-devtools-shared/src/devtools/views/Components/InspectedElement.js index 7b19908cc8c4a..fd068c0ad1856 100644 --- a/packages/react-devtools-shared/src/devtools/views/Components/InspectedElement.js +++ b/packages/react-devtools-shared/src/devtools/views/Components/InspectedElement.js @@ -24,7 +24,6 @@ import FetchFileWithCachingContext from './FetchFileWithCachingContext'; import {symbolicateSourceWithCache} from 'react-devtools-shared/src/symbolicateSource'; import OpenInEditorButton from './OpenInEditorButton'; import InspectedElementViewSourceButton from './InspectedElementViewSourceButton'; -import Skeleton from './Skeleton'; import useEditorURL from '../useEditorURL'; import styles from './InspectedElement.css'; @@ -203,7 +202,9 @@ export default function InspectedElementWrapper(_: Props): React.Node { } return ( -
+
{strictModeBadge} @@ -232,13 +233,11 @@ export default function InspectedElementWrapper(_: Props): React.Node { !!editorURL && source != null && symbolicatedSourcePromise != null && ( - }> - - + )} {canToggleError && ( @@ -294,9 +293,6 @@ export default function InspectedElementWrapper(_: Props): React.Node { {inspectedElement !== null && symbolicatedSourcePromise != null && (
source
- }> + + + + }>
rendered by
- - {showStack ? : null} - {showOwnersList && - owners?.map(owner => ( - - - {owner.stack != null && owner.stack.length > 0 ? ( - - ) : null} - - ))} - - {rootType !== null && ( -
{rootType}
- )} - {rendererLabel !== null && ( -
{rendererLabel}
- )} + + +
+ }> + {showStack ? : null} + {showOwnersList && + owners?.map(owner => ( + + + {owner.stack != null && owner.stack.length > 0 ? ( + + ) : null} + + ))} + + {rootType !== null && ( +
{rootType}
+ )} + {rendererLabel !== null && ( +
{rendererLabel}
+ )} +
)} diff --git a/packages/react-devtools-shared/src/devtools/views/Components/InspectedElementViewSourceButton.js b/packages/react-devtools-shared/src/devtools/views/Components/InspectedElementViewSourceButton.js index 23d4cf96c8277..ee2fbe6c4d209 100644 --- a/packages/react-devtools-shared/src/devtools/views/Components/InspectedElementViewSourceButton.js +++ b/packages/react-devtools-shared/src/devtools/views/Components/InspectedElementViewSourceButton.js @@ -11,7 +11,6 @@ import * as React from 'react'; import ButtonIcon from '../ButtonIcon'; import Button from '../Button'; -import Skeleton from './Skeleton'; import type {ReactFunctionLocation} from 'shared/ReactTypes'; @@ -27,7 +26,12 @@ function InspectedElementViewSourceButton({ symbolicatedSourcePromise, }: Props): React.Node { return ( - }> + + + + }> + + Loading source maps... + + }> + + + ); +} + export default OpenInEditorButton; diff --git a/packages/react-reconciler/src/ReactFiberCommitWork.js b/packages/react-reconciler/src/ReactFiberCommitWork.js index ba012a67d098f..b6716506a041d 100644 --- a/packages/react-reconciler/src/ReactFiberCommitWork.js +++ b/packages/react-reconciler/src/ReactFiberCommitWork.js @@ -1894,7 +1894,6 @@ function attachSuspenseRetryListeners( const retryCache = getRetryCache(finishedWork); wakeables.forEach(wakeable => { // Memoize using the boundary fiber to prevent redundant listeners. - const retry = resolveRetryWakeable.bind(null, finishedWork, wakeable); if (!retryCache.has(wakeable)) { retryCache.add(wakeable); @@ -1911,6 +1910,7 @@ function attachSuspenseRetryListeners( } } + const retry = resolveRetryWakeable.bind(null, finishedWork, wakeable); wakeable.then(retry, retry); } });