From 7b402084af3f43284eed3c7c3155762a871fc817 Mon Sep 17 00:00:00 2001 From: Ricky Date: Tue, 7 Jan 2025 09:34:18 -0500 Subject: [PATCH 1/3] Fix notify target, add lines (#32006) --- .github/workflows/discord_notify.yml | 31 ++++++++++++++-------------- 1 file changed, 15 insertions(+), 16 deletions(-) diff --git a/.github/workflows/discord_notify.yml b/.github/workflows/discord_notify.yml index 46481691b975d..ff2caa1bf957f 100644 --- a/.github/workflows/discord_notify.yml +++ b/.github/workflows/discord_notify.yml @@ -1,22 +1,21 @@ name: Discord Notify on: - pull_request: + pull_request_target: types: [ labeled ] - + jobs: notify: - if: ${{ github.event.label.name == 'React Core Team' }} - runs-on: ubuntu-latest - steps: - - name: Discord Webhook Action - uses: tsickert/discord-webhook@v6.0.0 - with: - webhook-url: ${{ secrets.DISCORD_WEBHOOK_URL }} - embed-author-name: ${{ github.event.pull_request.user.login }} - embed-author-url: ${{ github.event.pull_request.user.html_url }} - embed-author-icon-url: ${{ github.event.pull_request.user.avatar_url }} - embed-title: '#${{ github.event.number }}: ${{ github.event.pull_request.title }}' - embed-description: ${{ github.event.pull_request.body }} - embed-url: ${{ github.event.pull_request.html_url }} - \ No newline at end of file + if: ${{ github.event.label.name == 'React Core Team' }} + runs-on: ubuntu-latest + steps: + - name: Discord Webhook Action + uses: tsickert/discord-webhook@v6.0.0 + with: + webhook-url: ${{ secrets.DISCORD_WEBHOOK_URL }} + embed-author-name: ${{ github.event.pull_request.user.login }} + embed-author-url: ${{ github.event.pull_request.user.html_url }} + embed-author-icon-url: ${{ github.event.pull_request.user.avatar_url }} + embed-title: '#${{ github.event.number }} (+${{github.event.pull_request.additions}} -${{github.event.pull_request.deletions}}): ${{ github.event.pull_request.title }}' + embed-description: ${{ github.event.pull_request.body }} + embed-url: ${{ github.event.pull_request.html_url }} \ No newline at end of file From 6efbc0897f08d688c614baa205f1e1625b3a7c83 Mon Sep 17 00:00:00 2001 From: lauren Date: Tue, 7 Jan 2025 11:53:27 -0500 Subject: [PATCH 2/3] [playground] Use default compiler config (#32009) The playground's compilation mode is currently set to 'all' along with reporting all errors. This tends to be misleading since people usually expect a 1:1 match between how the playground works with what the compiler does in their codebase, eg https://github.com/reactwg/react-compiler/discussions/51. --- compiler/apps/playground/components/Editor/EditorImpl.tsx | 2 -- 1 file changed, 2 deletions(-) diff --git a/compiler/apps/playground/components/Editor/EditorImpl.tsx b/compiler/apps/playground/components/Editor/EditorImpl.tsx index 785b9fd075d12..c475a1585a9d8 100644 --- a/compiler/apps/playground/components/Editor/EditorImpl.tsx +++ b/compiler/apps/playground/components/Editor/EditorImpl.tsx @@ -78,8 +78,6 @@ function invokeCompiler( logEvent: () => {}, }, environment, - compilationMode: 'all', - panicThreshold: 'all_errors', }); const ast = parseInput(source, language); let result = transformFromAstSync(ast, source, { From f892dabd8c5cd3c112532104bab7aef46503fb30 Mon Sep 17 00:00:00 2001 From: lauren Date: Tue, 7 Jan 2025 12:09:10 -0500 Subject: [PATCH 3/3] [ci] Make gh workflow names consistent (#32010) Super minor change to keep our naming scheme consistent for gh workflows --- .../{discord_notify.yml => shared_discord_notify.yml} | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) rename .github/workflows/{discord_notify.yml => shared_discord_notify.yml} (87%) diff --git a/.github/workflows/discord_notify.yml b/.github/workflows/shared_discord_notify.yml similarity index 87% rename from .github/workflows/discord_notify.yml rename to .github/workflows/shared_discord_notify.yml index ff2caa1bf957f..86fd28af3ba74 100644 --- a/.github/workflows/discord_notify.yml +++ b/.github/workflows/shared_discord_notify.yml @@ -1,8 +1,8 @@ -name: Discord Notify +name: (Shared) Discord Notify on: pull_request_target: - types: [ labeled ] + types: [labeled] jobs: notify: @@ -18,4 +18,4 @@ jobs: embed-author-icon-url: ${{ github.event.pull_request.user.avatar_url }} embed-title: '#${{ github.event.number }} (+${{github.event.pull_request.additions}} -${{github.event.pull_request.deletions}}): ${{ github.event.pull_request.title }}' embed-description: ${{ github.event.pull_request.body }} - embed-url: ${{ github.event.pull_request.html_url }} \ No newline at end of file + embed-url: ${{ github.event.pull_request.html_url }}