Skip to content

Commit 34f764e

Browse files
authored
Fix database selector not selectable in connect modal (supabase#36723)
1 parent 307f284 commit 34f764e

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

apps/studio/components/interfaces/Connect/Connect.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,13 @@ import { PermissionAction } from '@supabase/shared-types/out/constants'
22
import { useParams } from 'common'
33
import { ExternalLink, Plug } from 'lucide-react'
44
import { parseAsBoolean, useQueryState } from 'nuqs'
5-
import { useState, useMemo } from 'react'
5+
import { useMemo, useState } from 'react'
66

77
import { DatabaseConnectionString } from 'components/interfaces/Connect/DatabaseConnectionString'
88
import { ButtonTooltip } from 'components/ui/ButtonTooltip'
99
import Panel from 'components/ui/Panel'
10-
import { getAPIKeys, useProjectSettingsV2Query } from 'data/config/project-settings-v2-query'
1110
import { useAPIKeysQuery } from 'data/api-keys/api-keys-query'
11+
import { getAPIKeys, useProjectSettingsV2Query } from 'data/config/project-settings-v2-query'
1212
import { useCheckPermissions } from 'hooks/misc/useCheckPermissions'
1313
import { useSelectedProject } from 'hooks/misc/useSelectedProject'
1414
import { PROJECT_STATUS } from 'lib/constants'

apps/studio/components/interfaces/Connect/DatabaseConnectionString.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,7 @@ export const DatabaseConnectionString = () => {
239239
</SelectContent_Shadcn_>
240240
</Select_Shadcn_>
241241
</div>
242-
<DatabaseSelector buttonProps={{ size: 'small' }} />
242+
<DatabaseSelector portal={false} buttonProps={{ size: 'small' }} />
243243
</div>
244244

245245
{isLoading && (

apps/studio/components/ui/DatabaseSelector.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ interface DatabaseSelectorProps {
3636
buttonProps?: ButtonProps
3737
onSelectId?: (id: string) => void // Optional callback
3838
onCreateReplicaClick?: () => void
39+
portal?: boolean
3940
}
4041

4142
const DatabaseSelector = ({
@@ -45,6 +46,7 @@ const DatabaseSelector = ({
4546
onSelectId = noop,
4647
buttonProps,
4748
onCreateReplicaClick = noop,
49+
portal = true,
4850
}: DatabaseSelectorProps) => {
4951
const router = useRouter()
5052
const { ref: projectRef } = useParams()
@@ -110,7 +112,7 @@ const DatabaseSelector = ({
110112
</Button>
111113
</div>
112114
</PopoverTrigger_Shadcn_>
113-
<PopoverContent_Shadcn_ className="p-0 w-64" side="bottom" align="end" portal={true}>
115+
<PopoverContent_Shadcn_ className="p-0 w-64" side="bottom" align="end" portal={portal}>
114116
<Command_Shadcn_>
115117
<CommandList_Shadcn_>
116118
{additionalOptions.length > 0 && (

0 commit comments

Comments
 (0)