Skip to content

Commit 8334418

Browse files
authored
Joshen/depr 170 analytics buckets hook up connect tables functionality (supabase#40217)
* midway * Hook up connect tables e2e * Update isEnabled flag * Change connectingStep to enum * Nit * Nit * Nit * Only show replication status if theres a publication * Improve loading state in etl page * Refactor + Clean up + Add long poll logic when adding more tables
1 parent d1ee038 commit 8334418

22 files changed

+893
-463
lines changed

apps/studio/components/interfaces/Database/ETL/Destinations.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -117,16 +117,16 @@ export const Destinations = () => {
117117
</div>
118118

119119
<div className="w-full overflow-hidden overflow-x-auto">
120-
{(isSourcesLoading || isDestinationsLoading) && <GenericSkeletonLoader />}
121-
122120
{(isSourcesError || isDestinationsError) && (
123121
<AlertError
124122
error={sourcesError || destinationsError}
125123
subject={PIPELINE_ERROR_MESSAGES.RETRIEVE_DESTINATIONS}
126124
/>
127125
)}
128126

129-
{replicationNotEnabled ? (
127+
{isSourcesLoading || isDestinationsLoading ? (
128+
<GenericSkeletonLoader />
129+
) : replicationNotEnabled ? (
130130
<div className="border rounded-md p-4 md:p-12 flex flex-col gap-y-4">
131131
<div className="flex flex-col gap-y-1">
132132
<h3>Stream data to external destinations in real-time</h3>

apps/studio/components/interfaces/Database/ETL/NewPublicationPanel.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import { toast } from 'sonner'
55
import { z } from 'zod'
66

77
import { useParams } from 'common'
8-
import { useCreatePublicationMutation } from 'data/etl/create-publication-mutation'
8+
import { useCreatePublicationMutation } from 'data/etl/publication-create-mutation'
99
import { useReplicationTablesQuery } from 'data/etl/tables-query'
1010
import {
1111
Button,
@@ -139,7 +139,7 @@ export const NewPublicationPanel = ({ visible, sourceId, onClose }: NewPublicati
139139
</MultiSelector.Trigger>
140140
<MultiSelector.Content>
141141
<MultiSelector.List>
142-
{tables?.tables.map((table) => (
142+
{tables?.map((table) => (
143143
<MultiSelector.Item
144144
key={`${table.schema}.${table.name}`}
145145
value={`${table.schema}.${table.name}`}

0 commit comments

Comments
 (0)