Skip to content

Commit cb72c30

Browse files
dnywhjoshenlim
andauthored
chore(studio): default opt-in security notifications (supabase#40423)
* default opt-in * Tiny clean up --------- Co-authored-by: Joshen Lim <[email protected]>
1 parent bf8641a commit cb72c30

File tree

1 file changed

+4
-9
lines changed

1 file changed

+4
-9
lines changed

apps/studio/components/interfaces/App/FeaturePreview/FeaturePreviewContext.tsx

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,13 @@ export const useFeaturePreviewContext = () => useContext(FeaturePreviewContext)
2828

2929
export const FeaturePreviewContextProvider = ({ children }: PropsWithChildren<{}>) => {
3030
const { hasLoaded } = useContext(FeatureFlagContext)
31+
const securityNotificationsFlag = useFlag('securityNotifications')
3132

3233
// [Joshen] Similar logic to feature flagging previews, we can use flags to default opt in previews
3334
const isDefaultOptIn = (feature: (typeof FEATURE_PREVIEWS)[number]) => {
3435
switch (feature.key) {
36+
case LOCAL_STORAGE_KEYS.UI_PREVIEW_SECURITY_NOTIFICATIONS:
37+
return securityNotificationsFlag
3538
default:
3639
return false
3740
}
@@ -116,7 +119,6 @@ export const useFeaturePreviewModal = () => {
116119
const gitlessBranchingEnabled = useFlag('gitlessBranching')
117120
const advisorRulesEnabled = useFlag('advisorRules')
118121
const isUnifiedLogsPreviewAvailable = useFlag('unifiedLogs')
119-
const isSecurityNotificationsAvailable = useFlag('securityNotifications')
120122

121123
const selectedFeatureKeyFromQuery = featurePreviewModal?.trim() ?? null
122124
const showFeaturePreviewModal = selectedFeatureKeyFromQuery !== null
@@ -131,18 +133,11 @@ export const useFeaturePreviewModal = () => {
131133
return advisorRulesEnabled
132134
case 'supabase-ui-preview-unified-logs':
133135
return isUnifiedLogsPreviewAvailable
134-
case 'security-notifications':
135-
return isSecurityNotificationsAvailable
136136
default:
137137
return true
138138
}
139139
},
140-
[
141-
gitlessBranchingEnabled,
142-
advisorRulesEnabled,
143-
isUnifiedLogsPreviewAvailable,
144-
isSecurityNotificationsAvailable,
145-
]
140+
[gitlessBranchingEnabled, advisorRulesEnabled, isUnifiedLogsPreviewAvailable]
146141
)
147142

148143
const selectedFeatureKey = (

0 commit comments

Comments
 (0)