fix: composite primary key sql generation in table editor (supabase#40942)

7ttp · web-flow · commit dbb5c1bdf575 · 2025-12-01T07:53:49.000-07:00
fixes malformed sql syntax where column quotes were incorrectly placed around comma separator closes supabase#40931
diff --git a/apps/studio/components/interfaces/TableGridEditor/SidePanelEditor/SidePanelEditor.utils.tsx b/apps/studio/components/interfaces/TableGridEditor/SidePanelEditor/SidePanelEditor.utils.tsx
@@ -61,7 +61,7 @@ const getAddPrimaryKeySQL = ({
   table: string
   columns: string[]
 }) => {
-  const primaryKeyColumns = columns.join('","')
+  const primaryKeyColumns = columns.map((col) => `"${col}"`).join(', ')
   return `ALTER TABLE "${schema}"."${table}" ADD PRIMARY KEY (${primaryKeyColumns})`
 }
 

Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,7 @@ const getAddPrimaryKeySQL = ({`
`61`	`61`	`table: string`
`62`	`62`	`columns: string[]`
`63`	`63`	`}) => {`
`64`		`- const primaryKeyColumns = columns.join('","')`
	`64`	+ const primaryKeyColumns = columns.map((col) => `"${col}"`).join(', ')
`65`	`65`	return `ALTER TABLE "${schema}"."${table}" ADD PRIMARY KEY (${primaryKeyColumns})`
`66`	`66`	`}`
`67`	`67`