Skip to content

Commit eaf35c1

Browse files
dnywhjoshenlim
andauthored
chore(studio): filter policies by bucket name (supabase#40456)
* filter buckets * Simplify * General refactors * Smol * Add missing empty state for search * Clean up 😬 --------- Co-authored-by: Joshen Lim <[email protected]>
1 parent 8b5a087 commit eaf35c1

File tree

18 files changed

+139
-83
lines changed

18 files changed

+139
-83
lines changed

apps/studio/components/interfaces/Auth/Policies/PolicyEditorModal/index.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,9 @@ import { getGeneralPolicyTemplates } from './PolicyEditorModal.constants'
2727
import PolicyEditorModalTitle from './PolicyEditorModalTitle'
2828

2929
interface PolicyEditorModalProps {
30-
visible: boolean
31-
schema: string
32-
table: string
30+
visible?: boolean
31+
schema?: string
32+
table?: string
3333
selectedPolicyToEdit: any
3434
showAssistantPreview?: boolean
3535
onSelectCancel: () => void

apps/studio/components/interfaces/Auth/Policies/PolicyEditorPanel/PolicyTemplates.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,10 @@ import { useState } from 'react'
44
import { Badge, HoverCard, HoverCardContent, HoverCardTrigger, Input, cn } from 'ui'
55

66
import { Markdown } from 'components/interfaces/Markdown'
7-
import { SimpleCodeBlock } from 'ui'
87
import CardButton from 'components/ui/CardButton'
98
import CopyButton from 'components/ui/CopyButton'
10-
import NoSearchResults from 'components/ui/NoSearchResults'
9+
import { NoSearchResults } from 'components/ui/NoSearchResults'
10+
import { SimpleCodeBlock } from 'ui'
1111
import {
1212
getGeneralPolicyTemplates,
1313
getQueuePolicyTemplates,

apps/studio/components/interfaces/Database/Extensions/Extensions.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import { useEffect, useState } from 'react'
66
import { useParams } from 'common'
77
import { DocsButton } from 'components/ui/DocsButton'
88
import InformationBox from 'components/ui/InformationBox'
9-
import NoSearchResults from 'components/ui/NoSearchResults'
9+
import { NoSearchResults } from 'components/ui/NoSearchResults'
1010
import { GenericSkeletonLoader } from 'components/ui/ShimmeringLoader'
1111
import { useDatabaseExtensionsQuery } from 'data/database-extensions/database-extensions-query'
1212
import { useAsyncCheckPermissions } from 'hooks/misc/useCheckPermissions'

apps/studio/components/interfaces/Database/Hooks/HooksList/HooksList.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import { useState } from 'react'
77
import AlertError from 'components/ui/AlertError'
88
import { ButtonTooltip } from 'components/ui/ButtonTooltip'
99
import { DocsButton } from 'components/ui/DocsButton'
10-
import NoSearchResults from 'components/ui/NoSearchResults'
10+
import { NoSearchResults } from 'components/ui/NoSearchResults'
1111
import { GenericSkeletonLoader } from 'components/ui/ShimmeringLoader'
1212
import { useDatabaseHooksQuery } from 'data/database-triggers/database-triggers-query'
1313
import { useAsyncCheckPermissions } from 'hooks/misc/useCheckPermissions'

apps/studio/components/interfaces/Database/Publications/PublicationsList.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import { toast } from 'sonner'
77
import { useParams } from 'common'
88
import AlertError from 'components/ui/AlertError'
99
import InformationBox from 'components/ui/InformationBox'
10-
import NoSearchResults from 'components/ui/NoSearchResults'
10+
import { NoSearchResults } from 'components/ui/NoSearchResults'
1111
import { useDatabasePublicationsQuery } from 'data/database-publications/database-publications-query'
1212
import { useDatabasePublicationUpdateMutation } from 'data/database-publications/database-publications-update-mutation'
1313
import { useAsyncCheckPermissions } from 'hooks/misc/useCheckPermissions'

apps/studio/components/interfaces/Database/Publications/PublicationsTables.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@ import Link from 'next/link'
44
import { useMemo, useState } from 'react'
55

66
import { useParams } from 'common'
7-
import NoSearchResults from 'components/to-be-cleaned/NoSearchResults'
87
import AlertError from 'components/ui/AlertError'
98
import { ButtonTooltip } from 'components/ui/ButtonTooltip'
9+
import { NoSearchResults } from 'components/ui/NoSearchResults'
1010
import { useDatabasePublicationsQuery } from 'data/database-publications/database-publications-query'
1111
import { useTablesQuery } from 'data/tables/tables-query'
1212
import { useAsyncCheckPermissions } from 'hooks/misc/useCheckPermissions'
@@ -94,7 +94,7 @@ export const PublicationsTables = () => {
9494

9595
{isSuccess &&
9696
(tables.length === 0 ? (
97-
<NoSearchResults />
97+
<NoSearchResults searchString={filterString} onResetFilter={() => setFilterString('')} />
9898
) : (
9999
<Card>
100100
<Table>

apps/studio/components/interfaces/Database/Roles/RolesList.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,21 +4,21 @@ import { Plus, Search, X } from 'lucide-react'
44
import { parseAsBoolean, useQueryState } from 'nuqs'
55
import { useRef, useState } from 'react'
66

7+
import type { PostgresRole } from '@supabase/postgres-meta'
78
import { ButtonTooltip } from 'components/ui/ButtonTooltip'
8-
import NoSearchResults from 'components/ui/NoSearchResults'
9+
import { NoSearchResults } from 'components/ui/NoSearchResults'
910
import SparkBar from 'components/ui/SparkBar'
1011
import { useDatabaseRolesQuery } from 'data/database-roles/database-roles-query'
1112
import { useMaxConnectionsQuery } from 'data/database/max-connections-query'
1213
import { useAsyncCheckPermissions } from 'hooks/misc/useCheckPermissions'
13-
import { useSelectedProjectQuery } from 'hooks/misc/useSelectedProject'
1414
import { handleErrorOnDelete, useQueryStateWithSelect } from 'hooks/misc/useQueryStateWithSelect'
15+
import { useSelectedProjectQuery } from 'hooks/misc/useSelectedProject'
1516
import { Badge, Button, Input, Tooltip, TooltipContent, TooltipTrigger } from 'ui'
1617
import { CreateRolePanel } from './CreateRolePanel'
1718
import { DeleteRoleModal } from './DeleteRoleModal'
1819
import { RoleRow } from './RoleRow'
1920
import { RoleRowSkeleton } from './RoleRowSkeleton'
2021
import { SUPABASE_ROLES } from './Roles.constants'
21-
import type { PostgresRole } from '@supabase/postgres-meta'
2222

2323
type SUPABASE_ROLE = (typeof SUPABASE_ROLES)[number]
2424

apps/studio/components/interfaces/Database/Tables/ColumnList.tsx

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,10 @@ import { useState } from 'react'
66

77
import { PostgresColumn } from '@supabase/postgres-meta'
88
import { useParams } from 'common'
9-
import NoSearchResults from 'components/to-be-cleaned/NoSearchResults'
109
import Table from 'components/to-be-cleaned/Table'
1110
import AlertError from 'components/ui/AlertError'
1211
import { ButtonTooltip } from 'components/ui/ButtonTooltip'
12+
import { NoSearchResults } from 'components/ui/NoSearchResults'
1313
import { GenericSkeletonLoader } from 'components/ui/ShimmeringLoader'
1414
import { useTableEditorQuery } from 'data/table-editor/table-editor-query'
1515
import { isTableLike } from 'data/table-editor/table-editor-types'
@@ -120,7 +120,10 @@ export const ColumnList = ({
120120
{isSuccess && (
121121
<>
122122
{columns.length === 0 ? (
123-
<NoSearchResults />
123+
<NoSearchResults
124+
searchString={filterString}
125+
onResetFilter={() => setFilterString('')}
126+
/>
124127
) : (
125128
<div>
126129
<Table

apps/studio/components/interfaces/Home/ProjectList/ProjectList.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { UIEvent, useMemo } from 'react'
33
import { useDebounce } from '@uidotdev/usehooks'
44
import { LOCAL_STORAGE_KEYS, useParams } from 'common'
55
import AlertError from 'components/ui/AlertError'
6-
import NoSearchResults from 'components/ui/NoSearchResults'
6+
import { NoSearchResults } from 'components/ui/NoSearchResults'
77
import { useGitHubConnectionsQuery } from 'data/integrations/github-connections-query'
88
import { useOrgIntegrationsQuery } from 'data/integrations/integrations-query-org-only'
99
import { usePermissionsQuery } from 'data/permissions/permissions-query'

apps/studio/components/interfaces/Integrations/Landing/AvailableIntegrations.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { Search } from 'lucide-react'
22
import { parseAsString, useQueryState } from 'nuqs'
33

44
import AlertError from 'components/ui/AlertError'
5-
import NoSearchResults from 'components/ui/NoSearchResults'
5+
import { NoSearchResults } from 'components/ui/NoSearchResults'
66
import { useIsFeatureEnabled } from 'hooks/misc/useIsFeatureEnabled'
77
import { buttonVariants, cn, Tabs_Shadcn_, TabsList_Shadcn_, TabsTrigger_Shadcn_ } from 'ui'
88
import { Admonition } from 'ui-patterns/admonition'

0 commit comments

Comments
 (0)