From f5791c36eebb361cdbded5ca5ee7e103f776c9fb Mon Sep 17 00:00:00 2001
From: Ali Waseem <waseema393@gmail.com>
Date: Sun, 30 Nov 2025 05:51:58 -0700
Subject: [PATCH] fix: copy first row due to failed falsey check (#40909)

* updated because of zero falsey value not copying

* test: add E2E test for copying first and second row values

Adds regression test to verify that users can copy cell values from
the first row (index 0) and second row. This prevents the bug where
falsy index checks would prevent copying from row 0.

Addresses FE-2178
---
 .../grid/components/menu/RowContextMenu.tsx   |  8 +--
 e2e/studio/features/table-editor.spec.ts      | 62 +++++++++++++++++++
 2 files changed, 66 insertions(+), 4 deletions(-)

diff --git a/apps/studio/components/grid/components/menu/RowContextMenu.tsx b/apps/studio/components/grid/components/menu/RowContextMenu.tsx
index cb6920996bb83..97b17a89771a7 100644
--- a/apps/studio/components/grid/components/menu/RowContextMenu.tsx
+++ b/apps/studio/components/grid/components/menu/RowContextMenu.tsx
@@ -22,7 +22,7 @@ export const RowContextMenu = ({ rows }: RowContextMenuProps) => {
 
   function onDeleteRow(p: RowContextMenuItemProps) {
     const rowIdx = p.props?.rowIdx
-    if (!rowIdx) return
+    if (rowIdx === undefined || rowIdx === null) return
 
     const row = rows[rowIdx]
     if (row) tableEditorSnap.onDeleteRows([row])
@@ -30,7 +30,7 @@ export const RowContextMenu = ({ rows }: RowContextMenuProps) => {
 
   function onEditRowClick(p: RowContextMenuItemProps) {
     const rowIdx = p.props?.rowIdx
-    if (!rowIdx) return
+    if (rowIdx === undefined || rowIdx === null) return
 
     const row = rows[rowIdx]
     tableEditorSnap.onEditRow(row)
@@ -39,7 +39,7 @@ export const RowContextMenu = ({ rows }: RowContextMenuProps) => {
   const onCopyCellContent = useCallback(
     (p: RowContextMenuItemProps) => {
       const rowIdx = p.props?.rowIdx
-      if (!snap.selectedCellPosition || !rowIdx) return
+      if (!snap.selectedCellPosition || rowIdx === undefined || rowIdx === null) return
 
       const row = rows[rowIdx]
       const columnKey = snap.gridColumns[snap.selectedCellPosition.idx as number].key
@@ -56,7 +56,7 @@ export const RowContextMenu = ({ rows }: RowContextMenuProps) => {
   const onCopyRowContent = useCallback(
     (p: RowContextMenuItemProps) => {
       const rowIdx = p.props?.rowIdx
-      if (!rowIdx) return
+      if (rowIdx === undefined || rowIdx === null) return
 
       const row = rows[rowIdx]
       copyToClipboard(JSON.stringify(row))
diff --git a/e2e/studio/features/table-editor.spec.ts b/e2e/studio/features/table-editor.spec.ts
index 20151da746ba0..b70beef93ca20 100644
--- a/e2e/studio/features/table-editor.spec.ts
+++ b/e2e/studio/features/table-editor.spec.ts
@@ -717,4 +717,66 @@ test.describe('table editor', () => {
 
     await deleteTable(page, ref, tableNameDataActions)
   })
+
+  test('copying cell values from first and second row works', async ({ page, ref }) => {
+    const tableName = 'pw_table_copy_rows'
+    const colName = 'pw_column'
+
+    // Ensure we're on editor
+    if (!page.url().includes('/editor')) {
+      await page.goto(toUrl(`/project/${ref}/editor?schema=public`))
+      await waitForTableToLoad(page, ref)
+    }
+
+    // Create table and add two rows
+    await createTable(page, ref, tableName)
+    await page.getByRole('button', { name: `View ${tableName}`, exact: true }).click()
+    await page.waitForURL(/\/editor\/\d+\?schema=public$/)
+
+    // Insert first row with value 'first_row_value'
+    await page.getByTestId('table-editor-insert-new-row').click()
+    await page.getByRole('menuitem', { name: 'Insert row Insert a new row' }).click()
+    await page.getByTestId(`${colName}-input`).fill('first_row_value')
+    await page.getByTestId('action-bar-save-row').click()
+    await waitForApiResponse(page, 'pg-meta', ref, 'query?key=', { method: 'POST' })
+
+    // Insert second row with value 'second_row_value'
+    await page.getByTestId('table-editor-insert-new-row').click()
+    await page.getByRole('menuitem', { name: 'Insert row Insert a new row' }).click()
+    await page.getByTestId(`${colName}-input`).fill('second_row_value')
+    await page.getByTestId('action-bar-save-row').click()
+    await waitForApiResponse(page, 'pg-meta', ref, 'query?key=', { method: 'POST' })
+
+    // Wait for grid to be visible
+    await expect(page.getByRole('grid')).toBeVisible()
+
+    // Right-click on the first row's cell to open context menu
+    const firstRowCell = page.getByRole('gridcell', { name: 'first_row_value' })
+    await expect(firstRowCell).toBeVisible()
+    await firstRowCell.click({ button: 'right' })
+
+    // Click "Copy cell" from context menu
+    await page.getByRole('menuitem', { name: 'Copy cell' }).click()
+    await page.waitForTimeout(500)
+
+    // Verify first row value was copied
+    const firstCopiedValue = await page.evaluate(() => navigator.clipboard.readText())
+    expect(firstCopiedValue).toBe('first_row_value')
+
+    // Right-click on the second row's cell to open context menu
+    const secondRowCell = page.getByRole('gridcell', { name: 'second_row_value' })
+    await expect(secondRowCell).toBeVisible()
+    await secondRowCell.click({ button: 'right' })
+
+    // Click "Copy cell" from context menu
+    await page.getByRole('menuitem', { name: 'Copy cell' }).click()
+    await page.waitForTimeout(500)
+
+    // Verify second row value was copied
+    const secondCopiedValue = await page.evaluate(() => navigator.clipboard.readText())
+    expect(secondCopiedValue).toBe('second_row_value')
+
+    // Cleanup
+    await deleteTable(page, ref, tableName)
+  })
 })