some modifications to get tests passing

Author: edsu

Changes

@@ -1,11 +1,5 @@
-```
-            _                             _ 
- _ __ _   _| |__  _   _        ___   __ _(_)
-| '__| | | | '_ \| | | |_____ / _ \ / _` | |
-| |  | |_| | |_) | |_| |_____| (_) | (_| | |
-|_|   \__,_|_.__/ \__, |      \___/ \__,_|_|
-                  |___/                     
-```
+ruby-oai
+========
 
 ruby-oai is a Open Archives Protocol for Metadata Harvesting (OAI-PMH)
 library for Ruby. OAI-PMH[http://openarchives.org] it is a somewhat 

README.md

@@ -21,7 +21,6 @@ spec = Gem::Specification.new do |s|
     s.summary = 'A ruby library for working with the Open Archive Initiative Protocol for Metadata Harvesting (OAI-PMH)'
     s.require_path = 'lib'
     s.autorequire = 'oai'
-    s.has_rdoc = true
     s.bindir = 'bin'
     s.executables = 'oai'
 

Rakefile

@@ -58,9 +58,8 @@ def value_for(field, record, map)
 
       if record.respond_to?(pluralize(method))
         record.send pluralize(method)
-      elsif record.respond_to?(method)
-        # at this point, this function will throw a dep. error because of the call to type -- a reserved work
-        # in ruby
+      elsif method != 'type' and record.respond_to?(method)
+        # TODO: this calls type, which is deprecated, should be 
         record.send method
       else
         []

lib/oai/provider/metadata_format.rb

@@ -61,7 +61,8 @@ def valid?
 
       return true if self.class.valid_options.nil? and options.empty?
 
-      # Added by [email protected]. Needed if the request includes an argument and there are no valid arguments for that verb (Identify, for example).
+      # check if the request includes an argument and there are no valid 
+      # arguments for that verb (Identify, for example).
       raise OAI::ArgumentException.new if self.class.valid_options.nil? && !options.empty?
 
       if self.class.required_options

lib/oai/provider/response.rb

@@ -32,8 +32,6 @@ def self.parse(token_string)
         end
         self.new(options)
       rescue => err
-        # [email protected] 
-        # This was not caught by the tests.
         raise OAI::ResumptionTokenException.new
       end
     end

lib/oai/provider/resumption_token.rb

@@ -4,7 +4,7 @@ class ExceptionTest < Test::Unit::TestCase
 
   def test_not_found
     client = OAI::Client.new 'http://www.google.com'
-    assert_raises(ArgumentError) { client.identify }
+    assert_raises(OAI::Exception) { client.identify }
   end
 
   def test_xml_error

test/client/tc_exception.rb

@@ -3,7 +3,7 @@
 class LowResolutionDatesTest < Test::Unit::TestCase
 
   def test_low_res_date_parsing
-    client = OAI::Client.new 'http://caltechcstr.library.caltech.edu/perl/oai2' 
+    client = OAI::Client.new 'http://authors.library.caltech.edu/cgi/oai2' 
 
     date = Date.new 2003, 1, 1
 

test/client/tc_low_resolution_dates.rb

@@ -112,8 +112,7 @@ def generate_chunks(records, limit)
   end
 
   def generate_records(number, timestamp = Time.now.utc.xmlschema, sets = [], deleted = false)
-    # [email protected] -- causes tests to die
-    # @earliest = timestamp.dup if @earliest.nil? || timestamp.to_s < @earliest
+    @earliest = timestamp.dup if @earliest.nil? || timestamp.to_s < @earliest
     @earliest = timestamp.dup if @earliest.nil?
 
     # Add any sets we don't already have

test/provider/models.rb

@@ -7,7 +7,6 @@ def setup
     @provider = ComplexProvider.new
   end
 
-  # [email protected]
   def test_argument_exception
     assert_raise(OAI::ArgumentException) do
       @provider.identify(:identifier => 'invalid_arg')