add phone number validation for the form (#372)

Author: tudoramariei

backend/donations/common/validation/phone_number.py

@@ -0,0 +1,31 @@
+from typing import Dict
+
+import phonenumbers
+from django.utils.translation import gettext_lazy as _
+from phonenumbers.phonenumber import PhoneNumber
+
+
+def validate_phone_number(raw_phone_number) -> Dict[str, str]:
+    try:
+        phone_number: PhoneNumber = phonenumbers.parse(raw_phone_number)
+    except phonenumbers.NumberParseException:
+        try:
+            phone_number: PhoneNumber = phonenumbers.parse(raw_phone_number, region="RO")
+        except phonenumbers.NumberParseException:
+            return {
+                "status": "error",
+                "result": _("Invalid phone number"),
+            }
+
+    if not phonenumbers.is_valid_number(phone_number):
+        return {
+            "status": "error",
+            "result": _("Invalid phone number"),
+        }
+
+    # Format the phone number in E.164 format (e.g. "+40 (72) 12-34-567" -> "+40721234567")
+    normalized_phone = phonenumbers.format_number(phone_number, phonenumbers.PhoneNumberFormat.E164)
+    return {
+        "status": "success",
+        "result": normalized_phone,
+    }

backend/donations/forms/ngo_account.py

@@ -4,6 +4,8 @@
 from localflavor.generic.forms import IBANFormField
 from localflavor.ro.forms import ROCIFField
 
+from donations.common.validation.phone_number import validate_phone_number
+
 
 class NgoPresentationForm(forms.Form):
     is_accepting_forms = forms.BooleanField(label=_("Is accepting forms"), required=False)
@@ -60,6 +62,16 @@ def clean_logo(self):
 
         return logo
 
+    def clean_contact_phone(self):
+        raw_phone_number = self.cleaned_data["contact_phone"]
+
+        phone_number_validation = validate_phone_number(raw_phone_number)
+
+        if phone_number_validation["status"] == "error":
+            raise forms.ValidationError(phone_number_validation["result"])
+
+        return phone_number_validation["result"]
+
 
 class NgoFormForm(forms.Form):
     slug = forms.SlugField(label=_("Slug"), max_length=50, required=True)

backend/donations/forms/redirection.py

@@ -5,14 +5,17 @@
 from django_recaptcha.widgets import ReCaptchaV2Invisible
 from localflavor.ro.forms import ROCNPField
 
+from donations.common.validation.phone_number import validate_phone_number
+
 
 class DonationForm(forms.Form):
     l_name = forms.CharField(max_length=100, label=_("Last name"), required=True, strip=True)
     f_name = forms.CharField(max_length=100, label=_("First name"), required=True, strip=True)
     initial = forms.CharField(max_length=1, label=_("Initial"), required=True)
     cnp = ROCNPField(label="CNP", required=True)
 
-    email_address = forms.EmailField(label=_("Email"), required=True)
+    # limit the email address to 200 characters because that is the limit in ANAF's form
+    email_address = forms.EmailField(label=_("Email"), max_length=200, required=True)
     phone_number = forms.CharField(max_length=20, label=_("Phone"), required=False, strip=True)
 
     street_name = forms.CharField(max_length=100, label=_("Street"), required=True, strip=True)
@@ -39,3 +42,13 @@ def __init__(self, *args, **kwargs):
 
     def clean_agree_contact(self):
         return not self.cleaned_data["agree_contact"]
+
+    def clean_phone_number(self):
+        raw_phone_number = self.cleaned_data["phone_number"]
+
+        phone_number_validation = validate_phone_number(raw_phone_number)
+
+        if phone_number_validation["status"] == "error":
+            raise forms.ValidationError(phone_number_validation["result"])
+
+        return phone_number_validation["result"]

backend/requirements-dev.txt

@@ -13,12 +13,12 @@ black==24.10.0
     # via -r requirements-dev.in
 blessed==1.20.0
     # via -r /Users/tudoramariei/Work/c4ro/ngohub/redirectioneaza/backend/requirements.txt
-boto3==1.36.12
+boto3==1.36.13
     # via
     #   -r /Users/tudoramariei/Work/c4ro/ngohub/redirectioneaza/backend/requirements.txt
     #   django-ses
     #   pycognito
-botocore==1.36.12
+botocore==1.36.13
     # via
     #   -r /Users/tudoramariei/Work/c4ro/ngohub/redirectioneaza/backend/requirements.txt
     #   boto3
@@ -148,6 +148,8 @@ packaging==24.2
     #   pytest
 pathspec==0.12.1
     # via black
+phonenumbers==8.13.54
+    # via -r /Users/tudoramariei/Work/c4ro/ngohub/redirectioneaza/backend/requirements.txt
 pillow==11.1.0
     # via
     #   -r /Users/tudoramariei/Work/c4ro/ngohub/redirectioneaza/backend/requirements.txt

backend/requirements.in

@@ -44,6 +44,7 @@ django-storages[s3]~=1.14.4
 
 # locale data
 django-localflavor~=4.0.0
+phonenumbers~=8.13
 
 # pdf creation
 reportlab~=4.2.5

backend/requirements.txt

@@ -10,12 +10,12 @@ asgiref==3.8.1
     #   django-allauth
 blessed==1.20.0
     # via -r requirements.in
-boto3==1.36.12
+boto3==1.36.13
     # via
     #   django-ses
     #   django-storages
     #   pycognito
-botocore==1.36.12
+botocore==1.36.13
     # via
     #   boto3
     #   s3transfer
@@ -98,6 +98,8 @@ ngohub==0.0.10
     # via -r requirements.in
 packaging==24.2
     # via gunicorn
+phonenumbers==8.13.54
+    # via -r requirements.in
 pillow==11.1.0
     # via reportlab
 psutil==6.1.1