fix: centralize cache handling with reusable cache_set helper

- add `cache_set` function in `stats_helpers.utils`
- replace direct `cache.set` calls with `cache_set` across stats helpers
- update imports to reflect the new utility module structure

Author: tudoramariei

backend/donations/views/dashboard/admin_dashboard.py

@@ -7,15 +7,15 @@
 from django.utils.timezone import now
 from django.utils.translation import gettext_lazy as _
 
-from .stats_helper_chart import donors_for_month
-from .stats_helper_metrics import (
+from donations.views.dashboard.stats_helpers.chart import donors_for_month
+from donations.views.dashboard.stats_helpers.metrics import (
     all_active_ngos,
     all_redirections,
     current_year_redirections,
     ngos_active_in_current_year,
     ngos_with_ngo_hub,
 )
-from .stats_helpers_yearly import get_stats_for_year
+from donations.views.dashboard.stats_helpers.yearly import get_stats_for_year
 
 from .helpers import (
     generate_donations_per_month_chart,

backend/donations/views/dashboard/stats_helpers/__init__.py

@@ -6,7 +6,7 @@
 from django_q.tasks import async_task
 
 from donations.models import Donor
-
+from donations.views.dashboard.stats_helpers.utils import cache_set
 
 STATS_FOR_MONTH_CACHE_PREFIX = "STATS_FOR_MONTH_"
 
@@ -52,8 +52,6 @@ def donors_for_month(month: int, year: int = None) -> Dict[str, int]:
         month,
         year,
         cache_key,
-        hook="_donors_for_month_callback",
-        task_name="donors_for_month_task",
     )
 
     return cached_stats or default_stat
@@ -85,6 +83,6 @@ def _update_stats_for_month(month: int, year: int, cache_key: str) -> Dict[str,
         "month": month,
     }
 
-    cache.set(cache_key, stat)
+    cache_set(cache_key, stat)
 
     return stat

backend/donations/views/dashboard/stats_helper_chart.py renamed to backend/donations/views/dashboard/stats_helpers/chart.py

@@ -4,6 +4,7 @@
 from django_q.tasks import async_task
 
 from donations.models import Donor, Ngo
+from donations.views.dashboard.stats_helpers.utils import cache_set
 
 
 def _cache_key_for_metric(metric_name: str) -> str:
@@ -50,7 +51,7 @@ def current_year_redirections():
         "timestamp": now(),
     }
 
-    cache.set(_cache_key_for_metric("current_year_redirections"), result)
+    cache_set(_cache_key_for_metric("current_year_redirections"), result)
 
     return result
 
@@ -62,7 +63,7 @@ def all_redirections():
         "timestamp": now(),
     }
 
-    cache.set(_cache_key_for_metric("all_redirections"), result)
+    cache_set(_cache_key_for_metric("all_redirections"), result)
 
     return result
 
@@ -74,7 +75,7 @@ def all_active_ngos():
         "timestamp": now(),
     }
 
-    cache.set(_cache_key_for_metric("all_active_ngos"), result)
+    cache_set(_cache_key_for_metric("all_active_ngos"), result)
 
     return result
 
@@ -86,7 +87,7 @@ def ngos_active_in_current_year():
         "timestamp": now(),
     }
 
-    cache.set(_cache_key_for_metric("ngos_active_in_current_year"), result)
+    cache_set(_cache_key_for_metric("ngos_active_in_current_year"), result)
 
     return result
 
@@ -98,6 +99,6 @@ def ngos_with_ngo_hub():
         "timestamp": now(),
     }
 
-    cache.set(_cache_key_for_metric("ngos_with_ngo_hub"), result)
+    cache_set(_cache_key_for_metric("ngos_with_ngo_hub"), result)
 
     return result

backend/donations/views/dashboard/stats_helper_metrics.py renamed to backend/donations/views/dashboard/stats_helpers/metrics.py

@@ -0,0 +1,9 @@
+from django.core.cache import cache
+
+
+def cache_set(key: str, value: dict) -> None:
+    """
+    Sets a value in the cache with a specified key.
+    The timeout is set to None, meaning the cache will not expire.
+    """
+    cache.set(key, value, timeout=None)

backend/donations/views/dashboard/stats_helpers/utils.py

@@ -7,7 +7,7 @@
 from django_q.tasks import async_task
 
 from donations.models import Donor, Ngo
-
+from donations.views.dashboard.stats_helpers.utils import cache_set
 
 STATS_FOR_YEAR_CACHE_PREFIX = "STATS_FOR_YEAR_"
 
@@ -92,6 +92,6 @@ def _update_stats_for_year(year: int, cache_key: str, current_time: datetime) ->
         "timestamp": current_time,
     }
 
-    cache.set(cache_key, statistic, timeout=settings.TIMEOUT_CACHE_NORMAL)
+    cache_set(cache_key, statistic, timeout=settings.TIMEOUT_CACHE_NORMAL)
 
     return statistic