downgrade to go 1.24, add auto-open debugging

Author: Thomas Stromberg

cmd/goose/browser_rate_limiter.go

@@ -37,15 +37,20 @@ func (b *BrowserRateLimiter) CanOpen(startTime time.Time, prURL string) bool {
 	b.mu.Lock()
 	defer b.mu.Unlock()
 
+	slog.Info("[BROWSER] CanOpen check",
+		"url", prURL,
+		"time_since_start", time.Since(startTime).Round(time.Second),
+		"startup_delay", b.startupDelay)
+
 	// Check if we've already opened this PR
 	if b.openedPRs[prURL] {
-		slog.Debug("[BROWSER] Skipping auto-open: PR already opened", "url", prURL)
+		slog.Info("[BROWSER] Skipping auto-open: PR already opened", "url", prURL)
 		return false
 	}
 
 	// Check startup delay
 	if time.Since(startTime) < b.startupDelay {
-		slog.Debug("[BROWSER] Skipping auto-open: within startup delay period",
+		slog.Info("[BROWSER] Skipping auto-open: within startup delay period",
 			"remaining", b.startupDelay-time.Since(startTime))
 		return false
 	}
@@ -57,18 +62,19 @@ func (b *BrowserRateLimiter) CanOpen(startTime time.Time, prURL string) bool {
 
 	// Check per-minute limit
 	if len(b.openedLastMinute) >= b.maxPerMinute {
-		slog.Debug("[BROWSER] Rate limit: per-minute limit reached",
+		slog.Info("[BROWSER] Rate limit: per-minute limit reached",
 			"opened", len(b.openedLastMinute), "max", b.maxPerMinute)
 		return false
 	}
 
 	// Check per-day limit
 	if len(b.openedToday) >= b.maxPerDay {
-		slog.Debug("[BROWSER] Rate limit: daily limit reached",
+		slog.Info("[BROWSER] Rate limit: daily limit reached",
 			"opened", len(b.openedToday), "max", b.maxPerDay)
 		return false
 	}
 
+	slog.Info("[BROWSER] CanOpen returning true", "url", prURL)
 	return true
 }
 

cmd/goose/icons.go

@@ -2,8 +2,6 @@ package main
 
 import (
 	"log/slog"
-	"os"
-	"path/filepath"
 )
 
 // Icon variables are defined in platform-specific files:
@@ -43,17 +41,6 @@ func getIcon(iconType IconType) []byte {
 	}
 }
 
-// loadIconFromFile loads an icon from the filesystem (fallback if embed fails).
-func loadIconFromFile(filename string) []byte {
-	iconPath := filepath.Join("icons", filename)
-	data, err := os.ReadFile(iconPath)
-	if err != nil {
-		slog.Warn("Failed to load icon file", "path", iconPath, "error", err)
-		return nil
-	}
-	return data
-}
-
 // setTrayIcon updates the system tray icon based on PR counts.
 func (app *App) setTrayIcon(iconType IconType) {
 	iconBytes := getIcon(iconType)

cmd/goose/main.go

@@ -832,7 +832,14 @@ func (app *App) updatePRsWithWait(ctx context.Context) {
 
 // tryAutoOpenPR attempts to open a PR in the browser if enabled and rate limits allow.
 func (app *App) tryAutoOpenPR(ctx context.Context, pr PR, autoBrowserEnabled bool, startTime time.Time) {
+	slog.Debug("[BROWSER] tryAutoOpenPR called",
+		"repo", pr.Repository,
+		"number", pr.Number,
+		"enabled", autoBrowserEnabled,
+		"time_since_start", time.Since(startTime).Round(time.Second))
+
 	if !autoBrowserEnabled {
+		slog.Debug("[BROWSER] Auto-open disabled, skipping")
 		return
 	}
 

cmd/goose/sprinkler.go

@@ -6,7 +6,6 @@ import (
 	"errors"
 	"fmt"
 	"log/slog"
-	"sort"
 	"strings"
 	"sync"
 	"time"
@@ -56,75 +55,19 @@ func newSprinklerMonitor(app *App, token string) *sprinklerMonitor {
 	}
 }
 
-// updateOrgs updates the list of organizations to monitor.
+// updateOrgs sets the list of organizations to monitor.
 func (sm *sprinklerMonitor) updateOrgs(orgs []string) {
 	sm.mu.Lock()
 	defer sm.mu.Unlock()
 
-	// Sort both lists for comparison
-	sortedNew := make([]string, len(orgs))
-	copy(sortedNew, orgs)
-	sort.Strings(sortedNew)
-
-	sortedOld := make([]string, len(sm.orgs))
-	copy(sortedOld, sm.orgs)
-	sort.Strings(sortedOld)
-
-	// Check if orgs changed after sorting
-	if len(sortedNew) == len(sortedOld) {
-		same := true
-		for i := range sortedNew {
-			if sortedNew[i] != sortedOld[i] {
-				same = false
-				break
-			}
-		}
-		if same {
-			slog.Debug("[SPRINKLER] Org list unchanged (same after sorting)",
-				"orgs", sortedNew,
-				"count", len(sortedNew))
-			return // No change
-		}
-	}
-
-	// Find what changed
-	added := []string{}
-	removed := []string{}
-	oldMap := make(map[string]bool)
-	for _, org := range sm.orgs {
-		oldMap[org] = true
-	}
-	newMap := make(map[string]bool)
-	for _, org := range orgs {
-		newMap[org] = true
-		if !oldMap[org] {
-			added = append(added, org)
-		}
-	}
-	for _, org := range sm.orgs {
-		if !newMap[org] {
-			removed = append(removed, org)
-		}
+	if len(orgs) == 0 {
+		slog.Debug("[SPRINKLER] No organizations provided")
+		return
 	}
 
-	slog.Info("[SPRINKLER] Organization list changed",
-		"previous", sm.orgs,
-		"new", orgs,
-		"added", added,
-		"removed", removed)
-
+	slog.Info("[SPRINKLER] Setting organizations", "orgs", orgs, "count", len(orgs))
 	sm.orgs = make([]string, len(orgs))
 	copy(sm.orgs, orgs)
-
-	// Restart if running
-	if sm.isRunning {
-		slog.Info("[SPRINKLER] Restarting monitor with new org list")
-		sm.stop()
-		sm.ctx, sm.cancel = context.WithCancel(context.Background())
-		if err := sm.start(); err != nil {
-			slog.Error("[SPRINKLER] Failed to restart", "error", err)
-		}
-	}
 }
 
 // start begins monitoring for PR events across all user orgs.
@@ -318,8 +261,7 @@ func (sm *sprinklerMonitor) handleEvent(event client.Event) {
 func (sm *sprinklerMonitor) processEvents() {
 	defer func() {
 		if r := recover(); r != nil {
-			slog.Error("[SPRINKLER] Event processor panic",
-				"panic", r)
+			slog.Error("[SPRINKLER] Event processor panic", "panic", r)
 		}
 	}()
 
@@ -328,17 +270,7 @@ func (sm *sprinklerMonitor) processEvents() {
 		case <-sm.ctx.Done():
 			return
 		case prURL := <-sm.eventChan:
-			// Process each event with panic recovery
-			func() {
-				defer func() {
-					if r := recover(); r != nil {
-						slog.Error("[SPRINKLER] Event processing panic",
-							"panic", r,
-							"url", prURL)
-					}
-				}()
-				sm.checkAndNotify(prURL)
-			}()
+			sm.checkAndNotify(prURL)
 		}
 	}
 }

go.sum

@@ -1,19 +1,11 @@
 git.sr.ht/~jackmordaunt/go-toast v1.1.2 h1:/yrfI55LRt1M7H1vkaw+NaH1+L1CDxrqDltwm5euVuE=
 git.sr.ht/~jackmordaunt/go-toast v1.1.2/go.mod h1:jA4OqHKTQ4AFBdwrSnwnskUIIS3HYzlJSgdzCKqfavo=
-github.com/codeGROOVE-dev/prx v0.0.0-20250923100916-d2b60be50274 h1:9eLzQdOaQEn30279ai3YjNdJOM/efbcYanWC9juAJ+M=
-github.com/codeGROOVE-dev/prx v0.0.0-20250923100916-d2b60be50274/go.mod h1:7qLbi18baOyS8yO/6/64SBIqtyzSzLFdsDST15NPH3w=
 github.com/codeGROOVE-dev/prx v0.0.0-20251001143458-17e6b58fb46c h1:/rrjFoqwFqKNzc1f14vQt6QJ9U5tQ4Uh6U8hgixkSqw=
 github.com/codeGROOVE-dev/prx v0.0.0-20251001143458-17e6b58fb46c/go.mod h1:7qLbi18baOyS8yO/6/64SBIqtyzSzLFdsDST15NPH3w=
 github.com/codeGROOVE-dev/retry v1.2.0 h1:xYpYPX2PQZmdHwuiQAGGzsBm392xIMl4nfMEFApQnu8=
 github.com/codeGROOVE-dev/retry v1.2.0/go.mod h1:8OgefgV1XP7lzX2PdKlCXILsYKuz6b4ZpHa/20iLi8E=
-github.com/codeGROOVE-dev/sprinkler v0.0.0-20251001125233-5fa6f0ff4582 h1:IPCaNGRWdyMZKyjnjv+wdSmPmOZtKFD6SVaha5DuCqk=
-github.com/codeGROOVE-dev/sprinkler v0.0.0-20251001125233-5fa6f0ff4582/go.mod h1:RZ/Te7HkY5upHQlnmf3kV4GHVM0R8AK3U+yPItCZAoQ=
-github.com/codeGROOVE-dev/sprinkler v0.0.0-20251001144140-ed20651ca4e9 h1:Nuyy0vMl6YD96N6WwZeqClPa/VlaILJYZoG50ezOAHw=
-github.com/codeGROOVE-dev/sprinkler v0.0.0-20251001144140-ed20651ca4e9/go.mod h1:RZ/Te7HkY5upHQlnmf3kV4GHVM0R8AK3U+yPItCZAoQ=
 github.com/codeGROOVE-dev/sprinkler v0.0.0-20251001154245-068712aa969d h1:tQX67dAzyWVAaNe0EhYpj/AmWZo1Wwhaah6KVj7M3qs=
 github.com/codeGROOVE-dev/sprinkler v0.0.0-20251001154245-068712aa969d/go.mod h1:RZ/Te7HkY5upHQlnmf3kV4GHVM0R8AK3U+yPItCZAoQ=
-github.com/codeGROOVE-dev/turnclient v0.0.0-20250922145707-664c2dcdf5b8 h1:3088TLJGgxzjM/bR1gafKQ609NMkBNlZe1Fd5SnRrrY=
-github.com/codeGROOVE-dev/turnclient v0.0.0-20250922145707-664c2dcdf5b8/go.mod h1:7lBF4vS6T+D1rNjmJ+CNVrXALQvdwNfBVEy7vhIQtYk=
 github.com/codeGROOVE-dev/turnclient v0.0.0-20251001151440-a58eb9b17826 h1:ly6n4spiC6r0IOMl8QfZjv+qUnMHLvo/qErGPVMV3IE=
 github.com/codeGROOVE-dev/turnclient v0.0.0-20251001151440-a58eb9b17826/go.mod h1:JXk9gT6Qb496lnTcgpk9h917XaREGa+t6Kvg0YHAQJY=
 github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=