more TestIsStale fixing, run tests w/ -race

Author: tstromberg

Makefile

@@ -10,7 +10,10 @@ GIT_COMMIT := $(shell git rev-parse --short HEAD 2>/dev/null || echo "unknown")
 BUILD_DATE := $(shell date -u +"%Y-%m-%dT%H:%M:%SZ")
 LDFLAGS := -X main.version=$(GIT_VERSION) -X main.commit=$(GIT_COMMIT) -X main.date=$(BUILD_DATE)
 
-.PHONY: all build clean deps run app-bundle install install-darwin install-unix install-windows
+.PHONY: all build clean deps run app-bundle install install-darwin install-unix install-windows test
+
+test:
+	go test -race ./...
 
 # Default target
 all: build

cmd/goose/main_test.go

@@ -47,7 +47,7 @@ func TestIsStale(t *testing.T) {
 			// isStale was inlined - test the logic directly
 			// Use the same 'now' for consistency
 			threshold := now.Add(-stalePRThreshold)
-			got := tt.time.Before(threshold)
+			got := !tt.time.After(threshold) // time <= threshold means stale (>= 90 days old)
 			if got != tt.expected {
 				t.Logf("Test time: %v, Threshold: %v, Before: %v", tt.time, threshold, got)
 				t.Errorf("stale check = %v, want %v", got, tt.expected)