improve UX

Author: tstromberg

.DS_Store

@@ -75,13 +75,13 @@ func isRunningFromAppBundle() bool {
 	if err != nil {
 		return false
 	}
-	
+
 	// Resolve any symlinks
 	execPath, err = filepath.EvalSymlinks(execPath)
 	if err != nil {
 		return false
 	}
-	
+
 	// Check if we're running from an app bundle
 	// App bundles have the structure: /path/to/App.app/Contents/MacOS/executable
 	return strings.Contains(execPath, ".app/Contents/MacOS/")
@@ -122,19 +122,19 @@ func addLoginItemUI(app *App) {
 		log.Println("Hiding 'Start at Login' menu item - not running from app bundle")
 		return
 	}
-	
+
 	loginItem := systray.AddMenuItem("Start at Login", "Automatically start when you log in")
 	app.menuItems = append(app.menuItems, loginItem)
-	
+
 	// Set initial state
 	if isLoginItem() {
 		loginItem.Check()
 	}
-	
+
 	loginItem.Click(func() {
 		isEnabled := isLoginItem()
 		newState := !isEnabled
-		
+
 		if err := setLoginItem(newState); err != nil {
 			log.Printf("Failed to set login item: %v", err)
 			// Revert the UI state on error
@@ -145,12 +145,12 @@ func addLoginItemUI(app *App) {
 			}
 			return
 		}
-		
+
 		// Update UI state
 		if newState {
 			loginItem.Check()
 		} else {
 			loginItem.Uncheck()
 		}
 	})
-}
+}

loginitem_darwin.go

@@ -7,4 +7,4 @@ package main
 // addLoginItemUI is a no-op on non-macOS platforms
 func addLoginItemUI(app *App) {
 	// Login items are only supported on macOS
-}
+}

loginitem_other.go

@@ -6,11 +6,13 @@ package main
 
 import (
 	"context"
+	"crypto/sha256"
 	_ "embed"
 	"fmt"
 	"log"
 	"os"
 	"path/filepath"
+	"strings"
 	"sync"
 	"time"
 
@@ -60,8 +62,9 @@ type App struct {
 	outgoing           []PR
 	menuItems          []*systray.MenuItem
 	cacheDir           string
-	showStaleIncoming  bool
+	hideStaleIncoming  bool
 	previousBlockedPRs map[string]bool // Track previously blocked PRs by URL
+	lastMenuHash       string          // Hash of last menu state to detect changes
 	mu                 sync.RWMutex    // Protects concurrent access to PR data
 }
 
@@ -81,7 +84,7 @@ func main() {
 	app := &App{
 		ctx:                context.Background(),
 		cacheDir:           cacheDir,
-		showStaleIncoming:  false,
+		hideStaleIncoming:  true,
 		previousBlockedPRs: make(map[string]bool),
 	}
 
@@ -212,8 +215,8 @@ func (app *App) updatePRs() {
 
 	app.mu.RLock()
 	for _, pr := range app.incoming {
-		// Skip stale PRs if not showing them
-		if !app.showStaleIncoming && isStale(pr.UpdatedAt) {
+		// Skip stale PRs if hiding them
+		if app.hideStaleIncoming && isStale(pr.UpdatedAt) {
 			continue
 		}
 		if pr.NeedsReview {
@@ -222,6 +225,10 @@ func (app *App) updatePRs() {
 	}
 
 	for _, pr := range app.outgoing {
+		// Skip stale PRs if hiding them
+		if app.hideStaleIncoming && isStale(pr.UpdatedAt) {
+			continue
+		}
 		if pr.IsBlocked {
 			outgoingBlocked++
 		}
@@ -238,10 +245,54 @@ func (app *App) updatePRs() {
 		systray.SetTitle(fmt.Sprintf("0/%d 🚀", outgoingBlocked))
 	}
 
-	app.updateMenu()
+	app.updateMenuIfChanged()
 }
 
 // isStale returns true if the PR hasn't been updated in over 90 days
 func isStale(updatedAt time.Time) bool {
 	return time.Since(updatedAt) > stalePRThreshold
 }
+
+// generateMenuHash creates a hash of the current menu state to detect changes
+func (app *App) generateMenuHash() string {
+	var builder strings.Builder
+
+	app.mu.RLock()
+	defer app.mu.RUnlock()
+
+	// Include hideStaleIncoming setting
+	builder.WriteString(fmt.Sprintf("hide:%v|", app.hideStaleIncoming))
+
+	// Hash incoming PRs (filtered by stale setting)
+	builder.WriteString("incoming:")
+	for _, pr := range app.incoming {
+		if !app.hideStaleIncoming || !isStale(pr.UpdatedAt) {
+			builder.WriteString(fmt.Sprintf("%d:%s:%v:%s|", pr.ID, pr.Repository, pr.NeedsReview, pr.Size))
+		}
+	}
+
+	// Hash outgoing PRs (filtered by stale setting)
+	builder.WriteString("outgoing:")
+	for _, pr := range app.outgoing {
+		if !app.hideStaleIncoming || !isStale(pr.UpdatedAt) {
+			builder.WriteString(fmt.Sprintf("%d:%s:%v|", pr.ID, pr.Repository, pr.IsBlocked))
+		}
+	}
+
+	// Generate SHA256 hash
+	hash := sha256.Sum256([]byte(builder.String()))
+	return fmt.Sprintf("%x", hash)
+}
+
+// updateMenuIfChanged only rebuilds the menu if the PR data has actually changed
+func (app *App) updateMenuIfChanged() {
+	currentHash := app.generateMenuHash()
+	if currentHash == app.lastMenuHash {
+		log.Println("Menu data unchanged, skipping menu rebuild")
+		return
+	}
+
+	log.Println("Menu data changed, rebuilding menu")
+	app.lastMenuHash = currentHash
+	app.updateMenu()
+}

main.go

@@ -121,7 +121,7 @@ func (app *App) updateMenu() {
 
 	app.mu.RLock()
 	for _, pr := range app.incoming {
-		if app.showStaleIncoming || !isStale(pr.UpdatedAt) {
+		if !app.hideStaleIncoming || !isStale(pr.UpdatedAt) {
 			incomingCount++
 			if pr.NeedsReview {
 				incomingBlocked++
@@ -132,11 +132,12 @@ func (app *App) updateMenu() {
 	outgoingBlocked := 0
 	outgoingCount := 0
 	for _, pr := range app.outgoing {
-		if pr.IsBlocked {
-			outgoingBlocked++
+		if !app.hideStaleIncoming || !isStale(pr.UpdatedAt) {
+			outgoingCount++
+			if pr.IsBlocked {
+				outgoingBlocked++
+			}
 		}
-		// Count all outgoing PRs
-		outgoingCount++
 	}
 	app.mu.RUnlock()
 
@@ -163,7 +164,7 @@ func (app *App) updateMenu() {
 
 		for _, pr := range prs {
 			// Apply filters
-			if !app.showStaleIncoming && isStale(pr.UpdatedAt) {
+			if app.hideStaleIncoming && isStale(pr.UpdatedAt) {
 				continue
 			}
 			title := fmt.Sprintf("%s #%d", pr.Repository, pr.Number)
@@ -204,7 +205,10 @@ func (app *App) updateMenu() {
 		app.mu.RUnlock()
 
 		for _, pr := range prs {
-			// No filters for outgoing PRs
+			// Apply stale filter to outgoing PRs
+			if app.hideStaleIncoming && isStale(pr.UpdatedAt) {
+				continue
+			}
 			title := fmt.Sprintf("%s #%d", pr.Repository, pr.Number)
 			if pr.IsBlocked {
 				title = fmt.Sprintf("%s 🚀", title)
@@ -226,20 +230,22 @@ func (app *App) updateMenu() {
 
 	systray.AddSeparator()
 
-	// Show stale incoming
-	showStaleIncomingItem := systray.AddMenuItem("Show stale PRs (>90 days)", "")
-	app.menuItems = append(app.menuItems, showStaleIncomingItem)
-	if !app.showStaleIncoming {
-		showStaleIncomingItem.Check()
+	// Hide stale PRs
+	hideStaleItem := systray.AddMenuItem("Hide stale PRs (>90 days)", "")
+	app.menuItems = append(app.menuItems, hideStaleItem)
+	if app.hideStaleIncoming {
+		hideStaleItem.Check()
 	}
-	showStaleIncomingItem.Click(func() {
-		app.showStaleIncoming = !app.showStaleIncoming
-		if app.showStaleIncoming {
-			showStaleIncomingItem.Check()
+	hideStaleItem.Click(func() {
+		app.hideStaleIncoming = !app.hideStaleIncoming
+		if app.hideStaleIncoming {
+			hideStaleItem.Check()
 		} else {
-			showStaleIncomingItem.Uncheck()
+			hideStaleItem.Uncheck()
 		}
-		log.Printf("Show stale incoming: %v", app.showStaleIncoming)
+		log.Printf("Hide stale PRs: %v", app.hideStaleIncoming)
+		// Force menu rebuild since hideStaleIncoming changed
+		app.lastMenuHash = ""
 		app.updateMenu()
 	})