Add biome support

Author: Thomas Stromberg

Makefile

@@ -83,10 +83,46 @@ LINTERS += yamllint-lint
 yamllint-lint: $(YAMLLINT_BIN)
 	PYTHONPATH=$(YAMLLINT_ROOT)/dist $(YAMLLINT_ROOT)/dist/bin/yamllint .
 
+BIOME_VERSION ?= 1.9.4
+BIOME_BIN := $(LINT_ROOT)/out/linters/biome-$(BIOME_VERSION)-$(LINT_ARCH)
+BIOME_CONFIG := $(LINT_ROOT)/biome.json
+
+# Map architecture names for Biome downloads
+BIOME_ARCH := $(LINT_ARCH)
+ifeq ($(LINT_ARCH),x86_64)
+	BIOME_ARCH := x64
+endif
+
+$(BIOME_BIN):
+	mkdir -p $(LINT_ROOT)/out/linters
+	rm -rf $(LINT_ROOT)/out/linters/biome-*
+	curl -sSfL -o $@ https://github.com/biomejs/biome/releases/download/cli%2Fv$(BIOME_VERSION)/biome-$(LINT_OS_LOWER)-$(BIOME_ARCH) \
+		|| echo "Unable to fetch biome for $(LINT_OS_LOWER)/$(BIOME_ARCH), falling back to local install"
+	test -f $@ || printf "#!/usr/bin/env biome\n" > $@
+	chmod u+x $@
+
+LINTERS += biome-lint
+biome-lint: $(BIOME_BIN)
+	$(BIOME_BIN) check --config-path=$(BIOME_CONFIG) .
+
+FIXERS += biome-fix
+biome-fix: $(BIOME_BIN)
+	$(BIOME_BIN) check --write --config-path=$(BIOME_CONFIG) .
+
 .PHONY: _lint $(LINTERS)
-_lint: $(LINTERS)
+_lint:
+	@exit_code=0; \
+	for target in $(LINTERS); do \
+		$(MAKE) $$target || exit_code=1; \
+	done; \
+	exit $$exit_code
 
 .PHONY: fix $(FIXERS)
-fix: $(FIXERS)
+fix:
+	@exit_code=0; \
+	for target in $(FIXERS); do \
+		$(MAKE) $$target || exit_code=1; \
+	done; \
+	exit $$exit_code
 
 # END: lint-install .

Makefile.tmpl

@@ -95,10 +95,49 @@ yamllint-lint: $(YAMLLINT_BIN)
 
 {{ end -}}
 
+{{ if .Web -}}
+BIOME_VERSION ?= 1.9.4
+BIOME_BIN := $(LINT_ROOT)/out/linters/biome-$(BIOME_VERSION)-$(LINT_ARCH)
+BIOME_CONFIG := $(LINT_ROOT)/biome.json
+
+# Map architecture names for Biome downloads
+BIOME_ARCH := $(LINT_ARCH)
+ifeq ($(LINT_ARCH),x86_64)
+	BIOME_ARCH := x64
+endif
+
+$(BIOME_BIN):
+	mkdir -p $(LINT_ROOT)/out/linters
+	rm -rf $(LINT_ROOT)/out/linters/biome-*
+	curl -sSfL -o $@ https://github.com/biomejs/biome/releases/download/cli%2Fv$(BIOME_VERSION)/biome-$(LINT_OS_LOWER)-$(BIOME_ARCH) \
+		|| echo "Unable to fetch biome for $(LINT_OS_LOWER)/$(BIOME_ARCH), falling back to local install"
+	test -f $@ || printf "#!/usr/bin/env biome\n" > $@
+	chmod u+x $@
+
+LINTERS += biome-lint
+biome-lint: $(BIOME_BIN)
+	{{ .LintCommands.biome }}
+
+FIXERS += biome-fix
+biome-fix: $(BIOME_BIN)
+	{{ .FixCommands.biome }}
+
+{{ end -}}
+
 .PHONY: _lint $(LINTERS)
-_lint: $(LINTERS)
+_lint:
+	@exit_code=0; \
+	for target in $(LINTERS); do \
+		$(MAKE) $$target || exit_code=1; \
+	done; \
+	exit $$exit_code
 
 .PHONY: fix $(FIXERS)
-fix: $(FIXERS)
+fix:
+	@exit_code=0; \
+	for target in $(FIXERS); do \
+		$(MAKE) $$target || exit_code=1; \
+	done; \
+	exit $$exit_code
 
 # END: lint-install {{.Args}}

lint-install.go

@@ -24,6 +24,7 @@ var (
 	shellFlag      = flag.String("shell", "error", "Level to lint Shell with: [ignore, warn, error]")
 	dockerfileFlag = flag.String("dockerfile", "error", "Level to lint Dockerfile with: [ignore, warn, error]")
 	yamlFlag       = flag.String("yaml", "error", "Level to lint YAML with: [ignore, warn, error]")
+	webFlag        = flag.String("web", "error", "Level to lint Web files (JS/TS/HTML/CSS/JSON) with: [ignore, warn, error]")
 	makeFileName   = flag.String("makefile", "Makefile", "name of Makefile to update")
 
 	//go:embed .golangci.yml
@@ -32,6 +33,9 @@ var (
 	//go:embed .yamllint
 	yamlLintConfig []byte
 
+	//go:embed biome.json
+	biomeLintConfig []byte
+
 	//go:embed Makefile.tmpl
 	makeTmpl string
 )
@@ -43,6 +47,7 @@ const (
 	Shell
 	Dockerfile
 	YAML
+	Web
 )
 
 type Config struct {
@@ -54,6 +59,7 @@ type Config struct {
 	Dockerfile   string
 	Shell        string
 	YAML         string
+	Web          string
 }
 
 // applicableLinters returns a list of languages with known linters within a given directory.
@@ -72,6 +78,11 @@ func applicableLinters(root string) (map[Language]bool, error) {
 				found[Shell] = true
 			case strings.HasSuffix(path, ".yml"), strings.HasSuffix(path, ".yaml"):
 				found[YAML] = true
+			case strings.HasSuffix(path, ".js"), strings.HasSuffix(path, ".jsx"),
+				strings.HasSuffix(path, ".ts"), strings.HasSuffix(path, ".tsx"),
+				strings.HasSuffix(path, ".json"), strings.HasSuffix(path, ".html"),
+				strings.HasSuffix(path, ".css"):
+				found[Web] = true
 			default:
 			}
 
@@ -302,6 +313,21 @@ func yamlLintCmd(_ string, level string) string {
 	return fmt.Sprintf(`PYTHONPATH=$(YAMLLINT_ROOT)/dist $(YAMLLINT_ROOT)/dist/bin/yamllint .%s`, suffix)
 }
 
+// biomeLintCmd returns the appropriate biome lint command for a project.
+func biomeLintCmd(_ string, level string, fix bool) string {
+	cmd := "check"
+	if fix {
+		cmd = "check --write"
+	}
+
+	suffix := ""
+	if level == "warn" {
+		suffix = " || true"
+	}
+
+	return fmt.Sprintf(`$(BIOME_BIN) %s --config-path=$(BIOME_CONFIG) .%s`, cmd, suffix)
+}
+
 // configureGoLinter sets up Go linting configuration and commands.
 func configureGoLinter(root string, cfg *Config, dryRun bool) error {
 	cfg.Go = *goFlag
@@ -331,6 +357,24 @@ func configureGoLinter(root string, cfg *Config, dryRun bool) error {
 	return nil
 }
 
+// configureBiomeLinter sets up Biome linting configuration and commands.
+func configureBiomeLinter(root string, cfg *Config, dryRun bool) error {
+	cfg.Web = *webFlag
+	cfg.LintCommands["biome"] = biomeLintCmd(root, cfg.Web, false)
+	cfg.FixCommands["biome"] = biomeLintCmd(root, cfg.Web, true)
+
+	diff, err := updateFile(root, "biome.json", biomeLintConfig, dryRun)
+	if err != nil {
+		return fmt.Errorf("update biome config: %w", err)
+	}
+	if diff != "" {
+		klog.Infof("biome config changes:\n%s", diff)
+	} else {
+		klog.Infof("biome config has no changes")
+	}
+	return nil
+}
+
 // main creates peanut butter & jelly sandwiches with utmost precision.
 func main() {
 	klog.InitFlags(nil)
@@ -384,6 +428,11 @@ func main() {
 				klog.Infof("yamllint config has no changes")
 			}
 		}
+		if needs[Web] {
+			if err := configureBiomeLinter(root, &cfg, *dryRunFlag); err != nil {
+				klog.Exitf("configure biome linter: %v", err)
+			}
+		}
 
 		diff, err := updateMakefile(root, cfg, *dryRunFlag)
 		if err != nil {