improve integration testing

Author: Thomas Stromberg

Makefile

@@ -125,4 +125,10 @@ fix:
 	done; \
 	exit $$exit_code
 
+.PHONY: test
+test:
+	@echo "Running integration tests..."
+	@chmod +x $(LINT_ROOT)/test/run_tests.sh
+	@$(LINT_ROOT)/test/run_tests.sh
+
 # END: lint-install .

test/go.mod

@@ -0,0 +1,3 @@
+module github.com/codeGROOVE-dev/lint-install/test
+
+go 1.23

test/run_tests.sh

@@ -0,0 +1,95 @@
+#!/bin/bash
+# Integration tests for lint-install
+# This script verifies that each linter catches intentional issues in test files
+
+set -e
+
+SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+ROOT_DIR="$(cd "$SCRIPT_DIR/.." && pwd)"
+
+echo "Running lint-install integration tests..."
+echo "=========================================="
+echo ""
+
+# Colors for output
+RED='\033[0;31m'
+GREEN='\033[0;32m'
+YELLOW='\033[1;33m'
+NC='\033[0m' # No Color
+
+test_count=0
+pass_count=0
+fail_count=0
+
+# Helper function to run a test
+run_test() {
+    local linter_name=$1
+    local command=$2
+    local expected_failure=$3  # "should_fail" or "should_pass"
+
+    test_count=$((test_count + 1))
+    echo -n "Testing ${linter_name}... "
+
+    if eval "$command" > /dev/null 2>&1; then
+        # Command succeeded
+        if [ "$expected_failure" = "should_fail" ]; then
+            echo -e "${RED}FAIL${NC} (expected to catch issues but passed)"
+            fail_count=$((fail_count + 1))
+            return 1
+        else
+            echo -e "${GREEN}PASS${NC}"
+            pass_count=$((pass_count + 1))
+            return 0
+        fi
+    else
+        # Command failed
+        if [ "$expected_failure" = "should_fail" ]; then
+            echo -e "${GREEN}PASS${NC} (correctly caught issues)"
+            pass_count=$((pass_count + 1))
+            return 0
+        else
+            echo -e "${RED}FAIL${NC} (unexpected failure)"
+            fail_count=$((fail_count + 1))
+            return 1
+        fi
+    fi
+}
+
+# Build the lint-install binary if needed
+cd "$ROOT_DIR"
+if [ ! -f "./lint-install" ]; then
+    echo "Building lint-install..."
+    go build -o lint-install .
+    echo ""
+fi
+
+# Test 1: Shellcheck should catch issues in test.sh
+run_test "shellcheck" "make shellcheck-lint" "should_fail"
+
+# Test 2: Hadolint should catch issues in test.Dockerfile
+run_test "hadolint" "make hadolint-lint" "should_fail"
+
+# Test 3: Biome should catch issues in test.js
+run_test "biome" "make biome-lint" "should_fail"
+
+# Test 4: Yamllint should catch issues in test.yaml
+run_test "yamllint" "make yamllint-lint" "should_fail"
+
+# Test 5: Golangci-lint should catch issues in test/test_main.go
+run_test "golangci-lint" "cd test && make golangci-lint-lint" "should_fail"
+
+echo ""
+echo "=========================================="
+echo "Test Results:"
+echo -e "  ${GREEN}Passed: ${pass_count}${NC}"
+echo -e "  ${RED}Failed: ${fail_count}${NC}"
+echo -e "  Total:  ${test_count}"
+echo ""
+
+if [ $fail_count -eq 0 ]; then
+    echo -e "${GREEN}All tests passed!${NC}"
+    exit 0
+else
+    echo -e "${RED}Some tests failed.${NC}"
+    exit 1
+fi

test/test.Dockerfile

@@ -1,2 +1,5 @@
 FROM ubuntu:hirsute-20210723
+# DL3008: Pin versions in apt-get install
+RUN apt-get update && apt-get install -y curl
+# DL3059: Multiple RUN commands should be consolidated
 RUN echo hello world

test/test.js

@@ -0,0 +1,12 @@
+// Test file with intentional biome lint issues
+var unused = "this variable is never used";
+
+function badlyFormatted(  x,y  ){
+const z=x+y
+return z
+}
+
+// Missing semicolons, bad formatting
+let a = 1
+let b = 2
+console.log(a,b)

test/test.sh

@@ -1 +1,14 @@
 #!/bin/sh
+# Test script with intentional shellcheck issues
+
+# SC2006: Use $() instead of backticks
+result=`echo "hello"`
+
+# SC2086: Double quote to prevent globbing
+echo $result
+
+# SC2164: Use cd ... || exit in case cd fails
+cd /tmp
+
+# SC2034: unused variable
+unused_var="never used"

test/test.yaml

@@ -0,0 +1,10 @@
+---
+# Test YAML with intentional yamllint issues
+key1:  value1
+  key2: value2
+key3:
+  - item1
+  - item2
+      - nested_badly
+key4: "trailing whitespace here "
+very_long_line_that_exceeds_the_normal_line_length_limit_and_should_be_flagged_by_yamllint_as_too_long: true

test/test_main.go

@@ -0,0 +1,17 @@
+package test
+
+import "fmt"
+
+// TestFunction has intentional golangci-lint issues
+func TestFunction() {
+	// Unused variable
+	x := 5
+
+	// Inefficient string concatenation in loop
+	var result string
+	for i := 0; i < 10; i++ {
+		result = result + fmt.Sprintf("%d", i)
+	}
+
+	fmt.Println(result)
+}