Update for golangci-lint v1.42.0

Author: tstromberg

.golangci.yml

@@ -2,8 +2,8 @@
 linters-settings:
   cyclop:
     # NOTE: This is a very high transitional threshold
-    max-complexity: 36
-    package-average: 10.0
+    max-complexity: 38
+    package-average: 34.0
     skip-tests: true
 
   gocognit:
@@ -26,13 +26,58 @@ linters-settings:
     default-signifies-exhaustive: true
 
   nestif:
-    min-complexity: 7
+    min-complexity: 10
 
   nolintlint:
       require-explanation: true
       allow-unused: false
       require-specific: true
 
+  revive:
+    ignore-generated-header: true
+    severity: warning
+    rules:
+      - name: atomic
+      - name: blank-imports
+      - name: bool-literal-in-expr
+      - name: confusing-naming
+      - name: constant-logical-expr
+      - name: context-as-argument
+      - name: context-keys-type
+      - name: deep-exit
+      - name: defer
+      - name: range-val-in-closure
+      - name: range-val-address
+      - name: dot-imports
+      - name: empty-block
+      - name: error-naming
+      - name: error-return
+      - name: error-strings
+      - name: errorf
+      - name: exported
+      - name: identical-branches
+      - name: if-return
+      - name: import-shadowing
+      - name: increment-decrement
+      - name: indent-error-flow
+      - name: indent-error-flow
+      - name: package-comments
+      - name: range
+      - name: receiver-naming
+      - name: redefines-builtin-id
+      - name: superfluous-else
+      - name: struct-tag
+      - name: time-naming
+      - name: unexported-naming
+      - name: unexported-return
+      - name: unnecessary-stmt
+      - name: unreachable-code
+      - name: unused-parameter
+      - name: var-declaration
+      - name: var-naming
+      - name: unconditional-recursion
+      - name: waitgroup-by-value
+
   staticcheck:
     go: "1.16"
 
@@ -53,6 +98,8 @@ linters:
     - dupl
     - durationcheck
     - errcheck
+    # errname is only available in golangci-lint v1.42.0+ - wait until v1.43 is available to settle
+    #- errname
     - errorlint
     - exhaustive
     - exportloopref
@@ -141,8 +188,6 @@ issues:
         - tparallel
       text: "call t.Parallel on the top level as well as its subtests"
 
-  # Maximum count of issues with the same text. Set to 0 to disable. Default is 3.
-  max-same-issues: 10
-
-  # Maximum issues count per one linter. Set to 0 to disable. Default is 50.
-  max-issues-per-linter: 100
+  # Don't hide lint issues just because there are many of them
+  max-same-issues: 0
+  max-issues-per-linter: 0

Makefile.tmpl

@@ -1,7 +1,7 @@
 
 # BEGIN: lint-install {{.Args}}
 
-GOLINT_VERSION ?= v1.41.1
+GOLINT_VERSION ?= v1.42.0
 HADOLINT_VERSION ?= v2.6.1
 SHELLCHECK_VERSION ?= v0.7.2
 LINT_OS := $(shell uname)