dump dead code

Author: Thomas Stromberg

pkg/prx/collaborators_cache.go

@@ -43,45 +43,6 @@ func newCollaboratorsCache(cacheDir string) *collaboratorsCache {
 	return cc
 }
 
-// get retrieves a cached collaborators list if it exists and is not expired.
-//
-//nolint:unused // Called from graphql_complete.go
-func (cc *collaboratorsCache) get(owner, repo string) (map[string]string, bool) {
-	key := fmt.Sprintf("%s/%s", owner, repo)
-
-	cc.mu.RLock()
-	defer cc.mu.RUnlock()
-
-	entry, exists := cc.memory[key]
-	if !exists {
-		return nil, false
-	}
-
-	// Check if cache entry is expired
-	if time.Since(entry.CachedAt) > collaboratorsCacheDuration {
-		return nil, false
-	}
-
-	return entry.Collaborators, true
-}
-
-// set stores a collaborators list in the cache.
-//
-//nolint:unused // Called from graphql_complete.go
-func (cc *collaboratorsCache) set(owner, repo string, collaborators map[string]string) error {
-	key := fmt.Sprintf("%s/%s", owner, repo)
-
-	cc.mu.Lock()
-	cc.memory[key] = collaboratorsEntry{
-		Collaborators: collaborators,
-		CachedAt:      time.Now(),
-	}
-	cc.mu.Unlock()
-
-	// Save to disk after releasing the lock
-	return cc.saveToDisk()
-}
-
 // loadFromDisk loads the cache from disk.
 func (cc *collaboratorsCache) loadFromDisk() error {
 	// Skip if no disk path is set (in-memory only mode)
@@ -114,38 +75,3 @@ func (cc *collaboratorsCache) loadFromDisk() error {
 
 	return nil
 }
-
-// saveToDisk saves the current cache to disk.
-//
-//nolint:unused // Called from set()
-func (cc *collaboratorsCache) saveToDisk() error {
-	// Skip if no disk path is set (in-memory only mode)
-	if cc.diskPath == "" {
-		return nil
-	}
-
-	// Create a copy to avoid holding the lock during I/O
-	cc.mu.RLock()
-	cacheCopy := make(map[string]collaboratorsEntry, len(cc.memory))
-	for k, v := range cc.memory {
-		cacheCopy[k] = v
-	}
-	cc.mu.RUnlock()
-
-	data, err := json.Marshal(cacheCopy)
-	if err != nil {
-		return fmt.Errorf("marshaling collaborators cache: %w", err)
-	}
-
-	// Write to temp file first, then rename for atomicity
-	tempFile := cc.diskPath + ".tmp"
-	if err := os.WriteFile(tempFile, data, 0o600); err != nil {
-		return fmt.Errorf("writing collaborators cache: %w", err)
-	}
-
-	if err := os.Rename(tempFile, cc.diskPath); err != nil {
-		return fmt.Errorf("renaming collaborators cache: %w", err)
-	}
-
-	return nil
-}

pkg/prx/graphql_complete.go

@@ -1018,7 +1018,8 @@ func (c *Client) convertGraphQLToPullRequest(ctx context.Context, data *graphQLP
 		pr.AuthorWriteAccess = c.writeAccessFromAssociation(ctx, owner, repo, data.Author.Login, data.AuthorAssociation)
 	}
 
-	// Assignees
+	// Assignees (initialize to empty slice if none)
+	pr.Assignees = make([]string, 0)
 	for _, assignee := range data.Assignees.Nodes {
 		pr.Assignees = append(pr.Assignees, assignee.Login)
 	}

pkg/prx/pullrequest.go

@@ -39,7 +39,7 @@ type PullRequest struct {
 	CheckSummary    *CheckSummary    `json:"check_summary,omitempty"`
 	Mergeable       *bool            `json:"mergeable"`
 	// 24-byte slice/map fields
-	Assignees []string               `json:"assignees,omitempty"`
+	Assignees []string               `json:"assignees"`
 	Labels    []string               `json:"labels,omitempty"`
 	Reviewers map[string]ReviewState `json:"reviewers,omitempty"`
 	// 16-byte string fields