lint

Author: Thomas Stromberg

cmd/server/main.go

@@ -671,8 +671,6 @@ func (cm *coordinatorManager) handleRefreshInstallations(ctx context.Context) {
 // runBotCoordinators manages bot coordinators for all GitHub installations.
 // It spawns one coordinator per org and refreshes the list every 5 minutes.
 // Failed coordinators are automatically restarted every minute.
-//
-//nolint:interfacebloat // Interface mirrors state.Store for local type safety
 func runBotCoordinators(
 	ctx context.Context,
 	slackManager *slack.Manager,

pkg/bot/bot.go

@@ -37,15 +37,6 @@ type prContext struct {
 	Number   int
 }
 
-// ThreadInfo is an alias to cache.ThreadInfo for backward compatibility.
-type ThreadInfo = cache.ThreadInfo
-
-// ThreadCache is an alias to cache.ThreadCache for backward compatibility.
-type ThreadCache = cache.ThreadCache
-
-// CommitPRCache is an alias to cache.CommitPRCache for backward compatibility.
-type CommitPRCache = cache.CommitPRCache
-
 // Coordinator coordinates between GitHub, Slack, and notifications for a single org.
 //
 //nolint:govet // Field order optimized for logical grouping over memory alignment
@@ -59,15 +50,15 @@ type Coordinator struct {
 	configManager    ConfigManager
 	notifier         *notify.Manager
 	userMapper       UserMapper
-	threadCache      *ThreadCache   // In-memory cache for fast lookups
-	commitPRCache    *CommitPRCache // Maps commit SHAs to PR numbers for check events
-	eventSemaphore   chan struct{}  // Limits concurrent event processing (prevents overwhelming APIs)
+	threadCache      *cache.ThreadCache   // In-memory cache for fast lookups
+	commitPRCache    *cache.CommitPRCache // Maps commit SHAs to PR numbers for check events
+	eventSemaphore   chan struct{}        // Limits concurrent event processing (prevents overwhelming APIs)
 }
 
 // StateStore interface for persistent state - allows dependency injection for testing.
 type StateStore interface {
-	Thread(owner, repo string, number int, channelID string) (ThreadInfo, bool)
-	SaveThread(owner, repo string, number int, channelID string, info ThreadInfo) error
+	Thread(owner, repo string, number int, channelID string) (cache.ThreadInfo, bool)
+	SaveThread(owner, repo string, number int, channelID string, info cache.ThreadInfo) error
 	LastDM(userID, prURL string) (time.Time, bool)
 	RecordDM(userID, prURL string, sentAt time.Time) error
 	ListDMUsers(prURL string) []string
@@ -127,7 +118,7 @@ func New(
 
 // saveThread persists thread info to both cache and persistent storage.
 // This ensures threads survive restarts and are available for closed PR updates.
-func (c *Coordinator) saveThread(owner, repo string, number int, channelID string, info ThreadInfo) {
+func (c *Coordinator) saveThread(owner, repo string, number int, channelID string, info cache.ThreadInfo) {
 	// Save to in-memory cache for fast lookups
 	key := fmt.Sprintf("%s/%s#%d:%s", owner, repo, number, channelID)
 	c.threadCache.Set(key, info)
@@ -205,7 +196,7 @@ func (c *Coordinator) findOrCreatePRThread(ctx context.Context, channelID, owner
 			"current_message_preview", initialSearchText[:min(100, len(initialSearchText))])
 
 		// Save the found thread (cache + persist)
-		c.saveThread(owner, repo, prNumber, channelID, ThreadInfo{
+		c.saveThread(owner, repo, prNumber, channelID, cache.ThreadInfo{
 			ThreadTS:    initialSearchTS,
 			ChannelID:   channelID,
 			LastState:   prState,
@@ -248,7 +239,7 @@ func (c *Coordinator) findOrCreatePRThread(ctx context.Context, channelID, owner
 			// Try to take over creation
 			if !c.threadCache.MarkCreating(cacheKey) {
 				// Still being created, give up
-				return "", false, "", fmt.Errorf("timed out waiting for thread creation")
+				return "", false, "", errors.New("timed out waiting for thread creation")
 			}
 		}
 	}
@@ -281,7 +272,7 @@ func (c *Coordinator) findOrCreatePRThread(ctx context.Context, channelID, owner
 			"note", "this prevented duplicate thread creation during rolling deployment")
 
 		// Save it and return (cache + persist)
-		c.saveThread(owner, repo, prNumber, channelID, ThreadInfo{
+		c.saveThread(owner, repo, prNumber, channelID, cache.ThreadInfo{
 			ThreadTS:    crossInstanceCheckTS,
 			ChannelID:   channelID,
 			LastState:   prState,
@@ -304,7 +295,7 @@ func (c *Coordinator) findOrCreatePRThread(ctx context.Context, channelID, owner
 	}
 
 	// Save the new thread (cache + persist)
-	c.saveThread(owner, repo, prNumber, channelID, ThreadInfo{
+	c.saveThread(owner, repo, prNumber, channelID, cache.ThreadInfo{
 		ThreadTS:    newThreadTS,
 		ChannelID:   channelID,
 		LastState:   prState,
@@ -1394,7 +1385,7 @@ func (c *Coordinator) processPRForChannel(
 					"next_poll_in", "5m")
 			} else {
 				// Save updated thread info (cache + persist)
-				c.saveThread(owner, repo, prNumber, channelID, ThreadInfo{
+				c.saveThread(owner, repo, prNumber, channelID, cache.ThreadInfo{
 					ThreadTS:    threadTS,
 					ChannelID:   channelID,
 					LastState:   prState,

pkg/bot/bot_sprinkler.go

@@ -162,6 +162,7 @@ func (c *Coordinator) lookupPRsForCheckEvent(ctx context.Context, event client.E
 							}
 
 							// Process the PR update since we have fresh data
+							//nolint:contextcheck // Background context intentional - goroutine must outlive parent timeout
 							go c.handlePullRequestEventWithData(context.Background(), owner, repo, struct {
 								Action      string `json:"action"`
 								PullRequest struct {

pkg/bot/bot_test.go

@@ -172,7 +172,7 @@ func TestSaveThread(t *testing.T) {
 
 	mockState := &mockStateStore{
 		processedEvents: make(map[string]bool),
-		threads:         make(map[string]ThreadInfo),
+		threads:         make(map[string]cache.ThreadInfo),
 	}
 
 	c := &Coordinator{
@@ -185,7 +185,7 @@ func TestSaveThread(t *testing.T) {
 		eventSemaphore: make(chan struct{}, 10),
 	}
 
-	threadInfo := ThreadInfo{
+	threadInfo := cache.ThreadInfo{
 		ChannelID: "C123456",
 		ThreadTS:  "1234567890.123456",
 	}
@@ -225,7 +225,7 @@ func TestSaveThread_PersistenceError(t *testing.T) {
 
 	mockState := &mockStateStore{
 		processedEvents: make(map[string]bool),
-		threads:         make(map[string]ThreadInfo),
+		threads:         make(map[string]cache.ThreadInfo),
 		saveThreadErr:   errors.New("database error"),
 	}
 
@@ -239,7 +239,7 @@ func TestSaveThread_PersistenceError(t *testing.T) {
 		eventSemaphore: make(chan struct{}, 10),
 	}
 
-	threadInfo := ThreadInfo{
+	threadInfo := cache.ThreadInfo{
 		ChannelID: "C123456",
 		ThreadTS:  "1234567890.123456",
 	}
@@ -268,7 +268,7 @@ func TestSaveThread_PersistenceError(t *testing.T) {
 func TestThreadCache_Set(t *testing.T) {
 	threadCache := cache.New()
 
-	threadInfo := ThreadInfo{
+	threadInfo := cache.ThreadInfo{
 		ChannelID:   "C123456",
 		ThreadTS:    "1234567890.123456",
 		MessageText: "Test message",

pkg/bot/commit_pr_cache_test.go

@@ -137,7 +137,7 @@ func TestCheckEventIntegration_CacheHit(t *testing.T) {
 
 	// Create coordinator with real commit cache
 	coord := &Coordinator{
-		stateStore: mockStore,
+		stateStore:    mockStore,
 		commitPRCache: cache.NewCommitPRCache(),
 		github: &mockGitHubClientForCache{
 			// Mock should NOT be called if cache works
@@ -185,7 +185,7 @@ func TestCheckEventIntegration_CacheMissFallback(t *testing.T) {
 
 	// Create coordinator with empty cache
 	coord := &Coordinator{
-		stateStore: mockStore,
+		stateStore:    mockStore,
 		commitPRCache: cache.NewCommitPRCache(),
 		github: &mockGitHubClientForCache{
 			// Mock SHOULD be called on cache miss

pkg/bot/coordinator_test.go

@@ -10,7 +10,7 @@ import (
 func TestCoordinator_saveThread(t *testing.T) {
 	// Create mock state store
 	mockStore := &mockStateStore{
-		threads: make(map[string]ThreadInfo),
+		threads: make(map[string]cache.ThreadInfo),
 	}
 
 	// Create coordinator with mock
@@ -24,7 +24,7 @@ func TestCoordinator_saveThread(t *testing.T) {
 	repo := "testrepo"
 	number := 123
 	channelID := "C123"
-	info := ThreadInfo{
+	info := cache.ThreadInfo{
 		ThreadTS:      "1234567890.123456",
 		MessageText:   "Test PR message",
 		ChannelID:     channelID,