improve test coverage

Author: Thomas Stromberg

.github/workflows/test.yml

@@ -0,0 +1,49 @@
+name: Tests
+
+on:
+  push:
+    branches: [main, master]
+  pull_request:
+    branches: [main, master]
+
+jobs:
+  test:
+    name: Unit and Integration Tests
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Check out code
+        uses: actions/checkout@v4
+
+      - name: Set up Go
+        uses: actions/setup-go@v5
+        with:
+          go-version: '1.23'
+          cache: true
+
+      - name: Install dependencies
+        run: |
+          sudo apt-get update
+          sudo apt-get install -y bc
+
+      - name: Download dependencies
+        run: go mod download
+
+      - name: Run tests with coverage
+        run: make test
+
+      - name: Upload coverage to Codecov
+        uses: codecov/codecov-action@v4
+        with:
+          file: ./coverage.out
+          flags: unittests
+          name: codecov-slacker
+          fail_ci_if_error: false
+        continue-on-error: true
+
+      - name: Archive coverage results
+        uses: actions/upload-artifact@v4
+        with:
+          name: coverage-report
+          path: coverage.out
+          retention-days: 30

.gitignore

@@ -1,3 +1,4 @@
 
 # added by lint-install
 out/
+coverage.out

Makefile

@@ -14,9 +14,37 @@ build-server:
 build-registrar:
 	go build -v -o bin/slack-registrar ./cmd/registrar
 
-# Run tests with race detection
+# Run tests with race detection and coverage
 test:
-	go test -v -race ./...
+	@echo "Running tests with race detection and coverage..."
+	@go test -v -race -coverprofile=coverage.out -covermode=atomic ./...
+	@echo ""
+	@echo "Coverage by package:"
+	@go test -coverprofile=coverage.out -covermode=atomic ./... 2>&1 | grep -E "coverage:" | awk '{print $$2 "\t" $$5}' | column -t
+	@echo ""
+	@echo "Checking for packages below 80% coverage..."
+	@failed=0; \
+	packages=$$(go list ./... | grep -v "/cmd/"); \
+	for pkg in $$packages; do \
+		output=$$(go test -coverprofile=/dev/null "$$pkg" 2>&1); \
+		if echo "$$output" | grep -q "\[no test files\]"; then \
+			continue; \
+		fi; \
+		coverage=$$(echo "$$output" | grep "coverage:" | awk '{print $$5}' | sed 's/%//'); \
+		if [ -n "$$coverage" ] && [ "$$coverage" != "statements" ]; then \
+			pkg_short=$$(echo "$$pkg" | sed 's|github.com/codeGROOVE-dev/slacker/||'); \
+			if [ "$$(echo "$$coverage < 80.0" | bc -l 2>/dev/null || echo 0)" -eq 1 ]; then \
+				echo "❌ FAIL: $$pkg_short has $$coverage% coverage (minimum: 80%)"; \
+				failed=1; \
+			fi; \
+		fi; \
+	done; \
+	if [ $$failed -eq 1 ]; then \
+		echo ""; \
+		echo "Coverage check failed. All packages must have at least 80% coverage."; \
+		exit 1; \
+	fi
+	@echo "✅ All packages meet 80% coverage threshold"
 
 # Format code
 fmt:

cmd/server/main.go

@@ -256,7 +256,7 @@ func run(ctx context.Context, cancel context.CancelFunc, cfg *config.ServerConfi
 	slog.Info("configured Slack manager with state store for DM tracking")
 
 	// Initialize notification manager for multi-workspace notifications.
-	notifier := notify.New(slackManager, configManager)
+	notifier := notify.New(notify.WrapSlackManager(slackManager), configManager)
 
 	// Initialize event router for multi-workspace event handling.
 	eventRouter := slack.NewEventRouter(slackManager)
@@ -711,7 +711,7 @@ func runBotCoordinators(
 	}
 
 	// Initialize daily digest scheduler
-	dailyDigest := notify.NewDailyDigestScheduler(notifier, githubManager, configManager, stateStore, slackManager)
+	dailyDigest := notify.NewDailyDigestScheduler(notifier, github.WrapManager(githubManager), configManager, stateStore, notify.WrapSlackManager(slackManager))
 
 	// Start initial coordinators
 	cm.startCoordinators(ctx)

go.mod

@@ -6,8 +6,9 @@ require (
 	cloud.google.com/go/datastore v1.21.0
 	github.com/codeGROOVE-dev/gh-mailto v0.0.0-20251024133418-149270eb16a9
 	github.com/codeGROOVE-dev/gsm v0.0.0-20251019065141-833fe2363d22
+	github.com/codeGROOVE-dev/prx v0.0.0-20251028202628-9f237ee71356
 	github.com/codeGROOVE-dev/retry v1.3.0
-	github.com/codeGROOVE-dev/sprinkler v0.0.0-20251028184624-4d8c8315a53a
+	github.com/codeGROOVE-dev/sprinkler v0.0.0-20251028194710-957b79f7bf56
 	github.com/codeGROOVE-dev/turnclient v0.0.0-20251028130307-1f85c9aa43c4
 	github.com/golang-jwt/jwt/v5 v5.3.0
 	github.com/google/go-github/v50 v50.2.0
@@ -27,7 +28,6 @@ require (
 	cloud.google.com/go/compute/metadata v0.9.0 // indirect
 	github.com/ProtonMail/go-crypto v1.3.0 // indirect
 	github.com/cloudflare/circl v1.6.1 // indirect
-	github.com/codeGROOVE-dev/prx v0.0.0-20251027204543-4e6165f046e5 // indirect
 	github.com/felixge/httpsnoop v1.0.4 // indirect
 	github.com/go-logr/logr v1.4.3 // indirect
 	github.com/go-logr/stdr v1.2.2 // indirect

go.sum

@@ -19,24 +19,16 @@ github.com/codeGROOVE-dev/gh-mailto v0.0.0-20251024133418-149270eb16a9 h1:eyWcEZ
 github.com/codeGROOVE-dev/gh-mailto v0.0.0-20251024133418-149270eb16a9/go.mod h1:4Hr2ySB8dcpeZqZq/7UbXdEJ/5RK9coYGHvW90ZfieE=
 github.com/codeGROOVE-dev/gsm v0.0.0-20251019065141-833fe2363d22 h1:gtN3rOc6YspO646BkcOxBhPjEqKUz+jl175jIqglfDg=
 github.com/codeGROOVE-dev/gsm v0.0.0-20251019065141-833fe2363d22/go.mod h1:KV+w19ubP32PxZPE1hOtlCpTaNpF0Bpb32w5djO8UTg=
-github.com/codeGROOVE-dev/prx v0.0.0-20251024000018-35ba2605d031 h1:wLeo/dwpE5F2E/j/W+lb2HJ9nEX8KYIfJ1yEtyZYdrg=
-github.com/codeGROOVE-dev/prx v0.0.0-20251024000018-35ba2605d031/go.mod h1:7qLbi18baOyS8yO/6/64SBIqtyzSzLFdsDST15NPH3w=
-github.com/codeGROOVE-dev/prx v0.0.0-20251027012315-7b273aabfc7d h1:kUaCKFRxWFrWEyl4fVHi+eY/D5tKhBU29a8YbQyihEk=
-github.com/codeGROOVE-dev/prx v0.0.0-20251027012315-7b273aabfc7d/go.mod h1:7qLbi18baOyS8yO/6/64SBIqtyzSzLFdsDST15NPH3w=
 github.com/codeGROOVE-dev/prx v0.0.0-20251027204543-4e6165f046e5 h1:tjxTLJ5NXx1xhReL4M+J4LTl/JGNSZjPrznAoci06OA=
 github.com/codeGROOVE-dev/prx v0.0.0-20251027204543-4e6165f046e5/go.mod h1:FEy3gz9IYDXWnKWkoDSL+pWu6rujxbBSrF4w5A8QSK0=
-github.com/codeGROOVE-dev/retry v1.2.0 h1:xYpYPX2PQZmdHwuiQAGGzsBm392xIMl4nfMEFApQnu8=
-github.com/codeGROOVE-dev/retry v1.2.0/go.mod h1:8OgefgV1XP7lzX2PdKlCXILsYKuz6b4ZpHa/20iLi8E=
+github.com/codeGROOVE-dev/prx v0.0.0-20251028202628-9f237ee71356 h1:lHoHnylLAp7/7BMhdiTh9Z2+p4ATcQ7aFcgqxOFGzE4=
+github.com/codeGROOVE-dev/prx v0.0.0-20251028202628-9f237ee71356/go.mod h1:FEy3gz9IYDXWnKWkoDSL+pWu6rujxbBSrF4w5A8QSK0=
 github.com/codeGROOVE-dev/retry v1.3.0 h1:/+ipAWRJLL6y1R1vprYo0FSjSBvH6fE5j9LKXjpD54g=
 github.com/codeGROOVE-dev/retry v1.3.0/go.mod h1:8OgefgV1XP7lzX2PdKlCXILsYKuz6b4ZpHa/20iLi8E=
-github.com/codeGROOVE-dev/sprinkler v0.0.0-20251027150242-98f387d0502a h1:bMRtyBA38hvuXZJUH5UDFpOAuwNINg2j/ecug31wp+M=
-github.com/codeGROOVE-dev/sprinkler v0.0.0-20251027150242-98f387d0502a/go.mod h1:/kd3ncsRNldD0MUpbtp5ojIzfCkyeXB7JdOrpuqG7Gg=
-github.com/codeGROOVE-dev/sprinkler v0.0.0-20251027213037-05bb80a9db89 h1:8Z3SM90hy1nuK2r2yhtv4HwitnO9si4GzVRktRDQ68g=
-github.com/codeGROOVE-dev/sprinkler v0.0.0-20251027213037-05bb80a9db89/go.mod h1:/kd3ncsRNldD0MUpbtp5ojIzfCkyeXB7JdOrpuqG7Gg=
 github.com/codeGROOVE-dev/sprinkler v0.0.0-20251028184624-4d8c8315a53a h1:P1qUAC4QG4zNH31y0R4ZJdnqpqHM+chKrTiI86GlIaw=
 github.com/codeGROOVE-dev/sprinkler v0.0.0-20251028184624-4d8c8315a53a/go.mod h1:/kd3ncsRNldD0MUpbtp5ojIzfCkyeXB7JdOrpuqG7Gg=
-github.com/codeGROOVE-dev/turnclient v0.0.0-20251022064427-5a712e1e10e6 h1:7FCmaftkl362oTZHVJyUg+xhxqfQFx+JisBf7RgklL8=
-github.com/codeGROOVE-dev/turnclient v0.0.0-20251022064427-5a712e1e10e6/go.mod h1:fYwtN9Ql6lY8t2WvCfENx+mP5FUwjlqwXCLx9CVLY20=
+github.com/codeGROOVE-dev/sprinkler v0.0.0-20251028194710-957b79f7bf56 h1:4/xJ+ZOrG8QNPLqQgTu28WNocO6G/iZBD0SUNKpluhk=
+github.com/codeGROOVE-dev/sprinkler v0.0.0-20251028194710-957b79f7bf56/go.mod h1:/kd3ncsRNldD0MUpbtp5ojIzfCkyeXB7JdOrpuqG7Gg=
 github.com/codeGROOVE-dev/turnclient v0.0.0-20251028130307-1f85c9aa43c4 h1:si9tMEo5SXpDuDXGkJ1zNnnpP8TbmakrkNujAbpKlqA=
 github.com/codeGROOVE-dev/turnclient v0.0.0-20251028130307-1f85c9aa43c4/go.mod h1:bFWMd0JeaJY0kSIO5AcRQdJLXF3Fo3eKclE49vmIZes=
 github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c=
@@ -129,8 +121,6 @@ golang.org/x/time v0.14.0/go.mod h1:eL/Oa2bBBK0TkX57Fyni+NgnyQQN4LitPmob2Hjnqw4=
 golang.org/x/xerrors v0.0.0-20191204190536-9bdfabe68543/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0=
 gonum.org/v1/gonum v0.16.0 h1:5+ul4Swaf3ESvrOnidPp4GZbzf0mxVQpDCYUQE7OJfk=
 gonum.org/v1/gonum v0.16.0/go.mod h1:fef3am4MQ93R2HHpKnLk4/Tbh/s0+wqD5nfa6Pnwy4E=
-google.golang.org/api v0.253.0 h1:apU86Eq9Q2eQco3NsUYFpVTfy7DwemojL7LmbAj7g/I=
-google.golang.org/api v0.253.0/go.mod h1:PX09ad0r/4du83vZVAaGg7OaeyGnaUmT/CYPNvtLCbw=
 google.golang.org/api v0.254.0 h1:jl3XrGj7lRjnlUvZAbAdhINTLbsg5dbjmR90+pTQvt4=
 google.golang.org/api v0.254.0/go.mod h1:5BkSURm3D9kAqjGvBNgf0EcbX6Rnrf6UArKkwBzAyqQ=
 google.golang.org/genproto v0.0.0-20251022142026-3a174f9686a8 h1:a12a2/BiVRxRWIqBbfqoSK6tgq8cyUgMnEI81QlPge0=

internal/bot/bot.go

@@ -1353,7 +1353,8 @@ func (c *Coordinator) processPRForChannel(
 	domain := c.configManager.Domain(owner)
 	if len(blockedUsers) > 0 {
 		// Record tags for blocked users synchronously to prevent race with DM sending
-		lookupCtx, lookupCancel := context.WithTimeout(ctx, 5*time.Second)
+		// Generous timeout: GitHub email lookup (~5-10s) + Slack API lookups (~5-10s)
+		lookupCtx, lookupCancel := context.WithTimeout(ctx, 30*time.Second)
 		defer lookupCancel()
 
 		for _, githubUser := range blockedUsers {

internal/bot/format_test.go

@@ -0,0 +1,52 @@
+package bot
+
+import (
+	"context"
+	"testing"
+
+	"github.com/codeGROOVE-dev/turnclient/pkg/turn"
+)
+
+// TestFormatNextActionsEarlyReturn tests the formatNextActions utility function early return cases.
+func TestFormatNextActionsEarlyReturn(t *testing.T) {
+	// Create a coordinator - userMapper will be nil but that's OK for these early return tests
+	c := &Coordinator{}
+
+	ctx := context.Background()
+
+	tests := []struct {
+		name     string
+		check    *turn.CheckResponse
+		owner    string
+		domain   string
+		expected string
+	}{
+		{
+			name:     "nil check response",
+			check:    nil,
+			owner:    "org",
+			domain:   "example.com",
+			expected: "",
+		},
+		{
+			name: "empty next actions",
+			check: &turn.CheckResponse{
+				Analysis: turn.Analysis{
+					NextAction: map[string]turn.Action{},
+				},
+			},
+			owner:    "org",
+			domain:   "example.com",
+			expected: "",
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			result := c.formatNextActions(ctx, tt.check, tt.owner, tt.domain)
+			if result != tt.expected {
+				t.Errorf("expected %q, got %q", tt.expected, result)
+			}
+		})
+	}
+}

internal/bot/integration_test.go

@@ -231,7 +231,7 @@ func TestDMDelayLogicIntegration(t *testing.T) {
 		dmDelay: 65, // 65 minute delay
 	}
 
-	notifier := notify.New(slackManager, configMgr)
+	notifier := notify.New(notify.WrapSlackManager(slackManager), configMgr)
 
 	prInfo := notify.PRInfo{
 		Owner:         "test",
@@ -291,7 +291,7 @@ func TestDMDelayLogicIntegration(t *testing.T) {
 			// Create fresh tracker with initialized maps
 			notifier.Tracker = &notify.NotificationTracker{}
 			// Initialize the tracker by creating a new notifier
-			notifier = notify.New(slackManager, configMgr)
+			notifier = notify.New(notify.WrapSlackManager(slackManager), configMgr)
 
 			// Setup test scenario
 			if tt.setupFunc != nil {