Add PR reminder feature

Author: Thomas Stromberg

cmd/server/main.go

@@ -162,24 +162,7 @@ func run(ctx context.Context, cancel context.CancelFunc, cfg *config.ServerConfi
 	slackManager := slack.NewManager(cfg.SlackSigningSecret)
 
 	// Initialize state store (in-memory + Datastore or JSON for persistence).
-	//nolint:interfacebloat // Interface mirrors state.Store for local type safety
-	var stateStore interface {
-		Thread(owner, repo string, number int, channelID string) (state.ThreadInfo, bool)
-		SaveThread(owner, repo string, number int, channelID string, info state.ThreadInfo) error
-		LastDM(userID, prURL string) (time.Time, bool)
-		RecordDM(userID, prURL string, sentAt time.Time) error
-		DMMessage(userID, prURL string) (state.DMInfo, bool)
-		SaveDMMessage(userID, prURL string, info state.DMInfo) error
-		ListDMUsers(prURL string) []string
-		LastDigest(userID, date string) (time.Time, bool)
-		RecordDigest(userID, date string, sentAt time.Time) error
-		WasProcessed(eventKey string) bool
-		MarkProcessed(eventKey string, ttl time.Duration) error
-		LastNotification(prURL string) time.Time
-		RecordNotification(prURL string, notifiedAt time.Time) error
-		Cleanup() error
-		Close() error
-	}
+	var stateStore state.Store
 
 	// Check if Datastore should be used via DATASTORE=<database-id>
 	// Examples:
@@ -256,7 +239,7 @@ func run(ctx context.Context, cancel context.CancelFunc, cfg *config.ServerConfi
 	slog.Info("configured Slack manager with state store for DM tracking")
 
 	// Initialize notification manager for multi-workspace notifications.
-	notifier := notify.New(notify.WrapSlackManager(slackManager), configManager)
+	notifier := notify.New(notify.WrapSlackManager(slackManager), configManager, stateStore)
 
 	// Initialize event router for multi-workspace event handling.
 	eventRouter := slack.NewEventRouter(slackManager)
@@ -679,23 +662,7 @@ func runBotCoordinators(
 	githubManager *github.Manager,
 	configManager *config.Manager,
 	notifier *notify.Manager,
-	stateStore interface {
-		Thread(owner, repo string, number int, channelID string) (state.ThreadInfo, bool)
-		SaveThread(owner, repo string, number int, channelID string, info state.ThreadInfo) error
-		LastDM(userID, prURL string) (time.Time, bool)
-		RecordDM(userID, prURL string, sentAt time.Time) error
-		DMMessage(userID, prURL string) (state.DMInfo, bool)
-		SaveDMMessage(userID, prURL string, info state.DMInfo) error
-		ListDMUsers(prURL string) []string
-		LastDigest(userID, date string) (time.Time, bool)
-		RecordDigest(userID, date string, sentAt time.Time) error
-		WasProcessed(eventKey string) bool
-		MarkProcessed(eventKey string, ttl time.Duration) error
-		LastNotification(prURL string) time.Time
-		RecordNotification(prURL string, notifiedAt time.Time) error
-		Cleanup() error
-		Close() error
-	},
+	stateStore state.Store,
 	sprinklerURL string,
 ) error {
 	cm := &coordinatorManager{

go.mod

@@ -26,6 +26,7 @@ require (
 	github.com/cloudflare/circl v1.6.1 // indirect
 	github.com/google/go-cmp v0.7.0 // indirect
 	github.com/google/go-querystring v1.1.0 // indirect
+	github.com/google/uuid v1.6.0 // indirect
 	github.com/gorilla/websocket v1.5.3 // indirect
 	github.com/kr/pretty v0.3.1 // indirect
 	github.com/rogpeppe/go-internal v1.14.1 // indirect

go.sum

@@ -30,6 +30,8 @@ github.com/google/go-github/v50 v50.2.0 h1:j2FyongEHlO9nxXLc+LP3wuBSVU9mVxfpdYUe
 github.com/google/go-github/v50 v50.2.0/go.mod h1:VBY8FB6yPIjrtKhozXv4FQupxKLS6H4m6xFZlT43q8Q=
 github.com/google/go-querystring v1.1.0 h1:AnCroh3fv4ZBgVIf1Iwtovgjaw/GiKJo8M8yD/fhyJ8=
 github.com/google/go-querystring v1.1.0/go.mod h1:Kcdr2DB4koayq7X8pmAG4sNG59So17icRSOU623lUBU=
+github.com/google/uuid v1.6.0 h1:NIvaJDMOsjHA8n1jAhLSgzrAzy1Hgr+hNrb57e+94F0=
+github.com/google/uuid v1.6.0/go.mod h1:TIyPZe4MgqvfeYDBFedMoGGpEw/LqOeaOT+nhxU+yHo=
 github.com/gorilla/mux v1.8.1 h1:TuBL49tXwgrFYWhqrNgrUNEY92u81SPhu7sTdzQEiWY=
 github.com/gorilla/mux v1.8.1/go.mod h1:AKf9I4AEqPTmMytcMc0KkNouC66V3BtZ4qD5fmWSiMQ=
 github.com/gorilla/websocket v1.5.3 h1:saDtZ6Pbx/0u+bgYQ3q96pZgCzfhKXGPqt7kZ72aNNg=

pkg/bot/integration_test.go

@@ -10,6 +10,7 @@ import (
 	"github.com/codeGROOVE-dev/slacker/pkg/notify"
 	"github.com/codeGROOVE-dev/slacker/pkg/slack"
 	"github.com/codeGROOVE-dev/slacker/pkg/slacktest"
+	"github.com/codeGROOVE-dev/slacker/pkg/state"
 	"github.com/codeGROOVE-dev/slacker/pkg/usermapping"
 	"github.com/codeGROOVE-dev/turnclient/pkg/turn"
 	slackapi "github.com/slack-go/slack"
@@ -231,7 +232,10 @@ func TestDMDelayLogicIntegration(t *testing.T) {
 		dmDelay: 65, // 65 minute delay
 	}
 
-	notifier := notify.New(notify.WrapSlackManager(slackManager), configMgr)
+	// Create in-memory store for pending DMs
+	store := state.NewMemoryStore()
+
+	notifier := notify.New(notify.WrapSlackManager(slackManager), configMgr, store)
 
 	prInfo := notify.PRInfo{
 		Owner:         "test",
@@ -291,7 +295,8 @@ func TestDMDelayLogicIntegration(t *testing.T) {
 			// Create fresh tracker with initialized maps
 			notifier.Tracker = &notify.NotificationTracker{}
 			// Initialize the tracker by creating a new notifier
-			notifier = notify.New(notify.WrapSlackManager(slackManager), configMgr)
+			store = state.NewMemoryStore() // Reset store as well
+			notifier = notify.New(notify.WrapSlackManager(slackManager), configMgr, store)
 
 			// Setup test scenario
 			if tt.setupFunc != nil {

pkg/home/fetcher_test.go

@@ -260,6 +260,18 @@ func (m *mockStateStore) Cleanup() error {
 	return nil
 }
 
+func (m *mockStateStore) QueuePendingDM(dm state.PendingDM) error {
+	return nil
+}
+
+func (m *mockStateStore) GetPendingDMs(before time.Time) ([]state.PendingDM, error) {
+	return nil, nil
+}
+
+func (m *mockStateStore) RemovePendingDM(id string) error {
+	return nil
+}
+
 func (m *mockStateStore) Close() error {
 	return nil
 }

pkg/notify/daily_digest_test.go

@@ -603,7 +603,7 @@ func TestNewDailyDigestScheduler_FactoryWorks(t *testing.T) {
 	mockConfigMgr := &mockConfigProvider{}
 	mockState := &mockStateProvider{}
 	mockSlack := &mockSlackManagerWithClient{}
-	manager := New(mockSlack, mockConfigMgr)
+	manager := New(mockSlack, mockConfigMgr, &mockStore{})
 
 	scheduler := NewDailyDigestScheduler(manager, mockGitHubMgr, mockConfigMgr, mockState, mockSlack)
 

pkg/notify/daily_test.go

@@ -472,7 +472,7 @@ func TestNewDailyDigestScheduler_WithInterfaces(t *testing.T) {
 	mockConfigMgr := &mockConfigProvider{}
 	mockState := &mockStateProvider{}
 	mockSlack := &mockSlackManagerWithClient{}
-	manager := New(mockSlack, mockConfigMgr)
+	manager := New(mockSlack, mockConfigMgr, &mockStore{})
 
 	scheduler := NewDailyDigestScheduler(manager, mockGitHubMgr, mockConfigMgr, mockState, mockSlack)
 

pkg/notify/format_test.go

@@ -584,7 +584,7 @@ func TestNew(t *testing.T) {
 	mockConfig := &mockConfigManager{}
 
 	// Call New - it should not panic
-	manager := New(nil, mockConfig)
+	manager := New(nil, mockConfig, &mockStore{})
 
 	if manager == nil {
 		t.Fatal("expected non-nil manager")
@@ -604,7 +604,7 @@ func TestNewDailyDigestScheduler(t *testing.T) {
 	mockConfig := &mockConfigManager{}
 	mockState := &mockStateProvider{}
 	mockSlack := &mockSlackManager{}
-	manager := New(nil, mockConfig)
+	manager := New(nil, mockConfig, &mockStore{})
 
 	scheduler := NewDailyDigestScheduler(manager, nil, mockConfig, mockState, mockSlack)