Skip to content

Commit 0b018cb

Browse files
committed
refactor: optimize order sorting and simplify order mapping in orders component
1 parent cdce7bc commit 0b018cb

File tree

1 file changed

+8
-12
lines changed

1 file changed

+8
-12
lines changed

src/routes/account/orders/index.tsx

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,8 @@ export async function loader({ request }: Route.LoaderArgs) {
1313
try {
1414
const orders = await getOrdersByUser(request);
1515

16-
orders.sort(
17-
(a, b) =>
18-
new Date(b.createdAt).getTime() - new Date(a.createdAt).getTime()
19-
);
16+
orders.sort((a, b) => b.createdAt.getTime() - a.createdAt.getTime());
17+
2018
return { orders };
2119
} catch {
2220
return {};
@@ -26,16 +24,11 @@ export async function loader({ request }: Route.LoaderArgs) {
2624
export default function Orders({ loaderData }: Route.ComponentProps) {
2725
const { orders } = loaderData;
2826

29-
const mappedOrders = orders?.map((order) => ({
30-
...order,
31-
createdAt: new Date(order.createdAt),
32-
}));
33-
3427
return (
3528
<div>
36-
{mappedOrders!.length > 0 ? (
29+
{orders!.length > 0 ? (
3730
<div className="flex flex-col gap-4">
38-
{mappedOrders!.map((order) => (
31+
{orders!.map((order) => (
3932
<div key={order.id}>
4033
<div className="rounded-lg bg-muted py-4 px-6">
4134
<dl className="flex flex-col gap-4 w-full sm:flex-row">
@@ -99,7 +92,10 @@ export default function Orders({ loaderData }: Route.ComponentProps) {
9992
<td className="py-6 pl-6">
10093
<div className="flex items-center gap-2">
10194
<div className="w-16 rounded-xl bg-muted">
102-
<img src={item.imgSrc} alt={item.title} />
95+
<img
96+
src={item.imgSrc || undefined}
97+
alt={item.title}
98+
/>
10399
</div>
104100
<div>
105101
<div className="font-medium text-foreground">

0 commit comments

Comments
 (0)