refactor: simplify loader function by removing unnecessary return statement

Author: diegotc86

src/routes/signup/index.tsx

@@ -87,8 +87,7 @@ export async function action({ request }: Route.ActionArgs) {
 }
 
 export async function loader({ request }: Route.LoaderArgs) {
-  const redirect = await redirectIfAuthenticated(request);
-  return redirect;
+  await redirectIfAuthenticated(request);
 }
 
 export default function Signup({ actionData }: Route.ComponentProps) {

src/routes/signup/signup.loader.test.ts

@@ -1,12 +1,13 @@
-import { describe, expect, it, vi, afterEach } from "vitest";
 import { redirect } from "react-router";
+import { describe, expect, it, vi, afterEach } from "vitest";
 
 import { createTestRequest } from "@/lib/utils.tests";
 import * as AuthService from "@/services/auth.service";
-import type { Route } from "./+types";
 
 import { loader } from ".";
 
+import type { Route } from "./+types";
+
 vi.mock("@/services/auth.service", () => ({
   redirectIfAuthenticated: vi.fn(),
 }));
@@ -21,18 +22,18 @@ describe("signup.loader", () => {
     const request = createTestRequest();
     const loaderArgs: Route.LoaderArgs = { request, params: {}, context: {} };
 
-    // Step 2: Mock 
+    // Step 2: Mock
     vi.mocked(AuthService.redirectIfAuthenticated).mockResolvedValueOnce(null);
 
     // Step 3: Call/Act
-    const result = await loader(loaderArgs);
+    await loader(loaderArgs);
 
     // Step 4: Verify/Assert
     expect(AuthService.redirectIfAuthenticated).toHaveBeenCalledTimes(1);
     expect(AuthService.redirectIfAuthenticated).toHaveBeenCalledWith(request);
   });
 
-  it("should return null when user is not authenticated", async () => {
+  it("should return undefined when user is not authenticated", async () => {
     // Step 1: Setup/Arrange
     const request = createTestRequest();
     const loaderArgs: Route.LoaderArgs = { request, params: {}, context: {} };
@@ -44,7 +45,7 @@ describe("signup.loader", () => {
     const result = await loader(loaderArgs);
 
     // Step 4: Verify/Assert
-    expect(result).toBeNull();
+    expect(result).toBeUndefined();
   });
 
   it("should throw redirect when user is authenticated", async () => {
@@ -54,11 +55,13 @@ describe("signup.loader", () => {
     const redirectResponse = redirect("/");
 
     // Step 2: Mock
-    vi.mocked(AuthService.redirectIfAuthenticated).mockImplementationOnce(() => {
-      throw redirectResponse;
-    });
+    vi.mocked(AuthService.redirectIfAuthenticated).mockImplementationOnce(
+      () => {
+        throw redirectResponse;
+      }
+    );
 
     // Step 3 & 4: Call and Verify
     await expect(loader(loaderArgs)).rejects.toBe(redirectResponse);
   });
-});
+});