move magic number to constant

Author: alexandre-thauvin

YChartsLib/src/main/java/co/yml/charts/ui/piechart/PieChartConstants.kt

@@ -10,4 +10,5 @@ object PieChartConstants {
     const val TOTAL_ANGLE = 360
     const val ONE_HUNDRED = 100
     const val DESCRIPTION = "Double tap to know the chart in detail"
+    const val NO_SELECTED_SLICE = -1
 }

YChartsLib/src/main/java/co/yml/charts/ui/piechart/charts/DonutPieChart.kt

@@ -31,6 +31,7 @@ import co.yml.charts.common.components.accessibility.AccessibilityBottomSheetDia
 import co.yml.charts.common.components.accessibility.SliceInfo
 import co.yml.charts.common.extensions.collectIsTalkbackEnabledAsState
 import co.yml.charts.common.model.PlotType
+import co.yml.charts.ui.piechart.PieChartConstants.NO_SELECTED_SLICE
 import co.yml.charts.ui.piechart.models.PieChartConfig
 import co.yml.charts.ui.piechart.models.PieChartData
 import co.yml.charts.ui.piechart.utils.convertTouchEventPointToAngle
@@ -39,7 +40,6 @@ import co.yml.charts.ui.piechart.utils.sweepAngles
 import kotlinx.coroutines.launch
 import kotlin.math.roundToInt
 
-
 /**
  * Compose function for Drawing Donut chart
  * @param modifier : All modifier related property
@@ -72,7 +72,7 @@ fun DonutPieChart(
     }
 
     var activePie by rememberSaveable {
-        mutableStateOf(-1)
+        mutableStateOf(NO_SELECTED_SLICE)
     }
     val accessibilitySheetState =
         rememberModalBottomSheetState(initialValue = ModalBottomSheetValue.Hidden)
@@ -92,7 +92,7 @@ fun DonutPieChart(
     ) {
         val boxModifier = if (pieChartConfig.isClickOnSliceEnabled) {
             modifier
-                .aspectRatio(1f)
+                .aspectRatio(ratio = 1f)
                 .background(pieChartConfig.backgroundColor)
                 .semantics {
                     contentDescription = pieChartConfig.accessibilityConfig.chartDescription
@@ -148,7 +148,7 @@ fun DonutPieChart(
                                     activePie = if (activePie != index)
                                         index
                                     else
-                                        -1
+                                        NO_SELECTED_SLICE
                                     onSliceClick(pieChartData.slices[index])
                                     return@detectTapGestures
                                 }

YChartsLib/src/main/java/co/yml/charts/ui/piechart/charts/PieChart.kt

@@ -38,6 +38,7 @@ import co.yml.charts.common.extensions.collectIsTalkbackEnabledAsState
 import co.yml.charts.common.extensions.getTextHeight
 import co.yml.charts.common.model.PlotType
 import co.yml.charts.ui.piechart.PieChartConstants.MINIMUM_PERCENTAGE_FOR_SLICE_LABELS
+import co.yml.charts.ui.piechart.PieChartConstants.NO_SELECTED_SLICE
 import co.yml.charts.ui.piechart.models.PieChartConfig
 import co.yml.charts.ui.piechart.models.PieChartData
 import co.yml.charts.ui.piechart.utils.convertTouchEventPointToAngle
@@ -80,7 +81,7 @@ fun PieChart(
     }
 
     var activePie by rememberSaveable {
-        mutableStateOf(-1)
+        mutableStateOf(NO_SELECTED_SLICE)
     }
     val accessibilitySheetState =
         rememberModalBottomSheetState(initialValue = ModalBottomSheetValue.Hidden)
@@ -98,7 +99,7 @@ fun PieChart(
     ) {
         val boxModifier = if (pieChartConfig.isClickOnSliceEnabled) {
             modifier
-                .aspectRatio(1f)
+                .aspectRatio(ratio = 1f)
                 .background(pieChartConfig.backgroundColor)
                 .semantics {
                     contentDescription = pieChartConfig.accessibilityConfig.chartDescription
@@ -152,7 +153,7 @@ fun PieChart(
                                     activePie = if (activePie != index)
                                         index
                                     else
-                                        -1
+                                        NO_SELECTED_SLICE
                                     onSliceClick(pieChartData.slices[index])
                                     return@detectTapGestures
                                 }