Skip to content

Commit 664c0a2

Browse files
committed
bar chart padding
1 parent fc96746 commit 664c0a2

File tree

5 files changed

+21
-11
lines changed

5 files changed

+21
-11
lines changed

YChartsLib/src/main/java/co/yml/charts/axis/XAxis.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -225,6 +225,7 @@ fun getXAxisScale(
225225
private fun XAxisPreview() {
226226
val axisData = AxisData.Builder()
227227
.labelAndAxisLinePadding(10.dp)
228+
.startDrawPadding(12.dp)
228229
.axisPosition(Gravity.BOTTOM)
229230
.axisLabelFontSize(14.sp)
230231
.labelData { index -> index.toString() }

YChartsLib/src/main/java/co/yml/charts/common/utils/DataUtils.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ object DataUtils {
5050
for (index in 0 until listSize) {
5151
list.add(
5252
Point(
53-
(start until maxRange).random().toFloat(),
53+
index.toFloat(),
5454
(start until maxRange).random().toFloat()
5555
)
5656
)
@@ -195,15 +195,15 @@ object DataUtils {
195195
val point = when (barChartType) {
196196
BarChartType.VERTICAL -> {
197197
Point(
198-
index.toFloat(),
198+
index.toFloat(),
199199
"%.2f".format(Random.nextDouble(1.0, maxRange.toDouble())).toFloat()
200200
)
201201
}
202202

203203
BarChartType.HORIZONTAL -> {
204204
Point(
205205
"%.2f".format(Random.nextDouble(1.0, maxRange.toDouble())).toFloat(),
206-
index.toFloat()
206+
"%.2f".format(Random.nextDouble(1.0, maxRange.toDouble())).toFloat()
207207
)
208208
}
209209
}

YChartsLib/src/main/java/co/yml/charts/ui/bubblechart/BubbleChart.kt

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import androidx.compose.foundation.layout.Column
88
import androidx.compose.foundation.layout.fillMaxHeight
99
import androidx.compose.foundation.layout.fillMaxSize
1010
import androidx.compose.foundation.layout.fillMaxWidth
11+
import androidx.compose.foundation.layout.padding
1112
import androidx.compose.foundation.layout.wrapContentHeight
1213
import androidx.compose.foundation.lazy.LazyColumn
1314
import androidx.compose.material.ExperimentalMaterialApi
@@ -34,6 +35,7 @@ import androidx.compose.ui.platform.LocalDensity
3435
import androidx.compose.ui.semantics.contentDescription
3536
import androidx.compose.ui.semantics.semantics
3637
import androidx.compose.ui.unit.Dp
38+
import androidx.compose.ui.unit.dp
3739
import co.yml.charts.axis.XAxis
3840
import co.yml.charts.axis.YAxis
3941
import co.yml.charts.axis.getXAxisScale
@@ -129,13 +131,6 @@ fun BubbleChart(modifier: Modifier, bubbleChartData: BubbleChartData) {
129131
containerBackgroundColor = backgroundColor,
130132
isPinchZoomEnabled = isZoomAllowed,
131133
drawXAndYAxis = { scrollOffset, xZoom ->
132-
YAxis(
133-
modifier = Modifier
134-
.fillMaxHeight()
135-
.onGloballyPositioned {
136-
columnWidth = it.size.width.toFloat()
137-
}, yAxisData = yAxisData
138-
)
139134
XAxis(xAxisData = xAxisData,
140135
modifier = Modifier
141136
.fillMaxWidth()
@@ -154,6 +149,14 @@ fun BubbleChart(modifier: Modifier, bubbleChartData: BubbleChartData) {
154149
zoomScale = xZoom,
155150
chartData = bubblePoints,
156151
axisStart = columnWidth)
152+
YAxis(
153+
modifier = Modifier
154+
.fillMaxHeight()
155+
.onGloballyPositioned {
156+
columnWidth = it.size.width.toFloat()
157+
}, yAxisData = yAxisData
158+
)
159+
157160
},
158161
onDraw = { scrollOffset, xZoom ->
159162
val yBottom = size.height - rowHeight

app/src/main/java/co/yml/ycharts/app/presentation/BarChartActivity.kt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -138,6 +138,7 @@ private fun BarchartWithSolidBars() {
138138
.steps(barData.size - 1)
139139
.bottomPadding(40.dp)
140140
.axisLabelAngle(20f)
141+
.startDrawPadding(48.dp)
141142
.labelData { index -> barData[index].label }
142143
.build()
143144
val yAxisData = AxisData.Builder()
@@ -175,6 +176,7 @@ private fun BarchartWithGradientBars() {
175176
.steps(barData.size - 1)
176177
.bottomPadding(40.dp)
177178
.axisLabelAngle(20f)
179+
.startDrawPadding(48.dp)
178180
.labelData { index -> barData[index].label }
179181
.build()
180182
val yAxisData = AxisData.Builder()
@@ -216,6 +218,7 @@ private fun BarchartWithBackgroundColor() {
216218
.axisStepSize(30.dp)
217219
.steps(barData.size - 1)
218220
.bottomPadding(40.dp)
221+
.startDrawPadding(48.dp)
219222
.axisLabelAngle(20f)
220223
.labelData { index -> barData[index].label }
221224
.backgroundColor(backgroundColor)

app/src/main/java/co/yml/ycharts/app/presentation/BubbleChartActivity.kt

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,14 +109,16 @@ private fun BubbleChartWithGrid(pointsData: List<Point>) {
109109
val steps = 5
110110
val xAxisData = AxisData.Builder()
111111
.axisStepSize(30.dp)
112+
.startDrawPadding(55.dp)
113+
.startDrawPadding(20.dp)
112114
.steps(pointsData.size - 1)
113115
.labelData { i -> i.toString() }
114116
.labelAndAxisLinePadding(15.dp)
115117
.build()
116118

117119
val yAxisData = AxisData.Builder()
118120
.steps(steps)
119-
.labelAndAxisLinePadding(20.dp)
121+
.labelAndAxisLinePadding(50.dp)
120122
.labelData { i ->
121123
// Add yMin to get the negative axis values to the scale
122124
val yMin = pointsData.minOf { it.y }
@@ -154,6 +156,7 @@ private fun SolidBubbleChart(pointsData: List<Point>) {
154156
.axisStepSize(30.dp)
155157
.steps(pointsData.size - 1)
156158
.labelData { i -> i.toString() }
159+
.startDrawPadding(55.dp)
157160
.labelAndAxisLinePadding(15.dp)
158161
.build()
159162

0 commit comments

Comments
 (0)