update titles

Author: AkYML

YChartsLib/src/main/java/co/yml/charts/ui/bubblechart/BubbleChart.kt

@@ -297,54 +297,6 @@ fun getMaxScrollDistance(
     } else 0f
 }
 
-/**
- *
- * DrawScope.drawStraightOrCubicLine extension method used for drawing a straight/cubic line for a given Point(x,y).
- * @param pointsData : List of points to be drawn on the canvas
- * @param cubicPoints1 : List of average left side values for a given Point(x,y).
- * @param cubicPoints2 : List of average right side values for a given Point(x,y).
- * @param bubbleStyle : All styles related to the path are included in [LineStyle].
- */
-fun DrawScope.drawStraightOrCubicLine(
-    pointsData: MutableList<Offset>,
-    cubicPoints1: MutableList<Offset>,
-    cubicPoints2: MutableList<Offset>,
-    bubbleStyle: BubbleStyle
-) {
-    for (i in 1 until pointsData.size) {
-        if (i % 2 == 0) {
-            with(bubbleStyle) {
-                drawCircle(
-                    color = color,
-                    alpha = alpha, colorFilter = colorFilter, blendMode = blendMode, radius = 12f
-                )
-            }
-        } else {
-            with(bubbleStyle) {
-                drawCircle(
-                    color = color,
-                    alpha = alpha, colorFilter = colorFilter, blendMode = blendMode, radius = 6f
-                )
-            }
-        }
-    }
-
-}
-//
-///**
-// *
-// * Returns the Drawstyle for the path.
-// * @param bubbleType : Type of the bubble [bubbleType]
-// * @param bubbleStyle : The style for the path [bubbleStyle]
-// */
-//private fun getDrawStyleForPath(
-//    bubbleType: BubbleType, bubbleStyle: BubbleStyle
-//): DrawStyle = if (bubbleType.isDotted) Stroke(
-//    width = bubbleStyle.width, pathEffect = PathEffect.dashPathEffect(bubbleType.intervals)
-//) else bubbleStyle.style
-//
-
-
 /**
  *
  * DrawScope.drawUnderScrollMask extension method used  for drawing a rectangular mask to make graph scrollable under the YAxis.
@@ -363,23 +315,6 @@ private fun DrawScope.drawUnderScrollMask(columnWidth: Float, paddingRight: Dp,
     )
 }
 
-/**
- *
- * DrawScope.drawShadowUnderLineAndIntersectionPoint extension method used  for drawing a
- * shadow below the line graph points and also drawing intersection points on the line graph.
- * @param cubicPath : Path used to draw the shadow
- * @param pointsData : List of the points on the Line graph.
- * @param yBottom : Offset of X-Axis starting position i.e shade to be drawn until.
- * @param line : line on which shadow & intersectionPoints has to be drawn.
- */
-fun DrawScope.drawBubble(pointsData: MutableList<Offset>, bubble: Bubble) {
-    if (bubble.intersectionPoint.isNotNull()) {
-        pointsData.forEach { offset ->
-            bubble.draw(this, offset)
-        }
-    }
-}
-
 
 /**
  *

YChartsLib/src/main/java/co/yml/charts/ui/bubblechart/model/BubbleChartData.kt

@@ -18,8 +18,8 @@ import co.yml.charts.ui.linechart.model.ShadowUnderLine
 
 /**
  *
- * LineGraphData data class that contains all params user need to define to draw a line graph.
- * @param bubblePlotData: The path to be drawn on the graph represented by a line.
+ * BubbleChartData data class that contains all params user need to define to draw a bubble chart.
+ * @param bubbles: A list of Bubbles to be drawn.
  * @param xAxisData: All the configurations related to X-Axis to be defined here in [AxisData]
  * @param yAxisData: All the configurations related to Y-Axis to be defined here in [AxisData]
  * @param isZoomAllowed: True if zoom in for all vertical graph components is allowed else false.
@@ -46,10 +46,10 @@ data class BubbleChartData(
 )
 
 /**
- * Represent a Line in the [co.yml.charts.ui.linechart]
+ * Represent a Bubble in the [co.yml.charts.ui.bubblechart]
  *
- * @param dataPoints list of points [Point] in the line
- * @param bubbleStyle Adds styling options in [LineStyle] to the line path drawn.
+ * @param center center [Point] of the bubble
+ * @param bubbleStyle Adds styling options in [BubbleStyle] to the bubble to be drawn.
  * @param intersectionPoint drawing logic to draw the point itself in [IntersectionPoint].
  * If null, the point is not drawn.
  * @param selectionHighlightPoint drawing logic to draw the highlight at the point when it is selected

YChartsLib/src/main/java/co/yml/charts/ui/bubblechart/model/BubbleStyle.kt

@@ -10,12 +10,12 @@ import androidx.compose.ui.graphics.drawscope.Stroke
 import co.yml.charts.ui.linechart.model.LineType
 
 /**
- * Handles styling for the path drawn in the line graph
+ * Handles styling for the bubble drawn in the bubble chart
  *
- * @param color Defines the color of the path or line.
- * @param width Defines the width of the path/line stroke.
- * @param alpha Defines the alpha of the path/line.
- * @param style Defines if the path/line is filled or stroke.
+ * @param color Defines the color of the bubble.
+ * @param width Defines the width of the bubble border stroke.
+ * @param alpha Defines the alpha of the bubble.
+ * @param style Defines if the bubble is filled or stroke.
  * @param colorFilter ColorFilter to apply to the [color] when drawn into the destination.
  * @param blendMode All prams related to selection popup to be added here in [SelectionHighlightPopUp]
  */

app/src/main/java/co/yml/ycharts/app/presentation/BubbleChartActivity.kt

@@ -44,7 +44,7 @@ class BubbleChartActivity : ComponentActivity() {
                     backgroundColor = YChartsTheme.colors.background,
                     topBar = {
                         AppBarWithBackButton(
-                            stringResource(id = R.string.title_line_chart),
+                            stringResource(id = R.string.bubble_chart),
                             onBackPressed = {
                                 onBackPressed()
                             })