Skip to content

Commit 7ca3eac

Browse files
committed
refactor:rename ImageGenerated to ImageGeneratedDto,remove unused import
1 parent f9989aa commit 7ca3eac

File tree

9 files changed

+9
-14
lines changed

9 files changed

+9
-14
lines changed

sample/jvm/src/main/java/co/yml/ychat/jvm/services/YChatService.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
import org.springframework.stereotype.Service;
88
import java.util.concurrent.CompletableFuture;
99
import co.yml.ychat.YChat;
10-
import co.yml.ychat.domain.model.ImageGenerated;
1110

1211
@Service
1312
public class YChatService {
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package co.yml.ychat.data.dto
22

3-
import co.yml.ychat.domain.model.ImageGenerated
3+
import co.yml.ychat.domain.model.ImageGeneratedDto
44
import kotlinx.serialization.SerialName
55
import kotlinx.serialization.Serializable
66

@@ -9,5 +9,5 @@ internal data class ImageGenerationsDto(
99
@SerialName("created")
1010
val created: Long,
1111
@SerialName("data")
12-
val data: List<ImageGenerated>,
12+
val data: List<ImageGeneratedDto>,
1313
)

ychat/src/commonMain/kotlin/co/yml/ychat/domain/mapper/ImageGenerationsMapper.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ package co.yml.ychat.domain.mapper
22

33
import co.yml.ychat.data.dto.ImageGenerationsDto
44
import co.yml.ychat.data.dto.ImageGenerationsParamsDto
5-
import co.yml.ychat.domain.model.ImageGenerated
65
import co.yml.ychat.domain.model.ImageGenerationsParams
76

87
internal fun ImageGenerationsDto.toImageGenerated(): List<String> {

ychat/src/commonMain/kotlin/co/yml/ychat/domain/model/ImageGenerated.kt renamed to ychat/src/commonMain/kotlin/co/yml/ychat/domain/model/ImageGeneratedDto.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import kotlinx.serialization.Serializable
88
* @property url The url of the image generated by the input provided.
99
*/
1010
@Serializable
11-
data class ImageGenerated(
11+
internal data class ImageGeneratedDto(
1212
@SerialName("url")
1313
val url: String,
1414
)

ychat/src/commonMain/kotlin/co/yml/ychat/domain/usecases/ImageGenerationsUseCase.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ package co.yml.ychat.domain.usecases
33
import co.yml.ychat.data.api.ChatGptApi
44
import co.yml.ychat.domain.mapper.toImageGenerated
55
import co.yml.ychat.domain.mapper.toImageGenerationsParamsDto
6-
import co.yml.ychat.domain.model.ImageGenerated
76
import co.yml.ychat.domain.model.ImageGenerationsParams
87

98
internal data class ImageGenerationsUseCase(private val chatGptApi: ChatGptApi) {

ychat/src/commonMain/kotlin/co/yml/ychat/entrypoint/features/ImageGenerations.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ package co.yml.ychat.entrypoint.features
22

33
import co.yml.ychat.YChat
44
import co.yml.ychat.data.exception.ChatGptException
5-
import co.yml.ychat.domain.model.ImageGenerated
65
import kotlin.coroutines.cancellation.CancellationException
76

87
interface ImageGenerations {

ychat/src/commonMain/kotlin/co/yml/ychat/entrypoint/impl/ImageGenerationsImpl.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package co.yml.ychat.entrypoint.impl
22

33
import co.yml.ychat.YChat
4-
import co.yml.ychat.domain.model.ImageGenerated
54
import co.yml.ychat.domain.model.ImageGenerationsParams
65
import co.yml.ychat.domain.usecases.ImageGenerationsUseCase
76
import co.yml.ychat.entrypoint.features.ImageGenerations

ychat/src/commonTest/kotlin/co/yml/ychat/domain/mapper/ImageGenerationsMapperTest.kt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package co.yml.ychat.domain.mapper
22

33
import co.yml.ychat.data.dto.ImageGenerationsDto
4-
import co.yml.ychat.domain.model.ImageGenerated
4+
import co.yml.ychat.domain.model.ImageGeneratedDto
55
import co.yml.ychat.domain.model.ImageGenerationsParams
66
import kotlin.test.Test
77
import kotlin.test.assertEquals
@@ -10,12 +10,12 @@ class ImageGenerationsMapperTest {
1010

1111
@Test
1212
fun `on convert ImageGenerationsDto to ImageGenerated`() {
13-
val listOfImageGenerated = listOf(ImageGenerated("http://url1.test"), ImageGenerated("http://url2.test"))
13+
val listOfImageGeneratedDto = listOf(ImageGeneratedDto("http://url1.test"), ImageGeneratedDto("http://url2.test"))
1414
val imageGenerationsDto = ImageGenerationsDto(
1515
created = 12345,
16-
data = listOfImageGenerated
16+
data = listOfImageGeneratedDto
1717
)
18-
assertEquals(listOfImageGenerated, imageGenerationsDto.toImageGenerated())
18+
assertEquals(listOfImageGeneratedDto, imageGenerationsDto.toImageGenerated())
1919
}
2020

2121
@Test

ychat/src/commonTest/kotlin/co/yml/ychat/domain/usecases/ImageGenerationsUseCaseTest.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import co.yml.ychat.data.api.ChatGptApi
44
import co.yml.ychat.data.dto.ImageGenerationsDto
55
import co.yml.ychat.data.exception.ChatGptException
66
import co.yml.ychat.data.infrastructure.ApiResult
7-
import co.yml.ychat.domain.model.ImageGenerated
7+
import co.yml.ychat.domain.model.ImageGeneratedDto
88
import co.yml.ychat.domain.model.ImageGenerationsParams
99
import io.mockk.coEvery
1010
import io.mockk.mockk
@@ -59,7 +59,7 @@ class ImageGenerationsUseCaseTest {
5959
private fun buildImageGenerationsDto(url: String): ImageGenerationsDto {
6060
return ImageGenerationsDto(
6161
created = 12345,
62-
data = listOf(ImageGenerated(url))
62+
data = listOf(ImageGeneratedDto(url))
6363
)
6464
}
6565
}

0 commit comments

Comments
 (0)