Code refactoring.

Renamed request class.
Moved url to routes class.

Author: deepakyml

app/src/main/java/ytemplate/android/data/MyPostRepository.kt

@@ -6,7 +6,7 @@ import ytemplate.android.data.datasource.LocalPostDataSource
 import ytemplate.android.data.datasource.RemotePostDataSource
 import ytemplate.android.data.model.PostRequest
 import ytemplate.android.database.model.Post
-import ytemplate.android.infra.AppRequest
+import ytemplate.android.infra.AppResult
 import javax.inject.Inject
 
 /**
@@ -26,7 +26,7 @@ interface MyPostRepository {
     /**
      * Fetch all post data from remote server and push to the local database.
      */
-    suspend fun fetchAllPost(): AppRequest<List<Post>?>
+    suspend fun fetchAllPost(): AppResult<List<Post>?>
 }
 
 /**
@@ -48,9 +48,9 @@ class MyPostRepositoryImpl @Inject constructor(
         remotePostDataSource.addPost(post)
     }
 
-    override suspend fun fetchAllPost(): AppRequest<List<Post>?> {
+    override suspend fun fetchAllPost(): AppResult<List<Post>?> {
         val remoteData = remotePostDataSource.fetchAllPost()
-        if (remoteData is AppRequest.Success) {
+        if (remoteData is AppResult.Success) {
             val dataList = remoteData.data!!.map {
                 Post(
                     id = it.id,
@@ -63,9 +63,9 @@ class MyPostRepositoryImpl @Inject constructor(
             localPostDataSource.addAll(
                 dataList
             )
-            return AppRequest.Success(dataList)
+            return AppResult.Success(dataList)
         } else {
-            return AppRequest.Error((remoteData as AppRequest.Error).exception)
+            return AppResult.Error((remoteData as AppResult.Error).exception)
         }
     }
 }

app/src/main/java/ytemplate/android/data/datasource/RemotePostDataSource.kt

@@ -1,11 +1,13 @@
 package ytemplate.android.data.datasource
 
+
 import io.ktor.client.*
 import io.ktor.client.call.*
 import io.ktor.client.request.*
 import ytemplate.android.data.model.PostDTO
 import ytemplate.android.data.model.PostRequest
-import ytemplate.android.infra.AppRequest
+import ytemplate.android.infra.AppResult
+import ytemplate.android.infra.Routes
 import javax.inject.Inject
 
 /**
@@ -15,29 +17,29 @@ interface RemotePostDataSource {
     /**
      * Fetch all post, will fetch all data from remote server
      */
-    suspend fun fetchAllPost(): AppRequest<List<PostDTO>?>
+    suspend fun fetchAllPost(): AppResult<List<PostDTO>?>
 
     /**
      * Add post will add post data to remote server.
      */
-    suspend fun addPost(postRequest: PostRequest): AppRequest<Boolean>
+    suspend fun addPost(postRequest: PostRequest): AppResult<Boolean>
 }
 
 class RemotePostDataSourceImpl @Inject constructor(private val httpClient: HttpClient) :
     RemotePostDataSource {
-    override suspend fun fetchAllPost(): AppRequest<List<PostDTO>?> {
+    override suspend fun fetchAllPost(): AppResult<List<PostDTO>?> {
         val data = try {
             val data: List<PostDTO> = httpClient.get {
-                url("https://jsonplaceholder.typicode.com/posts")
+                url(Routes.GET_POST)
             }.body()
-            AppRequest.Success(data)
+            AppResult.Success(data)
         } catch (exc: Exception) {
-            AppRequest.Error(exc)
+            AppResult.Error(exc)
         }
         return data
     }
 
-    override suspend fun addPost(postRequest: PostRequest): AppRequest<Boolean> {
-        return AppRequest.Loading
+    override suspend fun addPost(postRequest: PostRequest): AppResult<Boolean> {
+        return AppResult.Loading
     }
 }

app/src/main/java/ytemplate/android/infra/ApiRequest.kt

@@ -8,33 +8,33 @@ import kotlinx.coroutines.flow.onStart
 /**
  * AppRequest is generic interface for maintaining every request status.
  */
-sealed interface AppRequest<out T> {
+sealed interface AppResult<out T> {
     /**
      * For the success request
      * @param data: Original data
      */
-    data class Success<T>(val data: T) : AppRequest<T>
+    data class Success<T>(val data: T) : AppResult<T>
 
     /**
      * For the failure request
      * @param exception: Exception
      */
-    data class Error(val exception: Throwable? = null) : AppRequest<Nothing>
+    data class Error(val exception: Throwable? = null) : AppResult<Nothing>
 
     /**
      * For maintaining the loading state,
      */
-    object Loading : AppRequest<Nothing>
+    object Loading : AppResult<Nothing>
 }
 
 /**
  * Extension for converting to flow to result
  */
-fun <T> Flow<T>.asResult(): Flow<AppRequest<T>> {
+fun <T> Flow<T>.asResult(): Flow<AppResult<T>> {
     return this
-        .map<T, AppRequest<T>> {
-            AppRequest.Success(it)
+        .map<T, AppResult<T>> {
+            AppResult.Success(it)
         }
-        .onStart { emit(AppRequest.Loading) }
-        .catch { emit(AppRequest.Error(it)) }
+        .onStart { emit(AppResult.Loading) }
+        .catch { emit(AppResult.Error(it)) }
 }

app/src/main/java/ytemplate/android/infra/Routes.kt

@@ -4,5 +4,5 @@ package ytemplate.android.infra
  * Routes class, for maintaining the all routes
  */
 object Routes {
-    private const val BASE_URL = ""
+    const val GET_POST = "https://jsonplaceholder.typicode.com/posts"
 }

app/src/main/java/ytemplate/android/remote/RemoteModule.kt

@@ -15,10 +15,15 @@ import javax.inject.Singleton
 /**
  * RemoteModule, for maintaining the all network related DI operations.
  */
+
+private const val CONNECTION_TIMEOUT = 60L
+private const val CONNECTION_READ_TIME_OUT = 60L
+private const val CONNECTION_WRITE_TIME_OUT = 60L
 @Module
 @InstallIn(SingletonComponent::class)
 class RemoteModule {
 
+
     /**
      * Providing the HttpClient instance for the remote communication.
      */
@@ -36,9 +41,9 @@ class RemoteModule {
 
                 config {
                     followRedirects(true)
-                    connectTimeout(60L, TimeUnit.SECONDS)
-                    readTimeout(60L, TimeUnit.SECONDS)
-                    writeTimeout(60L, TimeUnit.SECONDS)
+                    connectTimeout(CONNECTION_TIMEOUT, TimeUnit.SECONDS)
+                    readTimeout(CONNECTION_READ_TIME_OUT, TimeUnit.SECONDS)
+                    writeTimeout(CONNECTION_WRITE_TIME_OUT, TimeUnit.SECONDS)
                 }
                 //addInterceptor()
             }

app/src/test/java/ytemplate/android/data/MyPostRepositoryImplTest.kt

@@ -18,7 +18,7 @@ import org.junit.Before
 import org.junit.Test
 import ytemplate.android.data.datasource.LocalPostDataSourceImpl
 import ytemplate.android.data.datasource.RemotePostDataSourceImpl
-import ytemplate.android.infra.AppRequest
+import ytemplate.android.infra.AppResult
 
 class MyPostRepositoryImplTest {
     private val remotePostDataMock = RemotePostDataMock()
@@ -42,7 +42,7 @@ class MyPostRepositoryImplTest {
                 localPostDataSource = LocalPostDataSourceImpl(fakePostDao)
             )
         val data = repository.fetchAllPost()
-        assert(data is AppRequest.Success)
+        assert(data is AppResult.Success)
     }
 
     @OptIn(ExperimentalCoroutinesApi::class)