Skip to content

Commit 9223bac

Browse files
committed
chore: try out emsdk 3.1.72
1 parent 824c502 commit 9223bac

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

.github/actions/prepare-build-env/action.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ runs:
99
run: |
1010
git clone https://github.com/emscripten-core/emsdk.git
1111
cd emsdk
12-
./emsdk install 3.1.74
13-
./emsdk activate 3.1.74
12+
./emsdk install 3.1.72
13+
./emsdk activate 3.1.72
1414
source ./emsdk_env.sh
1515
# Export emsdk environment variables
1616
echo "PATH=$PATH" >> $GITHUB_ENV

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ git pull --recurse-submodules
107107

108108
Start the build container with the following command to ensure the filesystem permissions for newly created files are correct.
109109
```sh
110-
docker run -it --rm -v $(pwd):/src -v /etc/passwd:/etc/passwd --user "$(id -u):$(id -g)" --name mapserver-wasm emscripten/emsdk:3.1.74 bash
110+
docker run -it --rm -v $(pwd):/src -v /etc/passwd:/etc/passwd --user "$(id -u):$(id -g)" --name mapserver-wasm emscripten/emsdk:3.1.72 bash
111111
```
112112
And execute in a second terminal the following command to install the missing build depedencies as root user.
113113
```sh

test/wasm_package_size.test.mjs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@ import fs from 'fs'
22

33
const THRESHOLD = 10240
44

5-
test('mapserver.wasm file should not be larger than ~2.9MB with brotli compression', () => {
5+
test('mapserver.wasm file should not be larger than ~3.1MB with brotli compression', () => {
66
const stats = fs.statSync('./dist/mapserver.wasm.br')
77

8-
expect(stats.size).toBeLessThanOrEqual(2988783 + THRESHOLD) // we should avoid getting bigger than that
8+
expect(stats.size).toBeLessThanOrEqual(3045550 + THRESHOLD) // we should avoid getting bigger than that
99
expect(stats.size).toBeGreaterThan(2000000) // if we got to small, maybe something is wrong?
1010
})

0 commit comments

Comments
 (0)