fix(support): Fix RScriptAsync not executing evalAsync when executing evalShaAsync fails

Author: codeba

redis-keeper-support/src/main/java/org/codeba/redis/keeper/support/DefaultRedissonTemplate.java

@@ -2118,13 +2118,13 @@ public CompletableFuture<Void> setObjectEXAsync(String key, Object value, Durati
 
     @Override
     public Map<String, Object> mGet(String... keys) {
-        log("mGet", keys);
+        log("mGet", Arrays.toString(keys));
         return kString.mGet(keys);
     }
 
     @Override
     public CompletableFuture<Map<String, Object>> mGetAsync(String... keys) {
-        log("mGetAsync", keys);
+        log("mGetAsync", Arrays.toString(keys));
         return kString.mGetAsync(keys);
     }
 
@@ -2334,13 +2334,13 @@ public CompletableFuture<Object> executeScriptAsync(String script, List<Object>
 
     @Override
     public long exists(String... keys) {
-        log("exists", keys);
+        log("exists", Arrays.toString(keys));
         return kGeneric.exists(keys);
     }
 
     @Override
     public CompletableFuture<Long> existsAsync(String... keys) {
-        log("existsAsync", keys);
+        log("existsAsync", Arrays.toString(keys));
         return kGeneric.existsAsync(keys);
     }
 
@@ -2370,25 +2370,25 @@ public CompletableFuture<Boolean> expireAtAsync(String key, long timestamp) {
 
     @Override
     public long del(String... keys) {
-        log("del", keys);
+        log("del", Arrays.toString(keys));
         return kGeneric.del(keys);
     }
 
     @Override
     public CompletableFuture<Long> delAsync(String... keys) {
-        log("delAsync", keys);
+        log("delAsync", Arrays.toString(keys));
         return kGeneric.delAsync(keys);
     }
 
     @Override
     public long unlink(String... keys) {
-        log("unlink", keys);
+        log("unlink", Arrays.toString(keys));
         return kGeneric.unlink(keys);
     }
 
     @Override
     public CompletableFuture<Long> unlinkAsync(String... keys) {
-        log("unlinkAsync", keys);
+        log("unlinkAsync", Arrays.toString(keys));
         return kGeneric.unlinkAsync(keys).toCompletableFuture();
     }
 

redis-keeper-support/src/main/java/org/codeba/redis/keeper/support/KRedissonScriptAsync.java

@@ -59,11 +59,16 @@ public CompletableFuture<Object> executeScriptAsync(String script, List<Object>
         /* evalSha: 此处必须加上 StringCodec.INSTANCE */
         final RScriptAsync rScript = getRScript();
         String shaDigests = sha1DigestAsHex(script);
-        try {
-            return rScript.evalShaAsync(RScript.Mode.READ_WRITE, shaDigests, RScript.ReturnType.VALUE, keys, values).toCompletableFuture();
-        } catch (RedisException e) {
-            return rScript.evalAsync(RScript.Mode.READ_WRITE, script, RScript.ReturnType.VALUE, keys, values).toCompletableFuture();
-        }
+        return rScript.evalShaAsync(RScript.Mode.READ_WRITE, shaDigests, RScript.ReturnType.VALUE, keys, values)
+                .handle((result, error) -> {
+                    if (error instanceof RedisException) {
+                        return rScript.evalAsync(RScript.Mode.READ_WRITE, script, RScript.ReturnType.VALUE, keys, values)
+                                .toCompletableFuture()
+                                .join();
+                    }
+                    return result;
+                })
+                .toCompletableFuture();
     }
 
     /**

redis-keeper-support/src/main/java/org/codeba/redis/keeper/support/KRedissonStringAsync.java

@@ -67,7 +67,7 @@ public CompletableFuture<Object> getAsync(String key) {
         return getRBucket(key, getCodec()).getAsync()
                 .handle((object, throwable) -> {
                     if (null != throwable) {
-                        return getRBucket(key).getAsync().join();
+                        return getRBucket(key).getAsync().toCompletableFuture().join();
                     }
                     return object;
                 }).toCompletableFuture();
@@ -78,7 +78,7 @@ public CompletableFuture<Object> getObjectAsync(String key) {
         return getRBucket(key).getAsync()
                 .handle((object, throwable) -> {
                     if (null != throwable) {
-                        return getRBucket(key, getCodec()).getAsync().join();
+                        return getRBucket(key, getCodec()).getAsync().toCompletableFuture().join();
                     }
                     return object;
                 }).toCompletableFuture();

redis-keeper-support/src/test/java/org/codeba/redis/keeper/support/AppTest.java

@@ -35,6 +35,7 @@
 import org.codeba.redis.keeper.core.KStringAsync;
 import org.codeba.redis.keeper.core.KZSetAsync;
 import org.codeba.redis.keeper.core.KeyType;
+import org.redisson.api.RedissonClient;
 import org.redisson.codec.JsonJacksonCodec;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
@@ -4799,7 +4800,7 @@ public void testExecuteScript() throws NoSuchAlgorithmException {
      * @throws NoSuchAlgorithmException the no such algorithm exception
      */
     public void testExecuteScriptAsync() throws NoSuchAlgorithmException {
-        String saddNxLua = "local added = {};" +
+        String saddNxLua = "local pp = {};local added = {};" +
                 "for i, v in ipairs(ARGV) do" +
                 "    local addResult = redis.call('SADD', KEYS[1], ARGV[i]);" +
                 "    if( addResult < 1 ) then" +
@@ -5090,4 +5091,20 @@ public void testTryAcquire2Async() {
         CACHE_TEMPLATE.del(key, "{" + key + "}:permits", "{" + key + "}:value");
     }
 
+    public void testDefaultRedissonTemplate() {
+        String key = "my-key-adapter";
+        Object value = KeyType.LIST;
+
+        DefaultRedissonTemplate defaultRedissonTemplate = (DefaultRedissonTemplate) CACHE_TEMPLATE;
+        final RedissonClient redissonClient = defaultRedissonTemplate.getRedissonClient();
+        final boolean add = redissonClient.getScoredSortedSet(key).add(1, value);
+        assertTrue(add);
+
+        final boolean zRem = CACHE_TEMPLATE.zRem(key, Collections.singletonList(value));
+        assertFalse(zRem);
+
+        CACHE_TEMPLATE.del(key);
+
+    }
+
 }