WIP

RhysLees · RhysLees · commit 1f6fb9a1402d · 2025-02-28T22:22:02.000Z
diff --git a/.phpunit.cache/test-results b/.phpunit.cache/test-results
@@ -1 +1 @@
-{"version":"pest_2.34.4","defects":{"P\\Tests\\Requests\\CreateSingleTicketRequestTest::__pest_evaluable_it_can_get_create_a_single_ticket":8,"P\\Tests\\Requests\\AllTicketsRequestTest::__pest_evaluable_it_can_get_all_tickets":8},"times":{"P\\Tests\\Requests\\CreateSingleTicketRequestTest::__pest_evaluable_it_can_get_create_a_single_ticket":0.012,"P\\Tests\\Requests\\AllTicketsRequestTest::__pest_evaluable_it_can_get_all_tickets":0.004,"P\\Tests\\Requests\\SingleTicketRequestTest::__pest_evaluable_it_can_get_a_single_ticket":0.002,"P\\Tests\\Core\\ArchTest::__pest_evaluable_it_will_not_use_any_debug_function":0.036,"P\\Tests\\Requests\\CountTicketsRequestTest::__pest_evaluable_it_can_count_all_tickets":0.001,"P\\Tests\\Connectors\\ZendeskConnectorTest::__pest_evaluable_it_will_not_throw_an_exception_if_a_subdomain_is_set":0,"P\\Tests\\Connectors\\ZendeskConnectorTest::__pest_evaluable_it_will_compile_the_correct_authentication_string_for_basic_method":0,"P\\Tests\\Connectors\\ZendeskConnectorTest::__pest_evaluable_it_will_not_throw_an_exception_if_an_auth_method_valid":0,"P\\Tests\\Connectors\\ZendeskConnectorTest::__pest_evaluable_it_will_throw_an_exception_if_a_token_is_not_provided_when_using_the_token_method":0,"P\\Tests\\Connectors\\ZendeskConnectorTest::__pest_evaluable_it_will_not_throw_an_exception_if_a_token_is_provided_when_using_the_token_method":0,"P\\Tests\\Connectors\\ZendeskConnectorTest::__pest_evaluable_it_will_return_the_base_path":0,"P\\Tests\\Connectors\\ZendeskConnectorTest::__pest_evaluable_it_will_throw_an_exception_if_a_subdomain_is_not_set":0,"P\\Tests\\Connectors\\ZendeskConnectorTest::__pest_evaluable_it_will_throw_an_exception_if_an_auth_method_is_not_set":0,"P\\Tests\\Connectors\\ZendeskConnectorTest::__pest_evaluable_it_will_compile_the_correct_authentication_string_for_token_method":0,"P\\Tests\\Connectors\\ZendeskConnectorTest::__pest_evaluable_it_will_not_throw_an_exception_if_a_password_is_provided_when_using_the_password_method":0,"P\\Tests\\Connectors\\ZendeskConnectorTest::__pest_evaluable_it_will_throw_and_authentication_error_when_details_are_incorrect":0.001,"P\\Tests\\Connectors\\ZendeskConnectorTest::__pest_evaluable_it_will_throw_an_exception_if_a_password_is_not_provided_when_using_the_basic_method":0,"P\\Tests\\Connectors\\ZendeskConnectorTest::__pest_evaluable_it_will_throw_an_exception_if_an_auth_method_invalid":0,"P\\Tests\\Requests\\CreateAttachmentRequestTest::__pest_evaluable_it_can_create_an_attachment":0.001}}
+{"version":"pest_2.36.0","defects":[],"times":{"P\\Tests\\Requests\\SingleTicketRequestTest::__pest_evaluable_it_can_get_a_single_ticket":0.001,"P\\Tests\\Requests\\CreateSingleTicketRequestTest::__pest_evaluable_it_can_get_create_a_single_ticket":0.046,"P\\Tests\\Core\\ArchTest::__pest_evaluable_it_will_not_use_any_debug_function":0.059,"P\\Tests\\Requests\\CountTicketsRequestTest::__pest_evaluable_it_can_count_all_tickets":0.001,"P\\Tests\\Requests\\AllTicketsRequestTest::__pest_evaluable_it_can_get_all_tickets":0.006,"P\\Tests\\Connectors\\ZendeskConnectorTest::__pest_evaluable_it_will_compile_the_correct_authentication_string_for_token_method":0,"P\\Tests\\Connectors\\ZendeskConnectorTest::__pest_evaluable_it_will_compile_the_correct_authentication_string_for_basic_method":0,"P\\Tests\\Connectors\\ZendeskConnectorTest::__pest_evaluable_it_will_not_throw_an_exception_if_a_subdomain_is_set":0,"P\\Tests\\Connectors\\ZendeskConnectorTest::__pest_evaluable_it_will_not_throw_an_exception_if_an_auth_method_valid":0,"P\\Tests\\Connectors\\ZendeskConnectorTest::__pest_evaluable_it_will_return_the_base_path":0,"P\\Tests\\Connectors\\ZendeskConnectorTest::__pest_evaluable_it_will_throw_an_exception_if_an_auth_method_is_not_set":0,"P\\Tests\\Connectors\\ZendeskConnectorTest::__pest_evaluable_it_will_throw_and_authentication_error_when_details_are_incorrect":0.001,"P\\Tests\\Connectors\\ZendeskConnectorTest::__pest_evaluable_it_will_throw_an_exception_if_a_token_is_not_provided_when_using_the_token_method":0,"P\\Tests\\Connectors\\ZendeskConnectorTest::__pest_evaluable_it_will_throw_an_exception_if_a_subdomain_is_not_set":0,"P\\Tests\\Connectors\\ZendeskConnectorTest::__pest_evaluable_it_will_not_throw_an_exception_if_a_password_is_provided_when_using_the_password_method":0,"P\\Tests\\Connectors\\ZendeskConnectorTest::__pest_evaluable_it_will_not_throw_an_exception_if_a_token_is_provided_when_using_the_token_method":0,"P\\Tests\\Connectors\\ZendeskConnectorTest::__pest_evaluable_it_will_throw_an_exception_if_an_auth_method_invalid":0,"P\\Tests\\Connectors\\ZendeskConnectorTest::__pest_evaluable_it_will_throw_an_exception_if_a_password_is_not_provided_when_using_the_basic_method":0,"P\\Tests\\Requests\\CreateAttachmentRequestTest::__pest_evaluable_it_can_create_an_attachment":0.001}}
diff --git a/composer.json b/composer.json
@@ -29,7 +29,7 @@
     "saloonphp/cache-plugin": "^3.0",
     "saloonphp/laravel-plugin": "^3.2",
     "saloonphp/saloon": "^3.4",
-    "spatie/laravel-data": "^4.4.0",
+    "spatie/laravel-data": "^4.13.1",
     "spatie/laravel-package-tools": "^1.16"
   },
   "require-dev": {
diff --git a/phpstan.neon.dist b/phpstan.neon.dist
@@ -9,5 +9,4 @@ parameters:
     tmpDir: build/phpstan
     checkOctaneCompatibility: true
     checkModelProperties: true
-    checkMissingIterableValueType: false
 
diff --git a/src/Dto/Tickets/AllTicketsDTO.php b/src/Dto/Tickets/AllTicketsDTO.php
@@ -14,8 +14,7 @@ public function __construct(
         public int $count,
         public ?string $next_page_url,
         public ?string $previous_page_url,
-    ) {
-    }
+    ) {}
 
     public static function fromResponse(Response $response): self
     {
diff --git a/src/Dto/Tickets/Attachments/AttachmentDTO.php b/src/Dto/Tickets/Attachments/AttachmentDTO.php
@@ -23,8 +23,7 @@ public function __construct(
         public ?array $thumbnails,
         public ?string $url,
         public ?string $width,
-    ) {
-    }
+    ) {}
 
     public static function fromArray(array $data): self
     {
diff --git a/src/Dto/Tickets/Attachments/ThumbnailDTO.php b/src/Dto/Tickets/Attachments/ThumbnailDTO.php
@@ -22,8 +22,7 @@ public function __construct(
         public ?int $size,
         public ?string $url,
         public ?string $width,
-    ) {
-    }
+    ) {}
 
     public static function fromArray(array $data): self
     {
diff --git a/src/Dto/Tickets/Attachments/UploadDTO.php b/src/Dto/Tickets/Attachments/UploadDTO.php
@@ -14,8 +14,7 @@ public function __construct(
         public Carbon $expires_at,
         public array $attachments,
         public AttachmentDTO $attachment,
-    ) {
-    }
+    ) {}
 
     public static function fromResponse(Response $response): self
     {
diff --git a/src/Dto/Tickets/Comments/CommentDTO.php b/src/Dto/Tickets/Comments/CommentDTO.php
@@ -22,8 +22,7 @@ public function __construct(
         public ?string $type,
         public ?array $uploads,
         public ?array $via,
-    ) {
-    }
+    ) {}
 
     public static function fromArray(array $data): self
     {
diff --git a/src/Dto/Tickets/CountTicketsDTO.php b/src/Dto/Tickets/CountTicketsDTO.php
@@ -12,8 +12,7 @@ class CountTicketsDTO extends Data
     public function __construct(
         public ?int $value,
         public ?Carbon $refreshed_at,
-    ) {
-    }
+    ) {}
 
     public static function fromResponse(Response $response): self
     {
diff --git a/src/Dto/Tickets/SingleTicketDTO.php b/src/Dto/Tickets/SingleTicketDTO.php
@@ -64,8 +64,7 @@ public function __construct(
         public ?int $via_followup_source_id,
         public ?int $via_id,
         public ?array $voice_comment,
-    ) {
-    }
+    ) {}
 
     public static function fromResponse(Response $response): self
     {
diff --git a/src/Requests/CreateAttachmentRequest.php b/src/Requests/CreateAttachmentRequest.php
@@ -25,8 +25,7 @@ public function __construct(
         protected string $fileName,
         protected string $mimeType,
         protected mixed $stream,
-    ) {
-    }
+    ) {}
 
     protected function defaultHeaders(): array
     {
diff --git a/src/Requests/CreateSingleTicketRequest.php b/src/Requests/CreateSingleTicketRequest.php
@@ -23,8 +23,7 @@ public function resolveEndpoint(): string
 
     public function __construct(
         readonly protected array|SingleTicketDTO $createTicket
-    ) {
-    }
+    ) {}
 
     protected function defaultBody(): array
     {
diff --git a/src/Zendesk.php b/src/Zendesk.php
@@ -2,6 +2,4 @@
 
 namespace CodebarAg\Zendesk;
 
-class Zendesk
-{
-}
+class Zendesk {}
diff --git a/tests/Requests/AllTicketsRequestTest.php b/tests/Requests/AllTicketsRequestTest.php
@@ -14,7 +14,7 @@
     $connector = new ZendeskConnector;
     $connector->withMockClient($mockClient);
 
-    $response = $connector->send(new AllTicketsRequest());
+    $response = $connector->send(new AllTicketsRequest);
 
     $mockClient->assertSent(AllTicketsRequest::class);
 
@@ -23,7 +23,7 @@
         ->and($response->dto()->tickets[0]['subject'])->toBe('My printer is on fire!')
         ->and($response->dto()->tickets[0]['raw_subject'])->toBe('My printer is on fire!')
         ->and($response->dto()->tickets[0]['description'])->toBe('The smoke is very colorful.')
-        ->and($response->dto()->tickets[0]['priority'])->toBe(TicketPriority::URGENT)
+        ->and($response->dto()->tickets[0]['priority'])->toBe(TicketPriority::URGENT->value)
         ->and($response->dto()->tickets[0]['custom_fields'][1]['id'])->toBe(10350920893084)
         ->and($response->dto()->tickets[0]['custom_fields'][1]['value'])->toBe('Check field works')
         ->and($response->dto()->tickets[0]['custom_fields'][2]['id'])->toBe(10350942541980)
diff --git a/tests/Requests/CountTicketsRequestTest.php b/tests/Requests/CountTicketsRequestTest.php
@@ -13,7 +13,7 @@
     $connector = new ZendeskConnector;
     $connector->withMockClient($mockClient);
 
-    $response = $connector->send(new CountTicketsRequest());
+    $response = $connector->send(new CountTicketsRequest);
 
     $mockClient->assertSent(CountTicketsRequest::class);
 
diff --git a/tests/TestCase.php b/tests/TestCase.php
@@ -5,6 +5,7 @@
 use CodebarAg\Zendesk\ZendeskServiceProvider;
 use Illuminate\Database\Eloquent\Factories\Factory;
 use Orchestra\Testbench\TestCase as Orchestra;
+use Spatie\LaravelData\LaravelDataServiceProvider;
 use Spatie\LaravelData\Support\DataConfig;
 
 class TestCase extends Orchestra
@@ -27,6 +28,7 @@ protected function getPackageProviders($app): array
     {
         return [
             ZendeskServiceProvider::class,
+            LaravelDataServiceProvider::class,
         ];
     }
 

Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		-{"version":"pest_2.34.4","defects":{"P\\Tests\\Requests\\CreateSingleTicketRequestTest::__pest_evaluable_it_can_get_create_a_single_ticket":8,"P\\Tests\\Requests\\AllTicketsRequestTest::__pest_evaluable_it_can_get_all_tickets":8},"times":{"P\\Tests\\Requests\\CreateSingleTicketRequestTest::__pest_evaluable_it_can_get_create_a_single_ticket":0.012,"P\\Tests\\Requests\\AllTicketsRequestTest::__pest_evaluable_it_can_get_all_tickets":0.004,"P\\Tests\\Requests\\SingleTicketRequestTest::__pest_evaluable_it_can_get_a_single_ticket":0.002,"P\\Tests\\Core\\ArchTest::__pest_evaluable_it_will_not_use_any_debug_function":0.036,"P\\Tests\\Requests\\CountTicketsRequestTest::__pest_evaluable_it_can_count_all_tickets":0.001,"P\\Tests\\Connectors\\ZendeskConnectorTest::__pest_evaluable_it_will_not_throw_an_exception_if_a_subdomain_is_set":0,"P\\Tests\\Connectors\\ZendeskConnectorTest::__pest_evaluable_it_will_compile_the_correct_authentication_string_for_basic_method":0,"P\\Tests\\Connectors\\ZendeskConnectorTest::__pest_evaluable_it_will_not_throw_an_exception_if_an_auth_method_valid":0,"P\\Tests\\Connectors\\ZendeskConnectorTest::__pest_evaluable_it_will_throw_an_exception_if_a_token_is_not_provided_when_using_the_token_method":0,"P\\Tests\\Connectors\\ZendeskConnectorTest::__pest_evaluable_it_will_not_throw_an_exception_if_a_token_is_provided_when_using_the_token_method":0,"P\\Tests\\Connectors\\ZendeskConnectorTest::__pest_evaluable_it_will_return_the_base_path":0,"P\\Tests\\Connectors\\ZendeskConnectorTest::__pest_evaluable_it_will_throw_an_exception_if_a_subdomain_is_not_set":0,"P\\Tests\\Connectors\\ZendeskConnectorTest::__pest_evaluable_it_will_throw_an_exception_if_an_auth_method_is_not_set":0,"P\\Tests\\Connectors\\ZendeskConnectorTest::__pest_evaluable_it_will_compile_the_correct_authentication_string_for_token_method":0,"P\\Tests\\Connectors\\ZendeskConnectorTest::__pest_evaluable_it_will_not_throw_an_exception_if_a_password_is_provided_when_using_the_password_method":0,"P\\Tests\\Connectors\\ZendeskConnectorTest::__pest_evaluable_it_will_throw_and_authentication_error_when_details_are_incorrect":0.001,"P\\Tests\\Connectors\\ZendeskConnectorTest::__pest_evaluable_it_will_throw_an_exception_if_a_password_is_not_provided_when_using_the_basic_method":0,"P\\Tests\\Connectors\\ZendeskConnectorTest::__pest_evaluable_it_will_throw_an_exception_if_an_auth_method_invalid":0,"P\\Tests\\Requests\\CreateAttachmentRequestTest::__pest_evaluable_it_can_create_an_attachment":0.001}}
	`1`	+{"version":"pest_2.36.0","defects":[],"times":{"P\\Tests\\Requests\\SingleTicketRequestTest::__pest_evaluable_it_can_get_a_single_ticket":0.001,"P\\Tests\\Requests\\CreateSingleTicketRequestTest::__pest_evaluable_it_can_get_create_a_single_ticket":0.046,"P\\Tests\\Core\\ArchTest::__pest_evaluable_it_will_not_use_any_debug_function":0.059,"P\\Tests\\Requests\\CountTicketsRequestTest::__pest_evaluable_it_can_count_all_tickets":0.001,"P\\Tests\\Requests\\AllTicketsRequestTest::__pest_evaluable_it_can_get_all_tickets":0.006,"P\\Tests\\Connectors\\ZendeskConnectorTest::__pest_evaluable_it_will_compile_the_correct_authentication_string_for_token_method":0,"P\\Tests\\Connectors\\ZendeskConnectorTest::__pest_evaluable_it_will_compile_the_correct_authentication_string_for_basic_method":0,"P\\Tests\\Connectors\\ZendeskConnectorTest::__pest_evaluable_it_will_not_throw_an_exception_if_a_subdomain_is_set":0,"P\\Tests\\Connectors\\ZendeskConnectorTest::__pest_evaluable_it_will_not_throw_an_exception_if_an_auth_method_valid":0,"P\\Tests\\Connectors\\ZendeskConnectorTest::__pest_evaluable_it_will_return_the_base_path":0,"P\\Tests\\Connectors\\ZendeskConnectorTest::__pest_evaluable_it_will_throw_an_exception_if_an_auth_method_is_not_set":0,"P\\Tests\\Connectors\\ZendeskConnectorTest::__pest_evaluable_it_will_throw_and_authentication_error_when_details_are_incorrect":0.001,"P\\Tests\\Connectors\\ZendeskConnectorTest::__pest_evaluable_it_will_throw_an_exception_if_a_token_is_not_provided_when_using_the_token_method":0,"P\\Tests\\Connectors\\ZendeskConnectorTest::__pest_evaluable_it_will_throw_an_exception_if_a_subdomain_is_not_set":0,"P\\Tests\\Connectors\\ZendeskConnectorTest::__pest_evaluable_it_will_not_throw_an_exception_if_a_password_is_provided_when_using_the_password_method":0,"P\\Tests\\Connectors\\ZendeskConnectorTest::__pest_evaluable_it_will_not_throw_an_exception_if_a_token_is_provided_when_using_the_token_method":0,"P\\Tests\\Connectors\\ZendeskConnectorTest::__pest_evaluable_it_will_throw_an_exception_if_an_auth_method_invalid":0,"P\\Tests\\Connectors\\ZendeskConnectorTest::__pest_evaluable_it_will_throw_an_exception_if_a_password_is_not_provided_when_using_the_basic_method":0,"P\\Tests\\Requests\\CreateAttachmentRequestTest::__pest_evaluable_it_can_create_an_attachment":0.001}}
Original file line number	Diff line number	Diff line change
`@@ -14,8 +14,7 @@ public function __construct(`
`14`	`14`	`public int $count,`
`15`	`15`	`public ?string $next_page_url,`
`16`	`16`	`public ?string $previous_page_url,`
`17`		`- ) {`
`18`		`- }`
	`17`	`+ ) {}`
`19`	`18`
`20`	`19`	`public static function fromResponse(Response $response): self`
`21`	`20`	`{`
Original file line number	Diff line number	Diff line change
`@@ -23,8 +23,7 @@ public function __construct(`
`23`	`23`	`public ?array $thumbnails,`
`24`	`24`	`public ?string $url,`
`25`	`25`	`public ?string $width,`
`26`		`- ) {`
`27`		`- }`
	`26`	`+ ) {}`
`28`	`27`
`29`	`28`	`public static function fromArray(array $data): self`
`30`	`29`	`{`
Original file line number	Diff line number	Diff line change
`@@ -22,8 +22,7 @@ public function __construct(`
`22`	`22`	`public ?int $size,`
`23`	`23`	`public ?string $url,`
`24`	`24`	`public ?string $width,`
`25`		`- ) {`
`26`		`- }`
	`25`	`+ ) {}`
`27`	`26`
`28`	`27`	`public static function fromArray(array $data): self`
`29`	`28`	`{`
Original file line number	Diff line number	Diff line change
`@@ -12,8 +12,7 @@ class CountTicketsDTO extends Data`
`12`	`12`	`public function __construct(`
`13`	`13`	`public ?int $value,`
`14`	`14`	`public ?Carbon $refreshed_at,`
`15`		`- ) {`
`16`		`- }`
	`15`	`+ ) {}`
`17`	`16`
`18`	`17`	`public static function fromResponse(Response $response): self`
`19`	`18`	`{`
Original file line number	Diff line number	Diff line change
`@@ -64,8 +64,7 @@ public function __construct(`
`64`	`64`	`public ?int $via_followup_source_id,`
`65`	`65`	`public ?int $via_id,`
`66`	`66`	`public ?array $voice_comment,`
`67`		`- ) {`
`68`		`- }`
	`67`	`+ ) {}`
`69`	`68`
`70`	`69`	`public static function fromResponse(Response $response): self`
`71`	`70`	`{`