wip

Author: StanBarrows

INTERNAL_CHANGES_GUIDE.patch

@@ -646,10 +646,26 @@ index 57144bd..3f11c16 100644
            coverage: pcov
 
 diff --git a/.github/workflows/playwright.yml b/.github/workflows/playwright.yml
-index d0f9b80..1149c04 100644
+index d0f9b80..56b043c 100644
 --- a/.github/workflows/playwright.yml
 +++ b/.github/workflows/playwright.yml
-@@ -37,7 +37,7 @@ jobs:
+@@ -1,9 +1,13 @@
+-name: Playwright Tests
+-on: [push]
++name: Playwright Tests (disabled)
++on:
++  push:
++    branches-ignore:
++      - '**'
+ permissions:
+   contents: read
+ jobs:
+   test:
++    if: false  # Temporarily disabled
+     runs-on: ubuntu-latest
+     timeout-minutes: 60
+ 
+@@ -37,7 +41,7 @@ jobs:
        - name: "Setup PHP"
          uses: shivammathur/setup-php@v2
          with:
@@ -795,10 +811,10 @@ index 4535267..0000000
 -If you are using the open-source version of solidtime and want to support us, the best way to do so is to spread the word. 
 diff --git a/INTERNAL_CHANGES_GUIDE.md b/INTERNAL_CHANGES_GUIDE.md
 new file mode 100644
-index 0000000..d10d433
+index 0000000..8f9ee5b
 --- /dev/null
 +++ b/INTERNAL_CHANGES_GUIDE.md
-@@ -0,0 +1,299 @@
+@@ -0,0 +1,305 @@
 +## INTERNAL CHANGES GUIDE
 +
 +Authoritative, replayable guide for changes between the base commit and the current working state. Use this document to re-apply the exact same changes on top of any fresh checkout.
@@ -809,7 +825,7 @@ index 0000000..d10d433
 +- **Current branch:** feature-relaunch
 +- **Uncommitted changes at capture time:** none
 +- **Patch file (binary-safe):** `INTERNAL_CHANGES_GUIDE.patch`
-+- **Patch SHA256:** a66ecb7671c6d9568b579a0cdba9c5b3d4711c1b51893b9d928276c0da8deaa1
++- **Patch SHA256:** f780ccdef9900eee8db7dade5252efb5ff911cd76bf3d3c0fa9389a328642592
 +
 +### Replay: Quick Start
 +1) Ensure a clean working tree.
@@ -823,7 +839,7 @@ index 0000000..d10d433
 +3) Verify patch integrity.
 +   ```bash
 +shasum -a 256 INTERNAL_CHANGES_GUIDE.patch
-+# must equal: a66ecb7671c6d9568b579a0cdba9c5b3d4711c1b51893b9d928276c0da8deaa1
++# must equal: f780ccdef9900eee8db7dade5252efb5ff911cd76bf3d3c0fa9389a328642592
 +   ```
 +4) Apply changes.
 +   ```bash
@@ -1041,6 +1057,12 @@ index 0000000..d10d433
 +- **Frontend:** Multiple Vue components updated across Clients/Projects tables, dropdowns, and pages; navigation and layout tweaks; utility hooks adjusted.
 +- **Tests:** e2e tests (`clients.spec.ts`, `projects.spec.ts`) updated.
 +
++### API Behavior Changes (Upgrade Notes)
++- Clients API: `GET /api/v1/organizations/{org}/clients` now returns clients ordered by `name` ascending (was `created_at` desc). If you rely on ordering, update your consumers accordingly.
++- Projects API: `GET /api/v1/organizations/{org}/projects` now returns projects ordered by `name` ascending (was `created_at`-based ordering in some flows). If you relied on creation-time ordering, sort client-side or use a dedicated query param in future versions.
++- Clients API: `DELETE /api/v1/organizations/{org}/clients/{client}` is disabled. It now returns `200` with `{ message: "Client deletion disabled" }` and does not delete data.
++- Projects API: `DELETE /api/v1/organizations/{org}/projects/{project}` is disabled. It now returns `200` with `{ message: "Project deletion disabled" }` and does not delete data.
++
 +### Step-by-Step Protocol (detailed)
 +1) Clean and position on base (or desired) revision.
 +   ```bash
@@ -1055,7 +1077,7 @@ index 0000000..d10d433
 +3) Verify patch file checksum.
 +   ```bash
 +shasum -a 256 INTERNAL_CHANGES_GUIDE.patch
-+# must equal a66ecb7671c6d9568b579a0cdba9c5b3d4711c1b51893b9d928276c0da8deaa1
++# must equal f780ccdef9900eee8db7dade5252efb5ff911cd76bf3d3c0fa9389a328642592
 +   ```
 +4) Apply patch (index + fallback 3-way if needed).
 +   ```bash
@@ -1100,7 +1122,7 @@ index 0000000..d10d433
 +- Update this guide’s header fields (current commit, checksum) and the sections for name-status, numstat, and directory footprint.
 diff --git a/INTERNAL_CHANGES_GUIDE.patch b/INTERNAL_CHANGES_GUIDE.patch
 new file mode 100644
-index 0000000..61a954f
+index 0000000..5866909
 diff --git a/LICENSE.md b/LICENSE.md
 deleted file mode 100644
 index 37df9f9..0000000
@@ -5187,7 +5209,7 @@ index dab9c81..fe0ba9f 100644
 
  test('test that archiving and unarchiving clients works', async ({ page }) => {
 diff --git a/e2e/projects.spec.ts b/e2e/projects.spec.ts
-index 9dd51c5..974f2aa 100644
+index 9dd51c5..105bd41 100644
 --- a/e2e/projects.spec.ts
 +++ b/e2e/projects.spec.ts
 @@ -9,7 +9,9 @@ async function goToProjectsOverview(page: Page) {
@@ -5224,6 +5246,52 @@ index 9dd51c5..974f2aa 100644
  });
 
  test('test that archiving and unarchiving projects works', async ({ page }) => {
+@@ -108,12 +104,12 @@ test('test that updating billable rate works with existing time entries', async
+                 (await response.json()).data.billable_rate === newBillableRate * 100
+         ),
+     ]);
+-    await expect(
+-        page
+-            .getByRole('row')
+-            .first()
+-            .getByText(formatCentsWithOrganizationDefaults(newBillableRate * 100))
+-    ).toBeVisible();
++
++    // UI no longer shows billable rate in the overview by default.
++    // Reopen the edit modal and verify the value was persisted.
++    await page.getByRole('row').first().getByRole('button').click();
++    await page.getByRole('menuitem').getByText('Edit').first().click();
++    await expect(page.getByPlaceholder('Billable Rate')).toHaveValue(newBillableRate.toString());
+ });
+ 
+ // Create new project with new Client
+diff --git a/e2e/tasks.spec.ts b/e2e/tasks.spec.ts
+index 8e2073d..e769ffe 100644
+--- a/e2e/tasks.spec.ts
++++ b/e2e/tasks.spec.ts
+@@ -69,18 +69,12 @@ test('test that creating and deleting a new tag in a new project works', async (
+ 
+     const moreButton = page.locator("[aria-label='Actions for Project " + newProjectName + "']");
+     moreButton.click();
+-    const deleteButton = page.locator("[aria-label='Delete Project " + newProjectName + "']");
+-
++    // Deletion no longer supported: archive instead.
++    const archiveButton = page.locator("[aria-label='Archive Project " + newProjectName + "']");
+     await Promise.all([
+-        deleteButton.click(),
+-        page.waitForResponse(
+-            async (response) =>
+-                response.url().includes('/projects') &&
+-                response.request().method() === 'DELETE' &&
+-                response.status() === 204
+-        ),
++        archiveButton.click(),
++        expect(page.getByTestId('project_table')).not.toContainText(newProjectName),
+     ]);
+-    await expect(page.getByTestId('project_table')).not.toContainText(newProjectName);
+ });
+ 
+ test('test that archiving and unarchiving tasks works', async ({ page }) => {
 diff --git a/e2e/timetracker.spec.ts b/e2e/timetracker.spec.ts
 index c7896ca..5a371a3 100644
 --- a/e2e/timetracker.spec.ts
@@ -11803,6 +11871,152 @@ index 7d56f6a..a843503 100644
          }
          if (type === 'billable') {
              if (key === '0') {
+diff --git a/tests/Unit/Endpoint/Api/V1/ClientEndpointTest.php b/tests/Unit/Endpoint/Api/V1/ClientEndpointTest.php
+index faf2af5..655eb58 100644
+--- a/tests/Unit/Endpoint/Api/V1/ClientEndpointTest.php
++++ b/tests/Unit/Endpoint/Api/V1/ClientEndpointTest.php
+@@ -29,7 +29,7 @@ public function test_index_endpoint_fails_if_user_has_no_permission_to_view_clie
+         $response->assertForbidden();
+     }
+ 
+-    public function test_index_endpoint_returns_list_of_all_clients_of_organization_ordered_by_created_at_desc_per_default(): void
++    public function test_index_endpoint_returns_list_of_all_clients_of_organization_ordered_by_name_asc_per_default(): void
+     {
+         // Arrange
+         $data = $this->createUserWithPermission([
+@@ -44,7 +44,10 @@ public function test_index_endpoint_returns_list_of_all_clients_of_organization_
+         // Assert
+         $response->assertStatus(200);
+         $response->assertJsonCount(4, 'data');
+-        $clients = Client::query()->orderBy('created_at', 'desc')->get();
++        $clients = Client::query()
++            ->whereBelongsTo($data->organization, 'organization')
++            ->orderBy('name')
++            ->get();
+         $response->assertJson(fn (AssertableJson $json) => $json
+             ->has('data')
+             ->has('links')
+@@ -430,7 +433,7 @@ public function test_destroy_endpoint_fails_if_user_is_not_part_of_client_organi
+         ]);
+     }
+ 
+-    public function test_destroy_endpoint_fails_if_client_is_still_in_use_by_project(): void
++    public function test_destroy_endpoint_is_disabled_even_if_client_is_still_in_use_by_project(): void
+     {
+         // Arrange
+         $data = $this->createUserWithPermission([
+@@ -444,14 +447,14 @@ public function test_destroy_endpoint_fails_if_client_is_still_in_use_by_project
+         $response = $this->deleteJson(route('api.v1.clients.destroy', [$data->organization->getKey(), $client->getKey()]));
+ 
+         // Assert
+-        $response->assertStatus(400);
+-        $response->assertJsonPath('message', 'The client is still used by a project and can not be deleted.');
++        $response->assertStatus(200);
++        $response->assertJsonPath('message', 'Client deletion disabled');
+         $this->assertDatabaseHas(Client::class, [
+             'id' => $client->getKey(),
+         ]);
+     }
+ 
+-    public function test_destroy_endpoint_deletes_client(): void
++    public function test_destroy_endpoint_is_disabled_and_does_not_delete_client(): void
+     {
+         // Arrange
+         $data = $this->createUserWithPermission([
+@@ -464,9 +467,9 @@ public function test_destroy_endpoint_deletes_client(): void
+         $response = $this->deleteJson(route('api.v1.clients.destroy', [$data->organization->getKey(), $client->getKey()]));
+ 
+         // Assert
+-        $response->assertStatus(204);
+-        $response->assertNoContent();
+-        $this->assertDatabaseMissing(Client::class, [
++        $response->assertStatus(200);
++        $response->assertJsonPath('message', 'Client deletion disabled');
++        $this->assertDatabaseHas(Client::class, [
+             'id' => $client->getKey(),
+         ]);
+     }
+diff --git a/tests/Unit/Endpoint/Api/V1/ProjectEndpointTest.php b/tests/Unit/Endpoint/Api/V1/ProjectEndpointTest.php
+index c606ed1..7e190c2 100644
+--- a/tests/Unit/Endpoint/Api/V1/ProjectEndpointTest.php
++++ b/tests/Unit/Endpoint/Api/V1/ProjectEndpointTest.php
+@@ -211,11 +211,10 @@ public function test_index_endpoint_does_not_set_billable_rate_to_null_if_member
+             ->has('data')
+             ->has('links')
+             ->has('meta')
+-            ->where('data.0.billable_rate', 112)
+-            ->where('data.1.billable_rate', 112)
+-            ->where('data.2.billable_rate', 113)
+-            ->where('data.3.billable_rate', 113)
+         );
++        $billableRates = $response->json('data.*.billable_rate');
++        sort($billableRates);
++        $this->assertSame([112, 112, 113, 113], $billableRates);
+     }
+ 
+     public function test_show_endpoint_fails_if_user_is_not_part_of_project_organization(): void
+@@ -1133,7 +1132,7 @@ public function test_destroy_endpoint_fails_if_user_has_no_permission_to_delete_
+         $response->assertForbidden();
+     }
+ 
+-    public function test_destroy_endpoint_fails_if_project_is_still_in_use_by_a_task(): void
++    public function test_destroy_endpoint_is_disabled_even_if_project_is_still_in_use_by_a_task(): void
+     {
+         // Arrange
+         $data = $this->createUserWithPermission([
+@@ -1147,14 +1146,14 @@ public function test_destroy_endpoint_fails_if_project_is_still_in_use_by_a_task
+         $response = $this->deleteJson(route('api.v1.projects.destroy', [$data->organization->getKey(), $project->getKey()]));
+ 
+         // Assert
+-        $response->assertStatus(400);
+-        $response->assertJsonPath('message', 'The project is still used by a task and can not be deleted.');
++        $response->assertStatus(200);
++        $response->assertJsonPath('message', 'Project deletion disabled');
+         $this->assertDatabaseHas(Project::class, [
+             'id' => $project->getKey(),
+         ]);
+     }
+ 
+-    public function test_destroy_endpoint_fails_if_project_is_still_in_use_by_a_time_entry(): void
++    public function test_destroy_endpoint_is_disabled_even_if_project_is_still_in_use_by_a_time_entry(): void
+     {
+         // Arrange
+         $data = $this->createUserWithPermission([
+@@ -1168,14 +1167,14 @@ public function test_destroy_endpoint_fails_if_project_is_still_in_use_by_a_time
+         $response = $this->deleteJson(route('api.v1.projects.destroy', [$data->organization->getKey(), $project->getKey()]));
+ 
+         // Assert
+-        $response->assertStatus(400);
+-        $response->assertJsonPath('message', 'The project is still used by a time entry and can not be deleted.');
++        $response->assertStatus(200);
++        $response->assertJsonPath('message', 'Project deletion disabled');
+         $this->assertDatabaseHas(Project::class, [
+             'id' => $project->getKey(),
+         ]);
+     }
+ 
+-    public function test_destroy_endpoint_deletes_project_with_project_members(): void
++    public function test_destroy_endpoint_is_disabled_and_does_not_delete_project_with_project_members(): void
+     {
+         // Arrange
+         $data = $this->createUserWithPermission([
+@@ -1189,12 +1188,12 @@ public function test_destroy_endpoint_deletes_project_with_project_members(): vo
+         $response = $this->deleteJson(route('api.v1.projects.destroy', [$data->organization->getKey(), $project->getKey()]));
+ 
+         // Assert
+-        $response->assertStatus(204);
+-        $response->assertNoContent();
+-        $this->assertDatabaseMissing(Project::class, [
++        $response->assertStatus(200);
++        $response->assertJsonPath('message', 'Project deletion disabled');
++        $this->assertDatabaseHas(Project::class, [
+             'id' => $project->getKey(),
+         ]);
+-        $this->assertDatabaseMissing(ProjectMember::class, [
++        $this->assertDatabaseHas(ProjectMember::class, [
+             'id' => $projectMember->getKey(),
+         ]);
+     }
 diff --git a/vite-module-loader.js b/vite-module-loader.js
 index 69865eb..c6fe43b 100644
 --- a/vite-module-loader.js