Merge pull request #2259 from davidmillen50/set-belongs-to-required-by-default-to-true

chore: set belongs_to_required_by_default to true in config

This is the upcoming default value for this setting, this prepares us for the Rails upgrade.

Author: olleolleolle

app/models/address.rb

@@ -1,3 +1,3 @@
 class Address < ApplicationRecord
-  belongs_to :sponsor
+  belongs_to :sponsor, optional: true
 end

app/models/attendance_warning.rb

@@ -1,6 +1,6 @@
 class AttendanceWarning < ApplicationRecord
   belongs_to :member
-  belongs_to :issued_by, class_name: 'Member', foreign_key: 'sent_by_id', inverse_of: false
+  belongs_to :issued_by, class_name: 'Member', foreign_key: 'sent_by_id', inverse_of: false, optional: true
 
   scope :last_six_months, -> { where(created_at: 6.months.ago...Time.zone.now) }
 

app/models/auth_service.rb

@@ -1,4 +1,4 @@
 class AuthService < ApplicationRecord
-  belongs_to :member
+  belongs_to :member, optional: true
   validates :uid, uniqueness: { constraint: :provider }
 end

app/models/ban.rb

@@ -1,5 +1,5 @@
 class Ban < ApplicationRecord
-  belongs_to :member
+  belongs_to :member, optional: true
   belongs_to :added_by, class_name: 'Member'
 
   validates :expires_at, :reason, :note, :added_by, presence: true

app/models/contact.rb

@@ -1,6 +1,6 @@
 require 'services/mailing_list'
 class Contact < ApplicationRecord
-  belongs_to :sponsor
+  belongs_to :sponsor, optional: true
 
   validates :name, :surname, :email, presence: true
 

app/models/event.rb

@@ -8,7 +8,7 @@ class Event < ApplicationRecord
 
   resourcify :permissions, role_cname: 'Permission', role_table_name: :permission
 
-  belongs_to :venue, class_name: 'Sponsor'
+  belongs_to :venue, class_name: 'Sponsor', optional: true
   has_many :sponsorships
   has_many :sponsors, -> { where('sponsorships.level' => nil) }, through: :sponsorships, source: :sponsor
   has_many :bronze_sponsors, -> { where('sponsorships.level' => 'bronze') }, through: :sponsorships, source: :sponsor

app/models/feedback.rb

@@ -1,7 +1,7 @@
 class Feedback < ApplicationRecord
   belongs_to :tutorial
   belongs_to :coach, class_name: 'Member'
-  belongs_to :workshop
+  belongs_to :workshop, optional: true
   has_one :chapter, through: :workshop
 
   validates :rating, inclusion: { in: 1..5, message: "can't be blank" }

app/models/feedback_request.rb

@@ -1,6 +1,6 @@
 class FeedbackRequest < ApplicationRecord
   belongs_to :member
-  belongs_to :workshop
+  belongs_to :workshop, optional: true
 
   validates :member_id, presence: true, uniqueness: { scope: [:workshop] }
   validates :workshop, presence: true

app/models/invitation.rb

@@ -3,7 +3,7 @@ class Invitation < ApplicationRecord
 
   belongs_to :event
   belongs_to :member
-  belongs_to :verified_by, class_name: 'Member'
+  belongs_to :verified_by, class_name: 'Member', optional: true
 
   validates :event, :member, presence: true
   validates :member_id, uniqueness: { scope: %i[event_id role] }

app/models/meeting_talk.rb

@@ -1,6 +1,6 @@
 class MeetingTalk < ApplicationRecord
-  belongs_to :speaker, class_name: 'Member'
-  belongs_to :meeting
+  belongs_to :speaker, class_name: 'Member', optional: true
+  belongs_to :meeting, optional: true
 
   validates :title, :abstract, :speaker, :meeting, presence: true