Add tests for model code

This adds three tests for the model method and improves the model method

Signed-off-by: jonathan.kerr <[email protected]>

Author: jonodrew

app/models/member.rb

@@ -119,7 +119,7 @@ def recent_notes
   end
 
   def self.find_members(name)
-    where('name ILIKE ?', "%#{name}%").or(where('surname ILIKE ?', "%#{name}%"))
+    where("CONCAT(name, ' ', surname) ILIKE ?", "%#{name}%")
   end
 
   private

spec/models/member_spec.rb

@@ -137,4 +137,25 @@
       expect(member.flag_to_organisers?).to be true
     end
   end
+
+  describe '#find_members' do
+    describe 'search by first name' do
+      it "should find the member" do
+        expect(Member.find_members(member.name).first).to eq(member)
+      end
+    end
+
+    describe 'search by last name' do
+      it "should find the member" do
+        expect(Member.find_members(member.surname).first).to eq(member)
+      end
+    end
+
+    describe 'search by full name' do
+      it "should find the member" do
+        expect(Member.find_members("#{member.name} #{member.surname}").first).to eq(member)
+      end
+    end
+
+  end
 end