Change method name

This better reflects what the method actually does

Signed-off-by: jonathan.kerr <[email protected]>

Author: jonodrew

app/controllers/admin/member_search_controller.rb

@@ -2,7 +2,7 @@ class Admin::MemberSearchController < Admin::ApplicationController
   def index
     member_params = params[:member_search] || {}
     name = member_params[:name]
-    members = name.blank? ? Member.none : Member.find_members(name).select(:id, :name, :surname, :pronouns)
+    members = name.blank? ? Member.none : Member.find_members_by_name(name).select(:id, :name, :surname, :pronouns)
     callback_url = member_params[:callback_url] || params[:callback_url] || results_admin_member_search_index_path
     if members.size == 1
       query = { member_pick: { members: [members.first.id] } }

app/models/member.rb

@@ -118,7 +118,7 @@ def recent_notes
     member_notes.where('created_at > ?', notes_from_date)
   end
 
-  def self.find_members(name)
+  def self.find_members_by_name(name)
     name.strip!
     name.eql?('') ? self.none : where("CONCAT(name, ' ', surname) ILIKE ?", "%#{name}%")
   end

spec/controllers/admin/member_search_controller_spec.rb

@@ -25,7 +25,7 @@
 
       context "and when admin user searches for a single existing user" do
         before do
-          allow(Member).to receive(:find_members).with('Juliet').and_return(fake_relation)
+          allow(Member).to receive(:find_members_by_name).with('Juliet').and_return(fake_relation)
           allow(fake_relation).to receive(:select).with(any_args).and_return([fake_juliet])
           get :index, params: {member_search: {name: "Juliet", callback_url: root_path}}
         end
@@ -43,7 +43,7 @@
       let(:fake_romeo) { double('Member', id: 2, name: 'Romeo', surname: 'Capulet')}
 
         before do
-          allow(Member).to receive(:find_members).with('e').and_return(fake_relation)
+          allow(Member).to receive(:find_members_by_name).with('e').and_return(fake_relation)
           allow(fake_relation).to receive(:select).with(any_args).and_return([fake_juliet, fake_romeo])
           get :index, params: {member_search: {name: 'e', callback_url: root_path}}
         end

spec/models/member_spec.rb

@@ -141,27 +141,27 @@
   describe '#find_members' do
     describe 'search by first name' do
       it 'finds the member' do
-        expect(Member.find_members(member.name).first).to eq(member)
+        expect(Member.find_members_by_name(member.name).first).to eq(member)
       end
     end
 
     describe 'search by last name' do
       it 'finds the member' do
-        expect(Member.find_members(member.surname).first).to eq(member)
+        expect(Member.find_members_by_name(member.surname).first).to eq(member)
       end
     end
 
     describe 'search by full name' do
       it 'finds the member' do
-        expect(Member.find_members("#{member.name} #{member.surname}").first).to eq(member)
+        expect(Member.find_members_by_name("#{member.name} #{member.surname}").first).to eq(member)
       end
     end
 
     describe 'search bar is empty' do
       it 'returns no members' do
         Fabricate(:member)
         expect(Member.all.size).to be > 0
-        expect(Member.find_members('').size).to eq(0)
+        expect(Member.find_members_by_name('').size).to eq(0)
       end
     end