Add first passing test

Should have started with this! This adds the first test, which surfaced a load of things I'd not done properly. These are now fixed and the test is green

Author: jonodrew

app/controllers/admin/member_search_controller.rb

@@ -5,15 +5,17 @@ def index
     @members = @name.blank? ? Member.none : Member.find_members(@name).select(:id, :name, :surname, :pronouns)
     @callback_url = @params[:callback] || results_admin_member_search_index_path
     if (@members.size == 1) && @callback_url.present?
-      return redirect_to @callback_url, member_id: @members.first.id
+      query = { member_pick: { members: [@members.pluck(:id)] } }
+      query_string = query.to_query
+      @callback_url = "#{@callback_url}?#{query_string}"
+      redirect_to @callback_url and return
     end
 
     render 'index', locals: { members: @members, callback: @callback_url }
   end
 
   def results
-    params.require(:member_pick).permit(members: [])
-    @members = params[:member_pick].present? ? Member.find(params[:member_pick][:members]) : Member.none
+    @members = Member.find(params[:member_pick][:members])
     render 'show', locals: { members: @members }
   end
 end

app/views/admin/member_search/_search_form.html.haml

@@ -3,3 +3,4 @@
     .col-12.col-md-6
       = f.input :name, label: 'Member Name', input_html: { placeholder: 'Enter member name' }
       = f.button :submit, 'Search', class: 'btn btn-primary mt-3', name: nil
+      = f.hidden_field 'callback', :value => @callback_url  

spec/features/admin/member_search_spec.rb

@@ -1,13 +1,20 @@
 require 'spec_helper'
 
 RSpec.feature 'admin member search', type: :feature do
-  scenario 'search returns correct member' do
-    romeo = Fabricate(:member, :name => 'Romeo', :surname => 'Montague')
-    juliet = Fabricate(:member, :name => 'Juliet', :surname => 'Capulet')
+  scenario 'search returns single member to requesting service' do
+    Fabricate(:member, :name => 'Romeo', :surname => 'Montague')
+    Fabricate(:member, :name => 'Juliet', :surname => 'Capulet')
     member = Fabricate(:member)
-    login(member)
-    visit admin_member_search_index_path(member_search: { name: 'Julie' })
+    login_as_admin(member)
+    visit admin_member_search_index_path(callback: results_admin_member_search_index_path)
 
-    expect(current_url).to eq(root_url)
+    fill_in 'member_search_name', with: 'Julie'
+    click_button 'Search'
+
+    expect(page).to have_current_path(results_admin_member_search_index_path, ignore_query: true)
+
+    expect(page).to have_content('Juliet Capulet')
   end
+
+
 end