Switch to using local variables only

Based on feedback from @olleolleolle, I've updated this controller to only use local variables

Signed-off-by: jonathan.kerr <[email protected]>

Author: jonodrew

app/controllers/admin/member_search_controller.rb

@@ -2,20 +2,20 @@ class Admin::MemberSearchController < Admin::ApplicationController
   def index
     member_params = params[:member_search] || {}
     name = member_params[:name]
-    @members = name.blank? ? Member.none : Member.find_members(name).select(:id, :name, :surname, :pronouns)
-    @callback_url = member_params[:callback_url] || params[:callback_url] || results_admin_member_search_index_path
-    if @members.size == 1
-      query = { member_pick: { members: [@members.first.id] } }
+    members = name.blank? ? Member.none : Member.find_members(name).select(:id, :name, :surname, :pronouns)
+    callback_url = member_params[:callback_url] || params[:callback_url] || results_admin_member_search_index_path
+    if members.size == 1
+      query = { member_pick: { members: [members.first.id] } }
       query_string = query.to_query
-      callback_url = "#{@callback_url}?#{query_string}"
+      callback_url = "#{callback_url}?#{query_string}"
       redirect_to callback_url and return
     end
 
-    render 'index', locals: { members: @members, callback_url: @callback_url }
+    render 'index', locals: { members: members, callback_url: callback_url }
   end
 
   def results
-    @members = Member.find(params[:member_pick][:members])
-    render 'show', members: @members
+    members = Member.find(params[:member_pick][:members])
+    render 'show',locals: { members: members }
   end
 end

app/views/admin/member_search/show.html.haml

@@ -7,6 +7,6 @@
       .col.col-md-10.col-lg-8
         %h2 Search Results
         %ul.list-group
-          - @members.each do |member|
+          - members.each do |member|
             %li.list-group-item
-              = link_to member.name_and_surname, admin_member_path(member)
+              = link_to member.name_and_surname, admin_member_path(member)